luggage 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e5b8e6299a00d76b3bc1eb4ed219c2baea76d4c6
-  data.tar.gz: 836c4a9c74f7588a6c561ac1264ce6c568859afc
+  metadata.gz: 05ff8f011e4e73d7be9c891dac56c206f28d9fc4
+  data.tar.gz: 92a3d1845a0de22df435c7f3e78eec6150a69f24
 SHA512:
-  metadata.gz: 6659b895e186f99a30049b9daeab543cb0f7b9f060b0ed22d8255bad2fb37234fddc89d4b8039a7d1d5c1a05459bf81154dba66290a69bbd0572ad2d7bd5d544
-  data.tar.gz: d87f9515631498aa341f1c378169e9590fd174fedcc07daadb648e08dd9450869a40ff0329e24d30340f4c026f161e065363c3e4b7b6e1b8b81e58d4b04044e0
+  metadata.gz: 00a3930bf00f7376a0b43f8f25b857b7f44b1c3b68d5fe80e9bcde1127914eb546cb80b2692d6580d270c15966246a01157948621914725d63107ec0f395f6cd
+  data.tar.gz: 2c8fed78b22756f2a80d26f1bbd558c75faba9161a3b3b624688c4cdb2dcf91fbd1d9401987fabebb28a1b8d9b3396ff771f9d31cd0b41099442885fb9912f0f

data/CHANGES.md

@@ -1,5 +1,10 @@
 #Changes
 
+## 1.1.1
+
+* Fix bug when trying to use XOAUTH to authenticate. - Ben Hamill
+* Remove several cases of excessive argument type checking. - Ben Hamill
+
 ## 1.1.0
 
 * Added `:login` authentication method to `Luggage.new`. - Ben Hamill

data/lib/luggage/factory.rb

@@ -27,7 +27,7 @@ module Luggage
 
       elsif args.has_key?(:server) && args.has_key?(:xoauth)
         @connection = Net::IMAP.new(*Array(args[:server]))
-        @connection.authenticate('XOAUTH', *Array(args[:xoauth]))
+        @connection.send(:send_command, "AUTHENTICATE XOAUTH #{Array(args[:xoauth]).join(' ')}")
 
       elsif args.has_key?(:server) && args.has_key?(:login)
         @connection = Net::IMAP.new(*Array(args[:server]))

data/lib/luggage/mailbox.rb

@@ -11,9 +11,6 @@ module Luggage
     # `name` is the name of the remote mailbox
     #
     def initialize(connection, name, &block)
-      raise ArgumentError, "Net::IMAP connection required" unless connection.kind_of?(Net::IMAP)
-      raise ArgumentError, "name required" unless name.present?
-
       @connection = connection
       @name = name
 

data/lib/luggage/message.rb

@@ -40,8 +40,6 @@ module Luggage
     # `args[:message_id]` use this as for the Message-ID header.  This header is used to identify messages across requests
     #
     def initialize(connection, mailbox, args = {}, &block)
-      raise ArgumentError, "Net::IMAP connection required" unless connection.kind_of?(Net::IMAP)
-
       @connection = connection
       @mailbox = mailbox.kind_of?(Mailbox) ? mailbox : Mailbox.new(connection, mailbox)
       @flags = []
@@ -49,8 +47,6 @@ module Luggage
       @template = args[:template]
       @message_id = args[:message_id] || "<#{UUIDTools::UUID.random_create}@test.oib.com>"
 
-      raise ArgumentError, "mailbox requried" unless @mailbox.present?
-
       instance_eval &block if block_given?
     end
 

data/lib/luggage/version.rb

@@ -1,3 +1,3 @@
 module Luggage
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/luggage/factory_spec.rb

@@ -18,6 +18,11 @@ describe Luggage::Factory do
       expect(Luggage.new(:server => :foo, :xoauth => "token").connection).to be_a(Net::IMAP)
     end
 
+    it "accepts :server and :login, and creates a connection" do
+      Net::IMAP.any_instance.stub(:login).and_return(true)
+      expect(Luggage.new(:server => :foo, :login => %w(username password)).connection).to be_a(Net::IMAP)
+    end
+
     it "requires a way to build a connection" do
       expect { Luggage.new }.to raise_error(ArgumentError)
     end

data/spec/luggage/mailbox_spec.rb

@@ -15,10 +15,6 @@ describe Luggage::Mailbox do
       expect(Luggage::Mailbox.new(connection, :mailbox).connection).to eq(connection)
     end
 
-    it "requires a connection" do
-      expect { Luggage::Mailbox.new(:foo, :mailbox).connection }.to raise_error(ArgumentError)
-    end
-
     it "sets the name" do
       expect(Luggage::Mailbox.new(connection, :mailbox).name).to eq(:mailbox)
     end

data/spec/luggage/message_spec.rb

@@ -15,10 +15,6 @@ describe Luggage::Message do
       expect(Luggage::Message.new_local(connection, "Inbox")).to be_a(Luggage::Message)
     end
 
-    it "raises ArgumentError if Luggage::Mailbox isn't passed" do
-      expect{ Luggage::Message.new_local() }.to raise_error(ArgumentError)
-    end
-
     [:subject, :body, :to].each do |method|
       context "with #{method} passed as argument" do
         it "sets #{method} on Mail object" do
@@ -57,10 +53,6 @@ describe Luggage::Message do
       expect(Luggage::Message.new(connection, :mailbox).connection).to eq(connection)
     end
 
-    it "requires a connection" do
-      expect { Luggage::Message.new(:not_a_connection, :mailbox).connection }.to raise_error(ArgumentError)
-    end
-
     it "sets mailbox if Mailbox passed" do
       expect(Luggage::Message.new(connection, mailbox).mailbox).to eq(mailbox)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: luggage
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Ryan Michael