loxxy 0.1.05 → 0.1.06

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8eae41b5b093b55c02a81bbe81b08202eb4ecd64c1dd288246c0cd4af44c627
-  data.tar.gz: 208158a80e89e789d74c66f295ee4cbec6d37e6d9f3185dedfbcaa30a156fe35
+  metadata.gz: 293bf5f6fb0eb5a1daf2723484a2867909c03cc99b20270e562d288d334f0bdc
+  data.tar.gz: 9e26854c6d4334f9869d0cd420ebd4365c0f978666e7ede8310d25e600cf5834
 SHA512:
-  metadata.gz: dc1393417a3cdb013fdbcc085dcb3ba7dda45784e73a26ef44c1ee21b4322a9a18063d16c0cae7d3266be829ce31c6090773ba1631712211c388d84b21e0161d
-  data.tar.gz: 2f07cb2e882fbff31b73eee169a99849729b8f4136888335b2915a183ff32ed8aa78a66d93ea7765f0b09f0747b4b09cfae2aece5ca7478f41892b173a0ce2ab
+  metadata.gz: 2ac692f16a41b162001fee869d426abf634f1a2bb82bf17eac26d8c35939a8ca63234246a6ff88cc04db3833057b445e2650773652ce102a0dcc4f3aa90182e8
+  data.tar.gz: 2764cb3d1703fdc948180cb2060f93a0ef72148f2877f5b711ecacd17d2ba52a9d3b9f7736eb53130850635cb0d127f2a5161a8361cb4a2268fc6275d15a6b1c

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [0.1.06] - 2021-03-06
+- Parameters/arguments checks in function declaration and call
+
+### Changed
+- Method `Ast::AstBuilder#reduce_call_arglist` raises a `Loxxy::RuntimeError` when more than 255 arguments are used.
+- Method `BackEnd::Engine#after_call_expr` raises a `Loxxy::RuntimeError` when argument count doesn't match the arity of function.
+
+- Class `BackEnd::Function` renamed to `LoxFunction`
+
 ## [0.1.05] - 2021-03-05
 - Test for Fibbonacci recursive function is now passing.
 

data/lib/loxxy/ast/ast_builder.rb

@@ -273,7 +273,7 @@ module Loxxy
       def reduce_call_arglist(_production, _range, tokens, theChildren)
         args = theChildren[1] || []
         if args.size > 255
-          raise StandardError, "Can't have more than 255 arguments."
+          raise Loxxy::RuntimeError, "Can't have more than 255 arguments."
         end
 
         LoxCallExpr.new(tokens[0].position, args)
@@ -303,6 +303,10 @@ module Loxxy
       def reduce_function(_production, _range, _tokens, theChildren)
         first_child = theChildren.first
         pos = first_child.token.position
+        if theChildren[2] && theChildren[2].size > 255
+          msg = "Can't have more than 255 parameters."
+          raise Loxxy::SyntaxError, msg
+        end
         LoxFunStmt.new(pos, first_child.token.lexeme, theChildren[2], theChildren[4])
       end
 

data/lib/loxxy/back_end/engine.rb

@@ -3,7 +3,7 @@
 # Load all the classes implementing AST nodes
 require_relative '../ast/all_lox_nodes'
 require_relative 'binary_operator'
-require_relative 'function'
+require_relative 'lox_function'
 require_relative 'symbol_table'
 require_relative 'unary_operator'
 
@@ -199,18 +199,18 @@ module Loxxy
         case callee
         when NativeFunction
           stack.push callee.call # Pass arguments
-        when Function
+        when LoxFunction
+          arg_count = aCallExpr.arguments.size
+          if arg_count != callee.arity
+            msg = "Expected #{callee.arity} arguments but got #{arg_count}."
+            raise Loxxy::RuntimeError, msg
+          end
           callee.call(self, aVisitor)
         else
           raise Loxxy::RuntimeError, 'Can only call functions and classes.'
         end
       end
 
-      def complete_call
-        callee = ret_stack.pop
-        symbol_table.leave_environment if callee.kind_of?(Function)
-      end
-
       def after_grouping_expr(_groupingExpr)
         # Do nothing: work was already done by visiting /evaluating the subexpression
       end
@@ -234,7 +234,7 @@ module Loxxy
       end
 
       def after_fun_stmt(aFunStmt, _visitor)
-        function = Function.new(aFunStmt.name, aFunStmt.params, aFunStmt.body, stack)
+        function = LoxFunction.new(aFunStmt.name, aFunStmt.params, aFunStmt.body, stack)
         new_var = Variable.new(aFunStmt.name, function)
         symbol_table.insert(new_var)
       end
@@ -260,7 +260,7 @@ module Loxxy
         unary_operators[:-@] = negate_op
 
         negation_op = UnaryOperator.new('!', [Datatype::BuiltinDatatype,
-          BackEnd::Function])
+          BackEnd::LoxFunction])
         unary_operators[:!] = negation_op
       end
 

data/lib/loxxy/back_end/{function.rb → lox_function.rb}

@@ -7,7 +7,7 @@ module Loxxy
     # rubocop: disable Style/AccessorGrouping
     # Representation of a Lox function.
     # It is a named slot that can be associated with a value at the time.
-    class Function
+    class LoxFunction
       # @return [String]
       attr_reader :name
 
@@ -26,6 +26,10 @@ module Loxxy
         @stack = aStack
       end
 
+      def arity
+        parameters ? parameters.size : 0
+      end
+
       def accept(_visitor)
         stack.push self
       end

data/lib/loxxy/error.rb

@@ -6,4 +6,7 @@ module Loxxy
 
   # Error occurring while Loxxy executes some invalid Lox code.
   class RuntimeError < Error; end
+
+  # Error occurring while Loxxy parses some invalid Lox code.
+  class SyntaxError < Error; end
 end

data/lib/loxxy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Loxxy
-  VERSION = '0.1.05'
+  VERSION = '0.1.06'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: loxxy
 version: !ruby/object:Gem::Version
-  version: 0.1.05
+  version: 0.1.06
 platform: ruby
 authors:
 - Dimitri Geshef
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-05 00:00:00.000000000 Z
+date: 2021-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rley
@@ -113,7 +113,7 @@ files:
 - lib/loxxy/back_end/engine.rb
 - lib/loxxy/back_end/entry.rb
 - lib/loxxy/back_end/environment.rb
-- lib/loxxy/back_end/function.rb
+- lib/loxxy/back_end/lox_function.rb
 - lib/loxxy/back_end/symbol_table.rb
 - lib/loxxy/back_end/unary_operator.rb
 - lib/loxxy/back_end/variable.rb