lowered-expectations 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2fd98bbb73967a109a601bfead6bcbe8f3431646
-  data.tar.gz: cc882dfd03ebec15f64e7b1ad7e50d7d1e12c353
+  metadata.gz: f17c84deb4d08951a3eaba2467b6eb565adc9736
+  data.tar.gz: febd20b442c3b8fae728ef969951f9264df23289
 SHA512:
-  metadata.gz: 8546cbb024fa93345bf7a258368dc957184ef4cce5ea02730c87a804a64ff1dd3bf316402831b094409b52c2b25af59d377033a82134252a67363971ae02d72b
-  data.tar.gz: 1cace52623498e077b6ac55c6d5980d7e886d3b73e151c5b81e88dda708f2557e517729d514b64768d170a46ba3ef7a2bc41371137d4ae61336ac9f3ba9f299b
+  metadata.gz: 1e8e70bf8c64473fdd8b524aeec08e6035304ed43c0e04d3dc618f9ac2faef43ae41488dbd4ed67af583388125c770c2b55e5c95ca52131bbf10d0fbd8d267ec
+  data.tar.gz: 1eb2eeb5f8ba99a4932907815503f3cc5b97d20e79afab708a4adf245ae980688c2800a17d609c124f7be417275d1d60dd6685ae06944c2210acf5f2d486e237

data/COPYRIGHT

@@ -4,6 +4,7 @@ Including, but not limited to:
 
   Ian Chesal
   Derek Tamsen
+  Grier Johnson
 
 For licensing information please see LICENSE. Copyright holders contributing to
 this project agree to have their contributions licensed under the terms of the

data/RELEASENOTES.md

@@ -1,5 +1,9 @@
 # lowered-expectations Release Notes
 
+## 1.0.3
+
+* Bugfix for exitstatus checks when running in quiet mode
+
 ## 1.0.2
 
 * Updated rubocop library to cover CVE-2017-8418

data/lib/lowered/expectations.rb

@@ -4,7 +4,7 @@ require 'shellwords'
 require 'pty'
 
 class LoweredExpectations
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 
   class VersionPatternError < StandardError
   end
@@ -48,6 +48,7 @@ class LoweredExpectations
     if quiet
       # Run without streaming std* to any screen
       stdout, stderr, status = Open3.capture3(cmd)
+      status = status.exitstatus
     else
       # Run but stream as well as capture stdout to the screen
       status = pty(cmd) do |r,w,pid|

data/lowered-expectations.gemspec

@@ -5,7 +5,7 @@ require 'lowered/expectations'
 Gem::Specification.new do |spec|
   spec.name          = "lowered-expectations"
   spec.version       = LoweredExpectations::VERSION
-  spec.authors       = ["Ian Chesal", "Derek Tamsen"]
+  spec.authors       = ["Ian Chesal", "Derek Tamsen", "Grier Johnson"]
   spec.email         = ["ian.chesal@gmail.com"]
   spec.summary       = 'A library for testing versions of command line tools.'
   spec.description   = <<-END

data/spec/integration/lowered/expectations_integration_spec.rb

@@ -26,4 +26,26 @@ RSpec.describe LoweredExpectations do
       expect{LoweredExpectations.which 'sometoolthatdoesnotexist'}.to raise_error(LoweredExpectations::MissingExecutableError)
     end
   end
+
+  describe '.run!' do
+    let(:tool_path) { LoweredExpectations.which(tool) }
+    let(:tool_output) { `#{tool_path} --version` }
+    it 'returns stdout' do
+      expect(LoweredExpectations.send('run!', tool, '--version').delete("\r")).to eq tool_output
+    end
+
+    it 'returns stdout in quiet mode' do
+      expect(LoweredExpectations.send('run!', tool, '--version', quiet: true).delete("\r")).to eq tool_output
+    end
+
+    it 'raises an error when the executable returns non-zero' do
+      expect{LoweredExpectations.send('run!', tool, '--versssion')}
+        .to raise_error(LoweredExpectations::CommandExecutionError)
+    end
+
+    it 'raises an error when the executable returns non-zero in quiet mode' do
+      expect{LoweredExpectations.send('run!', tool, '--versssion', quiet: true)}
+        .to raise_error(LoweredExpectations::CommandExecutionError)
+    end
+  end
 end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: lowered-expectations
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Ian Chesal
 - Derek Tamsen
+- Grier Johnson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-03 00:00:00.000000000 Z
+date: 2018-09-07 00:00:00.000000000 Z
 dependencies: []
 description: |
   A Ruby gem that lets you test for the presence of command line tools and ensure
@@ -64,7 +65,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14.1
 signing_key: 
 specification_version: 4
 summary: A library for testing versions of command line tools.