lowered-expectations 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6fde866d7ef044f992d41ceaec599d76f457ec54
-  data.tar.gz: 92dd27194ff2e1d6e8ae93908d711c66b0eb9684
+  metadata.gz: 5598c5def9d9ab355cb246c5c80823c222c3209d
+  data.tar.gz: 9c5c91fa08a995dc767d295ae281e9dc8cbcb3ae
 SHA512:
-  metadata.gz: 84a7d7c280607d6c26eedabd8f0d3850a91f0276f79e6a565cbd202563ce7cc5273f7b673bf5eb31ca04915ef3b1c140cc4c79351cfed595f9322cbfc346e683
-  data.tar.gz: 3711f07d56a348f6672ec29d2b3ca95b3a0973a2d610ab9b5c4e7c1475006741bed55397138c948d0c9b426f4a570599a8459c0b4637189f908d90df3fcfecb7
+  metadata.gz: 05321eb404425a6ce9858a6b11e4f8b0db99abad15a5aca106c6d181a26de3d83357c82ebb6c7a63e01d8bbaa7f3047c73e16bdfa1808b99e9caa031f2922536
+  data.tar.gz: e29aa87ce0365b2f6312a085a3ccbb08d1741cc38a6cac94293046d920ce9879d8c970cf777332096573f049a391e665e73cc5d11af55cf172bcf0e76830e6d5

data/.rubocop.yml

@@ -108,11 +108,6 @@ SelfAssignment:
 SignalException:
   Enabled: false
 
-# Offense count: 53
-# Cop supports --auto-correct.
-SingleSpaceBeforeFirstArg:
-  Enabled: false
-
 SpaceAroundOperators:
   Enabled: false
 
@@ -214,6 +209,9 @@ Style/EmptyLines:
 Style/EmptyLinesAroundAccessModifier:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/GuardClause:
   Enabled: false
 
@@ -304,10 +302,6 @@ Style/NumericLiterals:
 Metrics/ParameterLists:
   Enabled: false
 
-Style/TrailingComma:
-  # EnforcedStyleForMultiline: comma
-  Enabled: false
-
 Metrics/CyclomaticComplexity:
   Enabled: false
 

data/COPYRIGHT

@@ -0,0 +1,10 @@
+Unless specified otherwise, all content copyright the respective contributors.
+
+Including, but not limited to:
+
+  Ian Chesal
+  Derek Tamsen
+
+For licensing information please see LICENSE. Copyright holders contributing to
+this project agree to have their contributions licensed under the terms of the
+LICENSE agreement.

data/Gemfile

@@ -1,17 +1,12 @@
-# Copyright 2015 Ian Chesal
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-
 source 'https://rubygems.org'
 
 gemspec
+
+group :development, :test do
+  gem "bundler", "~> 1.7"
+  gem "rake", "~> 10.4"
+  gem "rspec", "~> 3.0"
+  gem "rspec-mocks", "~> 3.0"
+  gem "rubocop", "~> 0.36"
+  gem "rubygems-tasks", "~> 0.2"
+end

data/RELEASENOTES.md

@@ -1,5 +1,11 @@
 # lowered-expectations Release Notes
 
+## 1.0.1
+
+* Move development dependencies out of the gemspec into the gemfile.
+* Fix spec and integration tests to look for specific raised error for `.which` method.
+* Resolve `NameError` raise on checking path to see if command exists.
+
 ## 1.0.0
 
 * Our first release

data/Rakefile

@@ -1,38 +1,3 @@
 # Encoding: utf-8
-# Copyright 2015 Ian Chesal
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-
-require 'rubocop/rake_task'
-require 'rspec/core/rake_task'
-require 'rake/clean'
-
-RuboCop::RakeTask.new(:lint)
-
+Dir.glob('tasks/**/*.rake').each(&method(:import))
 task :default => [:lint, 'test:spec']
-
-task :build => [:lint, 'test:spec', 'test:integration'] do
-  sh "gem build --verbose lowered-expectations.gemspec"
-end
-
-namespace :test do
-  RSpec::Core::RakeTask.new(:spec) do |t|
-    t.pattern = Dir['spec/**/*_spec.rb'].reject{ |f| f['/integration'] }
-  end
-
-  RSpec::Core::RakeTask.new(:integration) do |t|
-    t.pattern = "spec/integration/**/*_spec.rb"
-  end
-end
-
-CLEAN.add FileList['lowered-expectations-*.gem']

data/lib/lowered/expectations.rb

@@ -1,23 +1,12 @@
 # Encoding: utf-8
-# Copyright 2015 Ian Chesal
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
 require 'rubygems/dependency'
 require 'open3'
 require 'shellwords'
 require 'pty'
 
 class LoweredExpectations
+  VERSION = '1.0.1'.freeze
+
   class VersionPatternError < StandardError
   end
 
@@ -44,7 +33,7 @@ class LoweredExpectations
         return exe if File.executable?(exe) && !File.directory?(exe)
       end
     end
-    raise MissingExecutableError.new("#{executable} not found in #{ENV['PATH']}")
+    raise MissingExecutableError.new("#{cmd} not found in #{ENV['PATH']}")
   end
 
   def self.verify_version(version, pattern)
@@ -65,7 +54,7 @@ class LoweredExpectations
         while !r.eof?
           c = r.getc
           stdout << c
-          $stdout.write "#{c}"
+          $stdout.write c.to_s
         end
         Process.wait(pid)
       end

data/lowered-expectations.gemspec

@@ -1,24 +1,14 @@
 # Encoding: utf-8
-# Copyright 2015 Ian Chesal
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'lowered/expectations'
 
 Gem::Specification.new do |spec|
   spec.name          = "lowered-expectations"
-  spec.version       = "1.0.0"
+  spec.version       = LoweredExpectations::VERSION
   # For deploying alpha versions via Travis CI
   spec.version       = "#{spec.version}-alpha-#{ENV['TRAVIS_BUILD_NUMBER']}" if ENV['TRAVIS']
-  spec.authors       = ["Ian Chesal"]
+  spec.authors       = ["Ian Chesal", "Derek Tamsen"]
   spec.email         = ["ian.chesal@gmail.com"]
   spec.summary       = 'A library for testing versions of command line tools.'
   spec.description   = <<-END
@@ -36,10 +26,4 @@ END
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.4"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rspec-mocks", "~> 3.0"
-  spec.add_development_dependency "rubocop", "~> 0.24"
 end

data/spec/integration/lowered/expectations_integration_spec.rb

@@ -19,11 +19,11 @@ RSpec.describe LoweredExpectations do
 
   describe '.which' do
     it 'returns true when the executable is on the PATH' do
-      expect(LoweredExpectations.which tool).to be_truthy
+      expect(LoweredExpectations.which(tool)).to be_truthy
     end
 
     it 'raises an error when the executable is not on the PATH' do
-      expect{LoweredExpectations.which 'sometoolthatdoesnotexist'}.to raise_error
+      expect{LoweredExpectations.which 'sometoolthatdoesnotexist'}.to raise_error(LoweredExpectations::MissingExecutableError)
     end
   end
 end

data/spec/lowered/expectations_spec.rb

@@ -44,22 +44,22 @@ Features: AsynchDNS GSS-Negotiate IPv6 Largefile NTLM NTLM_WB SSL lib"
 
   describe '.which' do
     it 'returns true when the executable is on the PATH' do
-      expect(LoweredExpectations.which tool).to be_truthy
+      expect(LoweredExpectations.which(tool)).to be_truthy
     end
 
     it 'raises an error when the executable is not on the PATH' do
-      expect{LoweredExpectations.which 'sometoolthatdoesnotexist'}.to raise_error
+      expect{LoweredExpectations.which 'sometoolthatdoesnotexist'}.to raise_error(LoweredExpectations::MissingExecutableError)
     end
   end
 
   describe '.verify_version' do
     it 'returns true when the version string matches the version pattern' do
-      expect(LoweredExpectations.verify_version version, '~> 0.1').to        be_truthy
-      expect(LoweredExpectations.verify_version version, '~> 0').to          be_truthy
-      expect(LoweredExpectations.verify_version version, '> 0.1.1').to       be_truthy
-      expect(LoweredExpectations.verify_version version, '< 1').to           be_truthy
-      expect(LoweredExpectations.verify_version version, '> 0').to           be_truthy
-      expect(LoweredExpectations.verify_version version, "= #{version}").to  be_truthy
+      expect(LoweredExpectations.verify_version(version, '~> 0.1')).to        be_truthy
+      expect(LoweredExpectations.verify_version(version, '~> 0')).to          be_truthy
+      expect(LoweredExpectations.verify_version(version, '> 0.1.1')).to       be_truthy
+      expect(LoweredExpectations.verify_version(version, '< 1')).to           be_truthy
+      expect(LoweredExpectations.verify_version(version, '> 0')).to           be_truthy
+      expect(LoweredExpectations.verify_version(version, "= #{version}")).to  be_truthy
     end
 
     it 'raise an error when the version string does not match the version pattern' do

data/tasks/clean.rake

@@ -0,0 +1,3 @@
+# Encoding: utf-8
+require 'rake/clean'
+CLEAN.add FileList['lowered-expectations-*.gem']

data/tasks/rspec.rake

@@ -0,0 +1,12 @@
+# Encoding: utf-8
+require 'rspec/core/rake_task'
+namespace :test do
+  RSpec::Core::RakeTask.new(:spec) do |t|
+    t.pattern = Dir['spec/**/*_spec.rb'].reject{ |f| f['/integration'] }
+  end
+
+  RSpec::Core::RakeTask.new(:integration) do |t|
+    t.pattern = "spec/integration/**/*_spec.rb"
+  end
+end
+

data/tasks/rubocop.rake

@@ -0,0 +1,3 @@
+# Encoding: utf-8
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new(:lint)

data/tasks/rubygems.rake

@@ -0,0 +1,3 @@
+# Encoding: utf-8
+require 'rubygems/tasks'
+Gem::Tasks.new

metadata

@@ -1,85 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: lowered-expectations
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Ian Chesal
+- Derek Tamsen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-06 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.4'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-mocks
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.24'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.24'
+date: 2016-02-02 00:00:00.000000000 Z
+dependencies: []
 description: |
   A Ruby gem that lets you test for the presence of command line tools and ensure
   that you have a version of the tool that you know how to work with.
@@ -97,6 +28,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- COPYRIGHT
 - Gemfile
 - LICENSE
 - README.md
@@ -108,6 +40,10 @@ files:
 - spec/integration/lowered/expectations_integration_spec.rb
 - spec/lowered/expectations_spec.rb
 - spec/spec_helper.rb
+- tasks/clean.rake
+- tasks/rspec.rake
+- tasks/rubocop.rake
+- tasks/rubygems.rake
 homepage: https://github.com/ianchesal/loweredexpectations
 licenses:
 - Apache 2.0
@@ -128,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: A library for testing versions of command line tools.