low_card_tables 1.0.1 → 1.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTlmZmY0NDI1ZDJhNmY4Yzg4YjNmMmE4ZmQ1OWJkZTc3YjUzMjc1NA==
+    OGE2MGZlMWQ4YzViMjI3OWNmYjU2ZTUwN2Y0YjJiMzVhMGM3MTVmMQ==
   data.tar.gz: !binary |-
-    NTM5ZjFjOGZhYmMwNDVkYmI4YTUyNjQ1NmI4ZjM4NDZmZmJhNzA5Mg==
+    MzY1YzdhODVlZmJmMzQ3MWQ3MjA0OTcyNGI1YjE5ZTU2NzhmYjRhNQ==
 SHA512:
   metadata.gz: !binary |-
-    YTBlNTdkODc3NzdhMDU1MDA1N2JjNjAzM2RmZjRjM2NiYTI3OTVlNzgzNjgx
-    OGM2ODQ4MmJlNDhkOTRiZGJiNGIzZjFmNzc5MzVjNGQyMzI3MWVmODA3NjA0
-    ZWViNzE0YjQ3YTExMjg4YWE1MzAwZTI0MWFmZWNjOGQxNjUxYmY=
+    MGM4YTRiMWMzODdjODQ5OTZiZmRjYmZhMzAzZWJlNTZhNGQwOGYyZTQyOTFm
+    MmIxOThiMTFhYzMzMGNlZDg0YmViODE0MGM3YzJiNTU0YjA2YTJmOGYwNDNk
+    NmZjMWJjNmY4NGE5Y2M5NTAzZjkyNTBiNDIxYTA3NWY2ZTM1ZmQ=
   data.tar.gz: !binary |-
-    NTUxNzgwODA1NmY0NzljOGY4ZDViY2NkMjFhOTYyZTFkOTVlNzRlMzU3NWE1
-    MGM5MWY4ZWQzMWI3NmZhNzgwNjBlYjdhZDllNTk4OGMzNGRkMDhkNDQ3MzM3
-    MTRmNTE3NTM0OTcyMzA1ZWRhNWUxNjcxYzQzODFjN2I2M2FjMmE=
+    NzAxN2RmZDJiOGZkOTNhNDM0NjRjNzI1NDBjN2I0MzhiOWIxYzczYjVmNThh
+    ZmFlZWNmNThkNGFhZGJlZWU0MTg0MTNjMjA3MTBmZWMzYWI1NTE5YWRhYzBi
+    M2ZkZWMyZjc4YjI0ZjcwM2FlYzFmNDVkYzU2MDNhYjFkMjY1MmY=

data/CHANGES.md

@@ -1,6 +1,11 @@
 # `low_card_tables` Changelog
 
-## 1.0.1, <pending>
+## 1.0.2, 2014-07-24
+
+* Fixed an issue where, if someone had defined an `ActiveRecord::Base` subclass with a `nil` `table_name`, migrations
+would fail.
+
+## 1.0.1, 2014-07-07
 
 * Fixed an issue where you couldn't migrate a low-card column into existence with a migration &mdash; because if you
 declared a low-card column that didn't exist, you'd immediately receive an error. Now this works properly.

data/lib/low_card_tables/active_record/migrations.rb

@@ -210,7 +210,8 @@ module LowCardTables
           # Make sure we load all models
           ::Rails.application.eager_load! if defined?(::Rails) && ::Rails.respond_to?(:application) && ::Rails.application && ::Rails.application.respond_to?(:eager_load!)
           out = ::ActiveRecord::Base.descendants.detect do |klass|
-            klass.table_name.strip.downcase == table_name.to_s.strip.downcase &&
+            klass.table_name &&
+              klass.table_name.strip.downcase == table_name.to_s.strip.downcase &&
               klass.is_low_card_table? &&
               klass.name && klass.name.strip.length > 0
           end

data/lib/low_card_tables/version.rb

@@ -1,4 +1,4 @@
 # Defines the current version of +low_card_tables+.
 module LowCardTables
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/low_card_tables/system/migrations_system_spec.rb

@@ -59,6 +59,18 @@ describe "LowCardTables migration support" do
     end
   end
 
+  it "should not blow up if there's an ActiveRecord subclass around that has no table name" do
+    define_model_class(:TableWithoutName, nil) { }
+
+    migrate do
+      create_table :non_low_card_table do |t|
+        t.string :name
+      end
+
+      drop_table :non_low_card_table
+    end
+  end
+
   it "should handle schema changes to the low-card table" do
     tn = @table_name
     migrate do

data/spec/low_card_tables/unit/active_record/migrations_spec.rb

@@ -80,16 +80,16 @@ describe LowCardTables::ActiveRecord::Migrations do
 
     context "with mock low-card model" do
       before :each do
-        non_low_card_class = Object.new
+        @non_low_card_class = Object.new
         @low_card_class = Object.new
 
-        expect(non_low_card_class).to receive(:table_name).and_return('bar')
-        expect(@low_card_class).to receive(:table_name).and_return('foo')
+        allow(@non_low_card_class).to receive(:table_name).and_return('bar')
+        allow(@low_card_class).to receive(:table_name).and_return('foo')
 
         expect(@low_card_class).to receive(:is_low_card_table?).and_return(true)
         expect(@low_card_class).to receive(:name).at_least(:once).and_return('Whatever')
 
-        expect(::ActiveRecord::Base).to receive(:descendants).and_return([ non_low_card_class, @low_card_class ])
+        expect(::ActiveRecord::Base).to receive(:descendants).and_return([ @non_low_card_class, @low_card_class ])
       end
 
       %w{add_column remove_column create_table change_table}.each do |method_name|
@@ -127,6 +127,22 @@ describe LowCardTables::ActiveRecord::Migrations do
             out
           end
 
+          it "should not fail if there's an ActiveRecord subclass around with no table_name" do
+            allow(@non_low_card_class).to receive(:table_name).and_return(nil)
+
+            expect(@low_card_class).to receive(:low_card_remove_unique_index!).once.ordered
+
+            expect(@low_card_class).to receive(:reset_column_information).at_least(2).times.ordered
+            expect(@low_card_class).to receive(:low_card_value_column_names).twice.ordered.and_return([ 'x', 'y' ])
+
+            expect(LowCardTables::VersionSupport).to receive(:clear_schema_cache!).once.ordered.with(@low_card_class)
+
+            expect(@low_card_class).to receive(:low_card_ensure_has_unique_index!).once.with(true).ordered
+
+            @migration.send(@method, *@args, &@proc)
+            @migration.calls.should == [ { :name => @method, :args => @args, :block => @proc } ]
+          end
+
           it "should call #eager_load, pick up an AR descendant properly, and enforce the index" do
             expect(@low_card_class).to receive(:low_card_remove_unique_index!).once.ordered
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: low_card_tables
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Andrew Geweke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-08 00:00:00.000000000 Z
+date: 2014-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler