lotus-utils 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c30faaee9896466ea8757f707a3c0a33ada14f3a
-  data.tar.gz: 8e959b68425befd384065a74e0367865ab21ede3
+  metadata.gz: 119e1e01ae231b8dd402f6cda19aa9354663e439
+  data.tar.gz: 5e28d0a9c8e1b06a66acc3ff881ac08908a5b0a3
 SHA512:
-  metadata.gz: d4f36dfb7d0b2e204433cd5e535e8de699e42a9706f054da3bb86aa0d3e5b23f7af8c3f5814591c3ec18554deed697f8b7a20739b9ee113a6393a9bf40fa619e
-  data.tar.gz: a4eb1264f70bbe20081fa2e2398e45c4a24ebfeac85ef9dfc0ce743ce764f34edabccd6ce046247f4bc5a33d720cb3e0bd15d4723f84772f9cb0df09245fa3e8
+  metadata.gz: ea4c280a6b7c8b693d69bf132b85de349e0c459a4ac259f33d58313244ca97300aae686743f4f15fd00314c41d07b792151f78a02a2e2c75b9d157d4d3f744a3
+  data.tar.gz: 95432308fb5689d4a61292cd24553df16a37e039ac79760debe4813d961dadff081e8ccb993946891e86c57fe77d2e7b85822cd3d2096111031390c1a5d7af6a

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Lotus::Utils
 Ruby core extentions and class utilities for Lotus
 
+## v0.4.3 - 2015-05-22
+### Added
+- [François Beausoleil] Improved `Lotus::Utils::Kernel` messages for `TypeError`.
+
 ## v0.4.2 - 2015-05-15
 ### Fixed
 - [Luca Guidi] Ensure `Lotus::Utils::Attributes#to_h` to return `::Hash`

data/lib/lotus/utils/kernel.rb

@@ -140,7 +140,7 @@ module Lotus
           Set.new(::Kernel.Array(arg))
         end
       rescue NoMethodError
-        raise TypeError.new("can't convert into Set")
+        raise TypeError.new("can't convert #{inspect_type_error(arg)}into Set")
       end
 
       # Coerces the argument to be a Hash.
@@ -205,7 +205,7 @@ module Lotus
             super(arg)
           end
         rescue NoMethodError
-          raise TypeError.new "can't convert into Hash"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into Hash"
         end
       else
         def self.Hash(arg)
@@ -217,7 +217,7 @@ module Lotus
             super(arg)
           end
         rescue ArgumentError, NoMethodError
-          raise TypeError.new "can't convert into Hash"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into Hash"
         end
       end
 
@@ -336,13 +336,13 @@ module Lotus
           when NilClass, ->(a) { a.respond_to?(:to_i) && a.to_s.match(NUMERIC_MATCHER) }
             arg.to_i
           else
-            raise TypeError.new "can't convert into Integer"
+            raise TypeError.new "can't convert #{inspect_type_error(arg)}into Integer"
           end
         rescue NoMethodError
-          raise TypeError.new "can't convert into Integer"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into Integer"
         end
       rescue RangeError
-        raise TypeError.new "can't convert into Integer"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Integer"
       end
 
       # Coerces the argument to be a BigDecimal.
@@ -426,10 +426,10 @@ module Lotus
         when ->(a) { a.to_s.match(NUMERIC_MATCHER) }
           BigDecimal.new(arg)
         else
-          raise TypeError.new "can't convert into BigDecimal"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into BigDecimal"
         end
       rescue NoMethodError
-        raise TypeError.new "can't convert into BigDecimal"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into BigDecimal"
       end
 
       # Coerces the argument to be a Float.
@@ -552,13 +552,13 @@ module Lotus
           when NilClass, ->(a) { a.respond_to?(:to_f) && a.to_s.match(NUMERIC_MATCHER) }
             arg.to_f
           else
-            raise TypeError.new "can't convert into Float"
+            raise TypeError.new "can't convert #{inspect_type_error(arg)}into Float"
           end
         rescue NoMethodError
-          raise TypeError.new "can't convert into Float"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into Float"
         end
       rescue RangeError
-        raise TypeError.new "can't convert into Float"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Float"
       end
 
       # Coerces the argument to be a String.
@@ -659,14 +659,14 @@ module Lotus
             super(arg)
           end
         rescue NoMethodError
-          raise TypeError.new "can't convert into String"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into String"
         end
       else
         def self.String(arg)
           arg = arg.to_str if arg.respond_to?(:to_str)
           super(arg)
         rescue NoMethodError
-          raise TypeError.new "can't convert into String"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into String"
         end
       end
 
@@ -731,7 +731,7 @@ module Lotus
           Date.parse(arg.to_s)
         end
       rescue ArgumentError, NoMethodError
-        raise TypeError.new "can't convert into Date"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Date"
       end
 
       # Coerces the argument to be a DateTime.
@@ -799,7 +799,7 @@ module Lotus
           DateTime.parse(arg.to_s)
         end
       rescue ArgumentError, NoMethodError
-        raise TypeError.new "can't convert into DateTime"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into DateTime"
       end
 
       # Coerces the argument to be a Time.
@@ -864,7 +864,7 @@ module Lotus
           Time.parse(arg.to_s)
         end
       rescue ArgumentError, NoMethodError
-        raise TypeError.new "can't convert into Time"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Time"
       end
 
       # Coerces the argument to be a Boolean.
@@ -917,7 +917,7 @@ module Lotus
           !!arg
         end
       rescue NoMethodError
-        raise TypeError.new "can't convert into Boolean"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Boolean"
       end
 
       # Coerces the argument to be a Pathname.
@@ -975,7 +975,7 @@ module Lotus
           super
         end
       rescue NoMethodError
-        raise TypeError.new "can't convert into Pathname"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Pathname"
       end
 
       # Coerces the argument to be a String.
@@ -1021,13 +1021,38 @@ module Lotus
       #   Lotus::Utils::Kernel.Symbol(input) # => TypeError
       def self.Symbol(arg)
         case arg
-        when '' then raise TypeError.new "can't convert into Symbol"
+        when '' then raise TypeError.new "can't convert #{inspect_type_error(arg)}into Symbol"
         when ->(a) { a.respond_to?(:to_sym) } then arg.to_sym
         else
-          raise TypeError.new "can't convert into Symbol"
+          raise TypeError.new "can't convert #{inspect_type_error(arg)}into Symbol"
         end
       rescue NoMethodError
-        raise TypeError.new "can't convert into Symbol"
+        raise TypeError.new "can't convert #{inspect_type_error(arg)}into Symbol"
+      end
+
+      # Returns the most useful type error possible
+      #
+      # If the object does not respond_to?(:inspect), we return the class, else we
+      # return nil. In all cases, this method is tightly bound to callers, as this
+      # method appends the required space to make the error message look good.
+      #
+      # @since 0.4.3
+      # @api private
+      def self.inspect_type_error(arg)
+        (arg.respond_to?(:inspect) ? arg.inspect : arg.to_s) << " "
+      rescue NoMethodError => _
+        # missing the #respond_to? method, fall back to returning the class' name
+        begin
+          arg.class.name << " instance "
+        rescue NoMethodError
+          # missing the #class method, can't fall back to anything better than nothing
+          # Callers will have to guess from their code
+          nil
+        end
+      end
+
+      class << self
+        private :inspect_type_error
       end
     end
   end

data/lib/lotus/utils/version.rb

@@ -3,6 +3,6 @@ module Lotus
     # Defines the version
     #
     # @since 0.1.0
-    VERSION = '0.4.2'.freeze
+    VERSION = '0.4.3'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lotus-utils
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Luca Guidi
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-15 00:00:00.000000000 Z
+date: 2015-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler