lotus-utils 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9735bda19b42820e137d3701b680744b1e31efa
-  data.tar.gz: 2f8d6bd945be961bf835f994dcf0f3337805d4d6
+  metadata.gz: 629a22895276c357e5ee478c10eb6fd0c2c4ef4a
+  data.tar.gz: 185f59a1c22e690428f1675aa0ebb2a1553ad4ad
 SHA512:
-  metadata.gz: bd341a626427d29d9e8785fca9eb600a171ddf1e4acc64ed72f8301276a8d2166f8ac4fc4ce41ecfa285af419e3556e88c735cdb7a29e8e53c801d601089df35
-  data.tar.gz: 4b895ccb945daeea8eb89f03ae3f77cf8e3a58d6f0b59c717fd9a8737c4239e95f2f823f7c136f01938d5d6da80a037604cfc9a60e1e53b2ee7e20badbc2485c
+  metadata.gz: a3e7907833d632771a62ccd573d72238ca7f454f28c84f440eb85b6cf6b49bb635214bc22d05431861ff163246ef82fea184c30b52132c54c8323e7d4eac157c
+  data.tar.gz: 589fd11dc42724192687b86d4848b378d90c7a14516fb69117667a7b021df56facd67f91ebbba7fb53fe492a2e010ee22bf6622910fa0a6bed61f83fb19befb7

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Lotus::Utils
 Ruby core extentions and class utilities for Lotus
 
+## v0.3.3 - 2015-01-08
+### Fixed
+- [Luca Guidi] Ensure to return the right offending object if a missing method is called with Utils::String and Hash (eg. `Utils::Hash.new(a: 1).all? {|_, v| v.foo }` blame `v` instead of `Hash`)
+- [Luca Guidi] Raise an error if try to coerce non numeric strings into Integer, Float & BigDecimal (eg. `Utils::Kernel.Integer("hello") # => raise TypeError`)
+
 ## v0.3.2 - 2014-12-23
 ### Added
 - [Luca Guidi] Official support for Ruby 2.2

data/lib/lotus/utils/hash.rb

@@ -259,12 +259,16 @@ module Lotus
       #
       # @api private
       # @since 0.3.0
+      #
+      # @raise [NoMethodError] If doesn't respond to the given method
       def method_missing(m, *args, &blk)
-        h = @hash.__send__(m, *args, &blk)
-        h = self.class.new(h) if h.is_a?(::Hash)
-        h
-      rescue NoMethodError
-        raise NoMethodError.new(%(undefined method `#{ m }' for #{ @hash }:#{ self.class }))
+        if respond_to?(m)
+          h = @hash.__send__(m, *args, &blk)
+          h = self.class.new(h) if h.is_a?(::Hash)
+          h
+        else
+          raise NoMethodError.new(%(undefined method `#{ m }' for #{ @hash }:#{ self.class }))
+        end
       end
 
       # Override Ruby's respond_to_missing? in order to support ::Hash interface

data/lib/lotus/utils/kernel.rb

@@ -17,6 +17,14 @@ module Lotus
     # Kernel utilities
     # @since 0.1.1
     module Kernel
+      # Matcher for numeric values
+      #
+      # @since 0.3.3
+      # @api private
+      #
+      # @see Lotus::Utils::Kernel.Integer
+      NUMERIC_MATCHER = /\A([\d\/\.\+iE]+|NaN|Infinity)\z/.freeze
+
       # Coerces the argument to be an Array.
       #
       # It's similar to Ruby's Kernel.Array, but it applies further
@@ -285,6 +293,10 @@ module Lotus
       #   input = OpenStruct.new(color: 'purple')
       #   Lotus::Utils::Kernel.Integer(input) # => TypeError
       #
+      #   # String that doesn't represent an integer
+      #   input = 'hello'
+      #   Lotus::Utils::Kernel.Integer(input) # => TypeError
+      #
       #   # When true
       #   input = true
       #   Lotus::Utils::Kernel.Integer(input) # => TypeError
@@ -320,7 +332,8 @@ module Lotus
         super(arg)
       rescue ArgumentError, TypeError, NoMethodError
         begin
-          if arg.respond_to?(:to_i)
+          case arg
+          when NilClass, ->(a) { a.respond_to?(:to_i) && a.to_s.match(NUMERIC_MATCHER) }
             arg.to_i
           else
             raise TypeError.new "can't convert into Integer"
@@ -398,6 +411,10 @@ module Lotus
       #   input = Time.now
       #   Lotus::Utils::Kernel.BigDecimal(input) # => TypeError
       #
+      #   # String that doesn't represent a big decimal
+      #   input = 'hello'
+      #   Lotus::Utils::Kernel.BigDecimal(input) # => TypeError
+      #
       #   # Missing #respond_to?
       #   input = BasicObject.new
       #   Lotus::Utils::Kernel.BigDecimal(input) # => TypeError
@@ -406,8 +423,10 @@ module Lotus
         when ->(a) { a.respond_to?(:to_d) } then arg.to_d
         when Float, Complex, Rational
           BigDecimal(arg.to_s)
-        else
+        when ->(a) { a.to_s.match(NUMERIC_MATCHER) }
           BigDecimal.new(arg)
+        else
+          raise TypeError.new "can't convert into BigDecimal"
         end
       rescue NoMethodError
         raise TypeError.new "can't convert into BigDecimal"
@@ -514,6 +533,10 @@ module Lotus
       #   input = BasicObject.new
       #   Lotus::Utils::Kernel.Float(input) # => TypeError
       #
+      #   # String that doesn't represent a float
+      #   input = 'hello'
+      #   Lotus::Utils::Kernel.Float(input) # => TypeError
+      #
       #   # big rational
       #   input = Rational(-8) ** Rational(1, 3)
       #   Lotus::Utils::Kernel.Float(input) # => TypeError
@@ -525,7 +548,8 @@ module Lotus
         super(arg)
       rescue ArgumentError, TypeError
         begin
-          if arg.respond_to?(:to_f)
+          case arg
+          when NilClass, ->(a) { a.respond_to?(:to_f) && a.to_s.match(NUMERIC_MATCHER) }
             arg.to_f
           else
             raise TypeError.new "can't convert into Float"

data/lib/lotus/utils/string.rb

@@ -207,20 +207,28 @@ module Lotus
       # @see http://www.ruby-doc.org/core/String.html#method-i-gsub
       #
       # @since 0.3.0
-      def gsub(pattern, replacement, &blk)
-        @string.gsub(pattern, replacement, &blk)
+      def gsub(pattern, replacement = nil, &blk)
+        if block_given?
+          @string.gsub(pattern, &blk)
+        else
+          @string.gsub(pattern, replacement)
+        end
       end
 
       # Override Ruby's method_missing in order to provide ::String interface
       #
       # @api private
       # @since 0.3.0
+      #
+      # @raise [NoMethodError] If doesn't respond to the given method
       def method_missing(m, *args, &blk)
-        s = @string.__send__(m, *args, &blk)
-        s = self.class.new(s) if s.is_a?(::String)
-        s
-      rescue NoMethodError
-        raise NoMethodError.new(%(undefined method `#{ m }' for "#{ @string }":#{ self.class }))
+        if respond_to?(m)
+          s = @string.__send__(m, *args, &blk)
+          s = self.class.new(s) if s.is_a?(::String)
+          s
+        else
+          raise NoMethodError.new(%(undefined method `#{ m }' for "#{ @string }":#{ self.class }))
+        end
       end
 
       # Override Ruby's respond_to_missing? in order to support ::String interface

data/lib/lotus/utils/version.rb

@@ -1,5 +1,8 @@
 module Lotus
   module Utils
-    VERSION = '0.3.2'.freeze
+    # Defines the version
+    #
+    # @since 0.1.0
+    VERSION = '0.3.3'.freeze
   end
 end

data/lotus-utils.gemspec

@@ -6,8 +6,8 @@ require 'lotus/utils/version'
 Gem::Specification.new do |spec|
   spec.name          = 'lotus-utils'
   spec.version       = Lotus::Utils::VERSION
-  spec.authors       = ['Luca Guidi']
-  spec.email         = ['me@lucaguidi.com']
+  spec.authors       = ['Luca Guidi', 'Trung Lê']
+  spec.email         = ['me@lucaguidi.com', 'trung.le@ruby-journal.com']
   spec.description   = %q{Lotus utilities}
   spec.summary       = %q{Ruby core extentions and Louts utilities}
   spec.homepage      = 'http://lotusrb.org'

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: lotus-utils
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Luca Guidi
+- Trung Lê
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-23 00:00:00.000000000 Z
+date: 2015-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -55,6 +56,7 @@ dependencies:
 description: Lotus utilities
 email:
 - me@lucaguidi.com
+- trung.le@ruby-journal.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -96,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Ruby core extentions and Louts utilities