looksist 0.2.7 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0994ca184629691fa505977431489e2e9666d513
-  data.tar.gz: a0f43956fe8b0569520f56a3da0e8b6ece73e636
+  metadata.gz: af0970edfde1eaaedf7ff9dfeb7618e1c815beb9
+  data.tar.gz: 6a05e43560a57b6cbc150bb59b149f02316fd923
 SHA512:
-  metadata.gz: 5c2877f5c569d667a54a36be62a97e62fd5c9ccd765e7ac3f340dd5011d71dfe68b951793799428e7677a6c1d738e028c2bed581e976d1054cca6898ae0cf1b2
-  data.tar.gz: 38c95f0ca67deba2942b8b5ae3e0bdf9b90727a60cb189b78dd89fa265a93bc689234f68285a0fc276363c4ab94b63ebbffe426b64f9ef8d3caa5b76644703af
+  metadata.gz: 5ce3783053136540929bc910c84b51c6e0fa00f0aa448e2fc1b88449863096f3cba725e43e58b9ee804600dd59c2ab11b653d8757431ffe84b396c799ab35573
+  data.tar.gz: feb2a4bb3cb516f7b34d95c4d474011fb5636cceae2fa32013948b0e72a3c764200cf1bd69a52fc3752c9be86448835086cd344dfd0a0d85fb5e36e39a52dc34

data/.travis.yml

@@ -1,6 +1,9 @@
 language: ruby
 rvm:
+  - ruby-2.1.1
   - ruby-2.1.2
+  - ruby-2.1.3
+  - ruby-1.9.3
   - jruby-1.7.16
 services:
   - redis-server

data/README.md

@@ -15,14 +15,17 @@ Add this line to your application's Gemfile:
 
     gem 'looksist'
 
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install looksist
-
+## Supported Ruby Versions
+    
+    ruby 2.1
+    ruby 1.9.3
+    jruby 1.7
+    
+## Dependencies
+    
+    JsonPath - required by the gem. 
+    ActiveSupport - external dependency, make sure to require it in your project.
+    
 ## Usage
 
 ### With Object Models (Her, Active Resource or any of your choice)

data/lib/looksist/core.rb

@@ -59,7 +59,7 @@ module Looksist
           lookup_attributes ||= {}
           other_attributes = lookup_attributes.keys.each_with_object({}) do |a, acc|
             using = lookup_attributes[a]
-            acc[a] = obj.send(a) if obj.respond_to?(using)
+            acc[a] = obj.send(a) if obj.attributes.has_key?(using.to_s)
           end
           obj.attributes.merge(other_attributes)
         end

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.2.7'
+  VERSION = '0.2.8'
 end

data/spec/looksist/looksist_spec.rb

@@ -41,23 +41,17 @@ describe Looksist do
             include Her::Model
             use_api TEST_API
             include Looksist
-            attr_accessor :id
             lookup [:name, :age], using: :id, as: {name: 'nome'}
-
-            def initialize(id)
-              @id = id
-            end
-
             def as_json(opts)
-              super(opts).merge(id: @id)
+              super(opts).merge(attributes)
             end
           end
         end
         expect(@mock).to receive(:get).exactly(4).times.with('ids/1').and_return({name: 'Rajini', age: 16}.to_json)
-        e = AliasSpecificLookup::NoCacheEmployee.new(1)
+        e = AliasSpecificLookup::NoCacheEmployee.new(id:1)
         expect(e.nome).to eq('Rajini')
         expect(e.age).to eq(16)
-        expect(e.to_json).to eq("{\"nome\":\"Rajini\",\"age\":16,\"id\":1}")
+        expect(e.to_json).to eq("{\"id\":1,\"nome\":\"Rajini\",\"age\":16}")
       end
     end
 
@@ -69,17 +63,10 @@ describe Looksist do
             include Her::Model
             use_api TEST_API
             include Looksist
-            attr_accessor :id
-            attr_accessor :department_id
             lookup :name, using: :id, bucket_name: 'employees'
 
-            def initialize(id, department_id)
-              @id = id
-              @department_id = department_id
-            end
-
             def as_json(opts)
-              super(opts).merge(id: @id)
+              super(opts).merge(attributes)
             end
           end
 
@@ -99,9 +86,9 @@ describe Looksist do
         expect(@mock).to receive(:get).once.with('employees/1').and_return('SuperStar')
         expect(@mock).to receive(:get).once.with('departments/2').and_return('Kollywood')
 
-        e = InheritedLookUp::Manager.new(1, 2)
+        e = InheritedLookUp::Manager.new(id:1, department_id:2)
 
-        expect(e.to_json).to eq("{\"department_name\":\"Kollywood\",\"name\":\"SuperStar\",\"id\":1,\"is_manager\":true}")
+        expect(e.to_json).to eq("{\"department_id\":2,\"id\":1,\"department_name\":\"Kollywood\",\"name\":\"SuperStar\",\"is_manager\":true}")
       end
     end
 
@@ -164,17 +151,20 @@ describe Looksist do
             include Her::Model
             use_api TEST_API
             include Looksist
-
-            lookup :name, using: :employee_id
+            lookup :name, using: :id, bucket_name: 'employees'
 
             def as_json(opts)
               super(opts)
             end
+
           end
         end
-        expect(@mock).to receive(:get).never.with('employees/1')
-        e = TolerantLookUp::Employee.new
-        expect(e.to_json).to eq('{}')
+        expect(@mock).to receive(:get).once.with('employees/1').and_return('RajiniKanth')
+        expect(@mock).to receive(:get).never.with('employees/')
+        e1 = TolerantLookUp::Employee.new(id:1)
+        e2 = TolerantLookUp::Employee.new
+        expect(e1.to_json).to eq("{\"id\":1,\"name\":\"RajiniKanth\"}")
+        expect(e2.to_json).to eq('{}')
       end
     end
 
@@ -185,22 +175,17 @@ describe Looksist do
             include Her::Model
             use_api TEST_API
             include Looksist
-            attr_accessor :id
             lookup :name, using: :id, bucket_name: 'employees', as: {name: 'nome'}
 
-            def initialize(id)
-              @id = id
-            end
-
             def as_json(opts)
-              super(opts).merge(id: @id)
+              super(opts).merge(attributes)
             end
           end
         end
         expect(@mock).to receive(:get).once.with('employees/1').and_return('Rajini')
-        e = AliasLookup::Employee.new(1)
+        e = AliasLookup::Employee.new(id: 1)
         expect(e.nome).to eq('Rajini')
-        expect(e.to_json).to eq("{\"nome\":\"Rajini\",\"id\":1}")
+        expect(e.to_json).to eq("{\"id\":1,\"nome\":\"Rajini\"}")
       end
 
       it 'should fetch attributes and use the alias for specific attributes in the api' do
@@ -209,23 +194,18 @@ describe Looksist do
             include Her::Model
             use_api TEST_API
             include Looksist
-            attr_accessor :id
             lookup [:name, :age], using: :id, as: {name: 'nome'}
 
-            def initialize(id)
-              @id = id
-            end
-
             def as_json(opts)
-              super(opts).merge(id: @id)
+              super(opts).merge(attributes)
             end
           end
         end
         expect(@mock).to receive(:get).once.with('ids/1').and_return({name: 'Rajini', age: 16}.to_json)
-        e = AliasSpecificLookup::Employee.new(1)
+        e = AliasSpecificLookup::Employee.new(id: 1)
         expect(e.nome).to eq('Rajini')
         expect(e.age).to eq(16)
-        expect(e.to_json).to eq("{\"nome\":\"Rajini\",\"age\":16,\"id\":1}")
+        expect(e.to_json).to eq("{\"id\":1,\"nome\":\"Rajini\",\"age\":16}")
       end
     end
 
@@ -290,7 +270,6 @@ describe Looksist do
             lookup [:name, :location], using: :id
             lookup [:age, :sex], using: :employee_id
             lookup [:pager, :cell], using: :contact_id
-
             def initialize(id)
               @contact_id = @id = @employee_id = id
             end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors:
 - RC