looksist 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f92b64ae7a78e9d0f85c8e70e83196e3b4f4cd5
-  data.tar.gz: 96bf142e12546274d40d9c549655a6071adb7934
+  metadata.gz: 41b6c0fcd98079a67f6419de4bdf1bad8a372e67
+  data.tar.gz: 2bcfde54ae2c0b0fbe097202b7d23609c3401c3f
 SHA512:
-  metadata.gz: 9e4eff61111cc8a2eec151a698a2394b07bf2bac84a633432d29f1acb18f9da1e8fe6b0383cc35510b07ed4c87ab0a7149d70a651ee417c4f4f0c640104cc8ab
-  data.tar.gz: 7507c9604eea9f68e424a8d207aac06e3eeddd543ed733e2556314700ee2ed51820eb0c9e78495a3065a2e00e9784b3d9db53f4b376b709ed4213ff7be49b8b5
+  metadata.gz: 3e35bc8d5a4fdf61d2b4136812101f61bfb2b1c191b56300f38954a07d4eda7675b8872b42ab3e75317b2e6429918d7b3510fe6986c5017f05b5e67db821246f
+  data.tar.gz: dfb89beceb5981d66fcfa128e6e2d17e4f09e781abd98375b55ef9d8048b8a422cde3f6c35a945353a4868dfe077fc3c2ea40d29d7051db2cc6f392b25d7fac7

data/README.md

@@ -1,6 +1,8 @@
 # Looksist
 
 [![Build Status](https://travis-ci.org/jpsimonroy/looksist.png?branch=master)](https://travis-ci.org/jpsimonroy/looksist)
+[![Coverage Status](https://img.shields.io/coveralls/jpsimonroy/looksist.svg)](https://coveralls.io/r/jpsimonroy/looksist?branch=master)
+[![Code Climate](https://codeclimate.com/github/jpsimonroy/looksist/badges/gpa.svg)](https://codeclimate.com/github/jpsimonroy/looksist)
 [![Gem Version](https://badge.fury.io/rb/looksist.svg)](http://badge.fury.io/rb/looksist)
 
 looksist (adj) - forming positive prejudices based on appearances

data/features/support/env.rb

@@ -2,14 +2,28 @@ require 'active_support/all'
 require 'faraday_middleware'
 require 'her'
 require 'ostruct'
-require 'looksist'
-require 'looksist/redis_service'
-require 'looksist/hashed'
-require 'looksist/safe_lru_cache'
 require 'pry'
 require 'redis'
 require 'hiredis'
 require 'jsonpath'
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter
+]
+
+SimpleCov.start do
+  add_filter '/spec/'
+  add_filter '/features/'
+end
+
+require 'looksist'
+require 'looksist/redis_service'
+require 'looksist/hashed'
+require 'looksist/safe_lru_cache'
+
 
 I18n.enforce_available_locales = false
 

data/lib/looksist/core.rb

@@ -5,21 +5,23 @@ module Looksist
 
     module ClassMethods
       def lookup(what, using, bucket = using)
-        self.lookup_attributes ||= []
-        self.id_and_buckets ||= []
-        self.id_and_buckets << {id: using, bucket: bucket}
         if what.is_a? Array
-          what.each do |method_name|
-            define_method(method_name) do
-              JSON.parse(Looksist.redis_service.send("#{__entity__(bucket)}_for", self.send(using).try(:to_s)) || '{}')[method_name.to_s]
-            end
-            self.lookup_attributes << method_name
-          end
+          setup_composite_lookup(bucket, using, what)
         else
+          self.lookup_attributes << what.to_sym
           define_method(what) do
             Looksist.redis_service.send("#{__entity__(bucket)}_for", self.send(using).try(:to_s))
           end
-          self.lookup_attributes << what.to_sym
+        end
+      end
+
+      private
+      def setup_composite_lookup(bucket, using, what)
+        what.each do |method_name|
+          define_method(method_name) do
+            JSON.parse(Looksist.redis_service.send("#{__entity__(bucket)}_for", self.send(using).try(:to_s)) || '{}')[method_name.to_s]
+          end
+          self.lookup_attributes << method_name
         end
       end
     end
@@ -29,7 +31,8 @@ module Looksist
     end
 
     included do |base|
-      base.class_attribute :lookup_attributes, :id_and_buckets
+      base.class_attribute :lookup_attributes
+      base.lookup_attributes = []
     end
 
   end
@@ -37,8 +40,7 @@ module Looksist
   module Serializers
     class Her
       class << self
-        def json_opts(obj, opts)
-          obj.class.lookup_attributes ||= []
+        def json_opts(obj, _)
           obj.attributes.merge(obj.class.lookup_attributes.each_with_object({}) { |a, acc| acc[a] = obj.send(a) })
         end
       end

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.1.9'
+  VERSION = '0.2.0'
 end

data/looksist.gemspec

@@ -30,6 +30,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'cucumber'
   spec.add_development_dependency 'redis'
   spec.add_development_dependency 'hiredis'
+  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'coveralls'
 
   spec.add_runtime_dependency 'jsonpath', '~> 0.5.6'
 

data/spec/spec_helper.rb

@@ -2,11 +2,24 @@ require 'active_support/all'
 require 'faraday_middleware'
 require 'her'
 require 'ostruct'
+require 'pry'
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter
+]
+
+SimpleCov.start do
+  add_filter '/spec/'
+  add_filter '/features/'
+end
+
 require 'looksist'
 require 'looksist/redis_service'
 require 'looksist/hashed'
 require 'looksist/safe_lru_cache'
-require 'pry'
 
 module Her
   module Model

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - RC
@@ -179,6 +179,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jsonpath
   requirement: !ruby/object:Gem::Requirement