lookout-rack-utils 1.6.0 → 1.7.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzIxNjcxNGNjYjY5YWRjNTZjMTZiYWM5YTZlZGQ5MTI4NDQ5OGJiNw==
+    NzZmNWQ3MmJjNmM2Zjk4OThkODJkZmE3ZmExNzA2NmIwYTQ0NWVjMw==
   data.tar.gz: !binary |-
-    ZWJjMzVjYWFmZTk3YzYxOTcwMTc4MzZhMzRjNGU3MTI5MGI0YjEyNg==
+    N2M1ZGMzZGJjNDc4ZTA3MDE4OGZlOGFlZGJhYzU3MzAzMmMwZmQ1ZA==
 SHA512:
   metadata.gz: !binary |-
-    MjIzYjIyNjdkMTkzZWZmYWM0MDlmMjNiMGUyNjkyOTFlYjQxMWI2ZjA3ZjMz
-    ZTUwODFkNmIxMzNhMjRhN2VmZmVmNWM5NjA1ZGMyZDQwODBmNGY4YmU1MjRh
-    MDk3ZWJjYTAwNmE3Y2JmZTI5YWU0MmM0MWIzNDYzNzAzZGE2ZWU=
+    NWU4YmQ3NzEzNTkwZTdmYWI0ZTFiMDA5NjJkNjM0ZWFjZDRiYWUxMDBlZTM3
+    MzRjNzM4NDdiNDFiZGU1ZjUwMTU4NzEyNzFlYzQ2MTJmOWY0OWUzZWE4M2Jk
+    MjE3OTQ2ZmU2YzkyYTczMjlkYTBhNDg4M2IxMzY4Y2ZkMTA4NDY=
   data.tar.gz: !binary |-
-    YjAzMGU4YjdkNmE2M2U2YmZlZTk4ZDEyMTAzM2I3Y2Q0ZmRjZTJmYTE1NmNm
-    MjQ5YjcxYTkzMjRkNzEyZjllODJkZmU2MTJhODY4ODNkYjk5YTE4YjE5Zjll
-    MWM3OTM0NWUzZTMwODc1NDVmMDI5MjY2OTFkYzMxMzk0ODlmOWU=
+    NTAxZGYxNjc0N2U5MTczNGJiOThkYTNmMDg0NWE4NGJkZGIxODgxOTAyYjVk
+    ZDVkOWU3M2RhZGIyNWQwODNhMjE3MGEzNmJkODg3N2E1Y2NiMTI5OTU4ZmYw
+    ZmYzZGYzZTc2ZTQwZDU4YmJlMDBiYmVmNjk1ODhlZDIzZGRiZDY=

data/README.md

@@ -94,6 +94,29 @@ path; the result can then be used, or just returned immediately to the browser.
   post '/api/public/v1/user' do
     subroute!("/api/public/v1/user/#{current_user.id}")
   end
+
+  # A route that requires an id param
+  get '/api/public/v1/problem' do
+    halt 404 unless params[:id]
+    ...
+  end
+
+  # Assuming the problem route above that takes an id parameter,
+  # pass information from one route to another in the correct form.
+  get '/api/public/v1/device/problem/:problem_id' do |problem_id|
+    subroute!('/api/public/v1/problem', :id => problem_id)
+  end
+
+  delete '/api/public/v1/user/:user_id' do |user_id|
+     ...
+  end
+
+  # Assuming the delete route above, change the http verb of the request to
+  # another (a contrived example)
+  get '/api/public/v1/user/:user_id' do |user_id|
+    subroute!("/api/public/v1/user/#{user_id}", :request_method => 'DELETE')
+  end
+
   ```
 
 ## Contributing

data/lib/lookout/rack/utils/subroute.rb

@@ -15,7 +15,7 @@ module Lookout::Rack::Utils
 
       # modify rack environment using Rack::Request- store passed in key/value
       # pairs into hash associated with the parameters of the current http verb
-      options.each { |k,v| subserver.request.send(http_verb)[k] = v }
+      options.each { |k,v| subserver.request.update_param(k, v) }
       # Invoking Sinatra::Base#call! on our duplicated app instance. Sinatra's
       # call will dup the app instance and then call!, so skip Sinatra's dup
       # since we've done that here.

data/lib/lookout/rack/utils/version.rb

@@ -1,7 +1,7 @@
 module Lookout
   module Rack
     module Utils
-      VERSION = "1.6.0"
+      VERSION = "1.7.1"
     end
   end
 end

data/lookout-rack-utils.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "i18n"
 
-  spec.add_dependency "rack"
+  spec.add_dependency "rack", '>= 1.5.0'
   spec.add_dependency "rack-graphite"
   spec.add_dependency "rack-requestash"
   spec.add_dependency "configatron", '~> 2.13'

data/spec/subroute_spec.rb

@@ -18,6 +18,10 @@ describe Lookout::Rack::Utils::Subroute, :type => :route do
           subroute!('/test_route', :id => id)
         end
 
+        put '/subrouted/request_params' do
+          subroute!('/test_route', 'key' => 'value')
+        end
+
         delete '/test_delete' do
           status 201
           { :deleted => true }.to_json
@@ -44,10 +48,21 @@ describe Lookout::Rack::Utils::Subroute, :type => :route do
       let(:id) { 1 }
       let(:body) { { :key => 'value', :id => "#{id}" }.to_json }
 
-      subject(:subrouted) { get "/subrouted/#{id}?key=value" }
 
-      it 'should return expected value' do
-        expect([subrouted.status, subrouted.body]).to eql [200, body]
+      context 'a get route' do
+        subject(:subrouted) { get "/subrouted/#{id}?key=value" }
+
+        it 'should return expected value' do
+          expect([subrouted.status, subrouted.body]).to eql [200, body]
+        end
+      end
+
+      context 'params added by subrouter, non-GET method' do
+        subject(:subrouted) { put '/subrouted/request_params' }
+
+        it 'should return expected value' do
+          expect([subrouted.status, subrouted.body]).to eql [200, { 'key' => 'value' }.to_json]
+        end
       end
     end
 

data/spec/support/routehelpers.rb

@@ -6,6 +6,11 @@ module RouteHelpers
       status 200
       params.to_json
     end
+
+    put '/test_route' do
+      status 200
+      params.to_json
+    end
   end
 
   def app

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lookout-rack-utils
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Ian Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-22 00:00:00.000000000 Z
+date: 2014-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0
 - !ruby/object:Gem::Dependency
   name: rack-graphite
   requirement: !ruby/object:Gem::Requirement