lookout-ahoy 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4adca74fe854b333e1cee9586ad01b0b2a94d8b85b8fd04b9ae17e3113b18f4
-  data.tar.gz: 73c8ebb11604d6e40feb2c7f0a3cdda1af38fb1efa0bc347d317058abe7dccea
+  metadata.gz: cc40e394fab7179d1aedeffac0094bc4ff1c6b9ad6adf8c38894b59f470a3094
+  data.tar.gz: ec7e747428b3def4e970d51a72791ee72ad8d7c1a042463aa4a4b02fc804925a
 SHA512:
-  metadata.gz: f3f84d89ddba73a7625f7d21b55ba70afe2f2907a0fa041e675d817d45bc413f9ee22421b139a37b3dc383aedbff17a82562156adf5443a7a46cdb087eede247
-  data.tar.gz: 8e9cfce9194d9067a78883565c2e2c2d6b968ae571d52f3183a46d119cc4ceecd35b6a4e2eb0de11c05f261e788d0d5e9719bd886f8d15a435e034d334608a0e
+  metadata.gz: a75cb93ccc72e4d2f62aec75e9b66a048f00833d79c822ff1486662ddff70ca32bfba4705b5cd0aa45b5ae9db517c52d9b7fe7293b02ef0f09081d2078dad6d6
+  data.tar.gz: ecbcef96bd32e3cf804c43acf1ec6a2f6e08743c5875412ae03a5560b77c858f385e237a7f77a19f601975cd3f9c2f56c22c262a62d257e20e91c712417522c4

data/app/assets/javascript/lookout/controllers/funnel_chart_controller.js

@@ -1,5 +1,6 @@
 import { Controller } from '@hotwired/stimulus';
-import 'chartjs-plugin-datalabels';
+// NOTE: chartjs-plugin-datalabels is imported globally in application.js
+// Do NOT import it here - it causes race conditions with Chart.js initialization
 import { getCSS, externalTooltipHandler } from "helpers/chart_utils";
 
 const calculatePercentageDifference = function(oldValue, newValue) {
@@ -18,6 +19,17 @@ export default class extends Controller {
     this.funnel = JSON.parse(this.element.dataset.data);
     console.log('Funnel data:', this.funnel);
 
+    // Check if Chart.js is available
+    if (typeof window.Chart === 'undefined') {
+      console.error('Chart.js is not loaded yet');
+      return;
+    }
+
+    // Register ChartDataLabels plugin globally if available
+    if (window.ChartDataLabels && !window.Chart.registry.plugins.get('datalabels')) {
+      window.Chart.register(window.ChartDataLabels);
+    }
+
     const fontFamily = 'ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"';
     const labels = this.funnel.steps.map((step) => step.name);
     const stepData = this.funnel.steps.map((step) => step.total_events);
@@ -48,7 +60,6 @@ export default class extends Controller {
     const config = {
       responsive: true,
       maintainAspectRatio: false,
-      plugins: [ChartDataLabels],
       type: 'bar',
       data,
       options: {
@@ -119,7 +130,7 @@ export default class extends Controller {
 
     const visitorsData = [];
 
-    this.chart = new Chart(
+    this.chart = new window.Chart(
       this.element,
       config,
     );

data/app/assets/javascript/lookout/controllers/line_chart_controller.js

@@ -140,7 +140,7 @@ export default class extends Controller {
           }
         }
       }
-    this.chart = new Chart(this.element, options);
+    this.chart = new window.Chart(this.element, options);
 
 
     var canvas = this.element;

data/app/assets/javascript/lookout/controllers/sparkline_controller.js

@@ -8,7 +8,7 @@ export default class extends Controller {
 
   connect() {
     // Wait for Chart.js to be available
-    if (typeof Chart === 'undefined') {
+    if (typeof window.Chart === 'undefined') {
       console.error('Chart.js not loaded for sparkline:', this.labelValue);
       // Try again after a short delay
       setTimeout(() => this.renderChart(), 100);
@@ -19,7 +19,7 @@ export default class extends Controller {
   }
 
   renderChart() {
-    if (typeof Chart === 'undefined') {
+    if (typeof window.Chart === 'undefined') {
       console.error('Chart.js still not available for:', this.labelValue);
       return;
     }
@@ -28,7 +28,7 @@ export default class extends Controller {
       // Generate sample trend data (in production, pass real data via data-sparkline-data-value)
       const data = this.hasDataValue ? this.dataValue : Array.from({length: 7}, () => Math.random() * 100);
       
-      new Chart(this.element.getContext('2d'), {
+      new window.Chart(this.element.getContext('2d'), {
         type: 'line',
         data: {
           labels: data.map((_, i) => i),

data/app/components/lookout/sticky_nav_component.html.erb

@@ -1,5 +1,5 @@
 <div class=" sticky top-0 min-h-sm z-[99999] py-6 bg-base-100">
-  <div class="max-w-6xl mx-auto max-w-6xl flex justify-between ">
+  <div class="max-w-6xl mx-auto flex justify-between px-4 sm:px-6 lg:px-8">
     <div class="flex items-center">
       <a href="<%= Lookout.config.return_path %>" class="text-lg font-medium hover:text-primary transition-colors py-2">
         <%= Lookout.config.return_copy %>

data/app/controllers/lookout/application_controller.rb

@@ -1,7 +1,6 @@
 module Lookout
   class ApplicationController < ActionController::Base
-    # Support both Pagy v9 (Backend) and v43+ (Method)
-    include defined?(Pagy::Method) ? Pagy::Method : Pagy::Backend
+    include Pagy::Method
     include CompareMode
     include RangeOptions
     include Rangeable

data/app/helpers/lookout/application_helper.rb

@@ -113,12 +113,7 @@ module Lookout
 
     def render_pagination
       if @pagination
-        # Support both Pagy v9 (pagy_nav helper) and v43+ (series_nav method)
-        if @pagination.respond_to?(:series_nav)
-          @pagination.series_nav.html_safe
-        else
-          pagy_nav(@pagination).html_safe
-        end
+        @pagination.series_nav.html_safe
       else
         ""
       end

data/lib/lookout/version.rb

@@ -1,3 +1,3 @@
 module Lookout
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/lib/lookout.rb

@@ -34,6 +34,8 @@ module Lookout
         builder.pin "@hotwired/stimulus", to: "stimulus.min.js", preload: true
         builder.pin "@hotwired/stimulus-loading", to: "stimulus-loading.js", preload: true
         builder.pin "application", to: "lookout/application.js", preload: true
+        # Chart.js must be pinned BEFORE its plugins
+        builder.pin "chart.js", to: "https://cdn.jsdelivr.net/npm/chart.js@4.4.7/dist/chart.umd.min.js", preload: true
         builder.pin "chartjs-plugin-datalabels", to: "https://cdn.jsdelivr.net/npm/chartjs-plugin-datalabels@2", preload: true
         builder.pin "classnames", to: "https://cdnjs.cloudflare.com/ajax/libs/classnames/2.3.2/index.min.js", preload: true
         builder.pin "chartjs-chart-geo", to: "https://cdn.jsdelivr.net/npm/chartjs-chart-geo@4.3.6/build/index.umd.min.js", preload: true
@@ -47,6 +49,8 @@ module Lookout
         pin "@hotwired/stimulus", to: "stimulus.min.js", preload: true
         pin "@hotwired/stimulus-loading", to: "stimulus-loading.js", preload: true
         pin "application", to: "lookout/application.js", preload: true
+        # Chart.js must be pinned BEFORE its plugins
+        pin "chart.js", to: "https://cdn.jsdelivr.net/npm/chart.js@4.4.7/dist/chart.umd.min.js", preload: true
         pin "chartjs-plugin-datalabels", to: "https://cdn.jsdelivr.net/npm/chartjs-plugin-datalabels@2", preload: true
         pin "classnames", to: "https://cdnjs.cloudflare.com/ajax/libs/classnames/2.3.2/index.min.js", preload: true
         pin "chartjs-chart-geo", to: "https://cdn.jsdelivr.net/npm/chartjs-chart-geo@4.3.6/build/index.umd.min.js", preload: true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lookout-ahoy
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - nativestranger