london-bike-hire-cli 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1e9e6f773f78b8247ecddba86e07e3512075243
-  data.tar.gz: 731c0a3a0e4efc9aa79cb583a6bd4305e44c9ea6
+  metadata.gz: 64d1ae38527d6deb4803a1f79edf34abc3ca46c5
+  data.tar.gz: 5ab0b656086b1a45516697a112e5d8637ba41752
 SHA512:
-  metadata.gz: 52fe1d036965c5374d3308cff38a348b4b01ab3c1872dc0c223e6bf6a458be8c1fde43bdbac879802f62e91160d74e8972d345b9063ef942f5291bfeea666a1c
-  data.tar.gz: 6faea855db7c1fb76fb906a080bbf07199278df4f71147e45a4c50dd2e7089afb6432bc966ca880abee83e4317037a17aeb9ef22b1f9fb52ff901e59a3f388d9
+  metadata.gz: ecafd661f8e5691e0a381d5eb6ae03cd430225328b3e31670949d1617c6129e73d4b4dcbe2a46bbf641f9a355a4d94559e11f485af7ab033b21d3567a2fc4d7f
+  data.tar.gz: d408f0ddf041ac94a334df72cc8beffe485258a9569937d7d8546630a472769ca6bb44dc38907d20e68ae4262e7f67e9282deefc70debc78175b44f34a692bb7

data/.ruby-version

@@ -1 +1 @@
-2.2.0
+2.2.3

data/.travis.yml

@@ -1,11 +1,11 @@
 language: ruby
 cache: bundler
+sudo: false
 rvm:
-  - 2.0.0
-  - 2.1.0
-  - 2.2.0
+  - 2.0
+  - 2.1
+  - 2.2
   - ruby-head
-
 matrix:
   allow_failures:
     - rvm: ruby-head

data/README.md

@@ -26,6 +26,7 @@ Here's the spec for **London Bike Hire CLI**:
 * [Find by name](#find-all-bike-stations-by-name)
 * [Display status of stations](#results)
 
+![Demo commands](bike-cli.gif?raw=true "Some London Bike Hire CLI example commands in terminal")
 
 ### Getting started
 

data/lib/london_bike_hire_cli/feed_parser.rb

@@ -3,7 +3,7 @@ require 'open-uri'
 
 module LondonBikeHireCli
   class FeedParser
-    TFL_FEED_URL = 'http://www.tfl.gov.uk/tfl/syndication/feeds/cycle-hire/livecyclehireupdates.xml'.freeze
+    TFL_FEED_URL = 'https://tfl.gov.uk/tfl/syndication/feeds/cycle-hire/livecyclehireupdates.xml'.freeze
 
     def fetch
       params = { 'User-Agent' => 'Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Firefox/31.0' }
@@ -17,11 +17,10 @@ module LondonBikeHireCli
     attr_reader :feed_time
 
     def parse_xml(xml_doc)
-      stations = []
       parse_feed_time(xml_doc)
 
-      xml_doc.root.elements.each do |node|
-        stations << parse_station(node)
+      stations = xml_doc.root.elements.inject([]) do |collection, node|
+        collection << parse_station(node)
       end
 
       QueryResponse.new(last_update: feed_time, results: stations)

data/lib/london_bike_hire_cli/version.rb

@@ -1,3 +1,3 @@
 module LondonBikeHireCli
-  VERSION = '1.3.2'
+  VERSION = '1.3.3'
 end

data/spec/fixtures/feed_xml.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://www.tfl.gov.uk/tfl/syndication/feeds/cycle-hire/livecyclehireupdates.xml
+    uri: https://tfl.gov.uk/tfl/syndication/feeds/cycle-hire/livecyclehireupdates.xml
     body:
       encoding: US-ASCII
       string: ''
@@ -817,6 +817,6 @@ http_interactions:
         Park, Parsons Green</name><terminalName>300098</terminalName><lat>51.470131</lat><long>-0.20464</long><installed>true</installed><locked>false</locked><installDate>1396265880000</installDate><removalDate></removalDate><temporary>false</temporary><nbBikes>15</nbBikes><nbEmptyDocks>5</nbEmptyDocks><nbDocks>20</nbDocks></station><station><id>775</id><name>Little
         Brook Green, Brook Green</name><terminalName>300101</terminalName><lat>51.496664</lat><long>-0.223868</long><installed>true</installed><locked>false</locked><installDate>1396270320000</installDate><removalDate></removalDate><temporary>false</temporary><nbBikes>22</nbBikes><nbEmptyDocks>10</nbEmptyDocks><nbDocks>32</nbDocks></station><station><id>777</id><name>Limburg
         Road, Clapham Common</name><terminalName>300100</terminalName><lat>51.4619230679</lat><long>-0.165297856693</long><installed>true</installed><locked>false</locked><installDate></installDate><removalDate></removalDate><temporary>false</temporary><nbBikes>19</nbBikes><nbEmptyDocks>1</nbEmptyDocks><nbDocks>21</nbDocks></station></stations>\r\n"
-    http_version: 
+    http_version:
   recorded_at: Sun, 10 Aug 2014 09:56:57 GMT
 recorded_with: VCR 2.9.2

data/spec/spec_helper.rb

@@ -7,23 +7,32 @@ Coveralls.wear!
 require File.join(File.dirname(__FILE__), '..', '/lib/', 'london_bike_hire_cli')
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause this
-# file to always be loaded, without a need to explicitly require it in any files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, make a
-# separate helper file that requires this one and then use it only in the specs
-# that actually need it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
   # These two settings work together to allow you to limit a spec run
   # to individual examples or groups you care about by tagging them with
   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
@@ -31,6 +40,17 @@ RSpec.configure do |config|
   config.filter_run :focus
   config.run_all_when_everything_filtered = true
 
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
   # Many RSpec users commonly either run the entire suite or an individual
   # file, and it's useful to allow more verbose output when running an
   # individual spec file.
@@ -41,11 +61,6 @@ RSpec.configure do |config|
     config.default_formatter = 'doc'
   end
 
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
@@ -57,27 +72,4 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
-
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # Enable only the newer, non-monkey-patching expect syntax.
-    # For more details, see:
-    #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-    expectations.syntax = :expect
-  end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Enable only the newer, non-monkey-patching expect syntax.
-    # For more details, see:
-    #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-    mocks.syntax = :expect
-
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended.
-    mocks.verify_partial_doubles = true
-  end
 end

data/spec/station_repo_spec.rb

@@ -36,7 +36,7 @@ RSpec.describe LondonBikeHireCli::Repository::StationRepo do
         it 'should raise error' do
           expect do
             subject.find(99)
-          end.to raise_error
+          end.to raise_error(KeyError)
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: london-bike-hire-cli
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Rob Murray
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-14 00:00:00.000000000 Z
+date: 2015-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -238,6 +238,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- bike-cli.gif
 - bin/lbh
 - boris-on-a-bike_med.jpg
 - lib/london_bike_hire_cli.rb
@@ -293,7 +294,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A command line interface to London's Bike Hire API.