lolsoap 0.3.2 → 0.4.0

data/.travis.yml

@@ -1,7 +1,4 @@
 language: ruby
 rvm:
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
-  # - jruby
-  # - rbx-18mode
+  - 2.0.0

data/README.md

@@ -105,6 +105,17 @@ Development sponsored by [Loco2](http://loco2.com/).
 
 ## Changelog ##
 
+### 0.4 ###
+
+* Don't raise an exception on when a SOAP fault is detected. Whether or
+  not this is an exceptional situation should be up to the user, as APIs
+  may use SOAP faults to implement business logic errors.
+* Ruby 1.8 support dropped
+
+### 0.3 ###
+
+* Support for WSDL inline type definitions and type extensions
+
 ### 0.2 ###
 
 * SOAP 1.1 support

data/VERSION

@@ -1 +1 @@
-0.3.2
+0.4.0

data/lib/lolsoap/fault.rb

@@ -17,21 +17,21 @@ module LolSoap
 
     def code
       node.at_xpath(
-        soap_version == '1.2' ? './soap:Code/soap:Value' : './soap:faultcode',
+        soap_version == '1.2' ? './soap:Code/soap:Value' : './faultcode',
         'soap' => soap_namespace
       ).text.to_s
     end
 
     def reason
       node.at_xpath(
-        soap_version == '1.2' ? './soap:Reason/soap:Text' : './soap:faultstring',
+        soap_version == '1.2' ? './soap:Reason/soap:Text' : './faultstring',
         'soap' => soap_namespace
       ).text.to_s
     end
 
     def detail
       node.at_xpath(
-        soap_version == '1.2' ? './soap:Detail/*' : './soap:detail/*',
+        soap_version == '1.2' ? './soap:Detail/*' : './detail/*',
         'soap' => soap_namespace
       ).to_xml
     end

data/lib/lolsoap/response.rb

@@ -1,4 +1,3 @@
-require 'lolsoap/errors'
 require 'lolsoap/fault'
 require 'lolsoap/hash_builder'
 require 'nokogiri'
@@ -22,8 +21,6 @@ module LolSoap
     def initialize(request, doc)
       @request = request
       @doc     = doc
-
-      raise FaultRaised.new(fault) if fault
     end
 
     # Namespace used for SOAP Envelope tags
@@ -46,7 +43,7 @@ module LolSoap
       @header ||= doc.at_xpath('/soap:Envelope/soap:Header', 'soap' => soap_namespace)
     end
 
-    # SOAP fault, if any (an exception will be raised in the initializer, if there is one)
+    # SOAP fault, if any
     def fault
       @fault ||= begin
         node = doc.at_xpath('/soap:Envelope/soap:Body/soap:Fault', 'soap' => soap_namespace)

data/lib/lolsoap/wsdl_parser.rb

@@ -1,4 +1,5 @@
 require 'nokogiri'
+require 'cgi'
 
 module LolSoap
   # @private
@@ -125,7 +126,7 @@ module LolSoap
     end
 
     def endpoint
-      @endpoint ||= doc.at_xpath('/d:definitions/d:service/d:port/s:address/@location', ns).to_s
+      @endpoint ||= CGI.unescape(doc.at_xpath('/d:definitions/d:service/d:port/s:address/@location', ns).to_s)
     end
 
     def schemas
@@ -251,3 +252,4 @@ module LolSoap
     end
   end
 end
+

data/lib/lolsoap.rb

@@ -2,7 +2,6 @@ module LolSoap
   require 'lolsoap/builder'
   require 'lolsoap/client'
   require 'lolsoap/envelope'
-  require 'lolsoap/errors'
   require 'lolsoap/fault'
   require 'lolsoap/request'
   require 'lolsoap/response'

data/lolsoap.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "lolsoap"
-  s.version = "0.3.2"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jon Leighton"]
-  s.date = "2013-06-27"
+  s.date = "2013-08-17"
   s.description = "A library for dealing with SOAP requests and responses. We tear our hair out so you don't have to."
   s.email = "j@jonathanleighton.com"
   s.extra_rdoc_files = [
@@ -30,7 +30,6 @@ Gem::Specification.new do |s|
     "lib/lolsoap/builder.rb",
     "lib/lolsoap/client.rb",
     "lib/lolsoap/envelope.rb",
-    "lib/lolsoap/errors.rb",
     "lib/lolsoap/fault.rb",
     "lib/lolsoap/hash_builder.rb",
     "lib/lolsoap/request.rb",

data/test/fixtures/stock_quote.wsdl

@@ -134,7 +134,7 @@
   <service name="StockQuoteService">
     <documentation>My first service</documentation>
     <port name="StockQuotePort" binding="tns:StockQuoteSoapBinding">
-      <soap:address location="http://example.com/stockquote"/>
+      <soap:address location="http://example.com%2Fstockquote"/>
     </port>
   </service>
 

data/test/fixtures/stock_quote_fault_soap_1_1.xml

@@ -1,10 +1,10 @@
 <?xml version="1.0"?>
 <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
-<soap:Body>
-  <soap:Fault>
-    <soap:faultcode>soap:Sender</soap:faultcode>
-    <soap:faultstring>Omg! stock market has crashed!</soap:faultstring>
-    <soap:detail><Foo>Some detail</Foo></soap:detail>
-  </soap:Fault>
-</soap:Body>
+  <soap:Body>
+    <soap:Fault>
+      <faultcode>soap:Sender</faultcode>
+      <faultstring>Omg! stock market has crashed!</faultstring>
+      <detail><Foo>Some detail</Foo></detail>
+    </soap:Fault>
+  </soap:Body>
 </soap:Envelope>

data/test/unit/test_response.rb

@@ -37,9 +37,9 @@ module LolSoap
       end
     end
 
-    it 'should raise a FaultRaised error when initialized, if there is a SOAP fault' do
-      lambda { Response.new(request, Nokogiri::XML(File.read(TEST_ROOT + '/fixtures/stock_quote_fault.xml'))) }.
-        must_raise FaultRaised
+    it 'should return the soap fault' do
+      response = Response.new(request, Nokogiri::XML(File.read(TEST_ROOT + '/fixtures/stock_quote_fault.xml')))
+      response.fault.wont_equal nil
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lolsoap
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-27 00:00:00.000000000 Z
+date: 2013-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -113,7 +113,6 @@ files:
 - lib/lolsoap/builder.rb
 - lib/lolsoap/client.rb
 - lib/lolsoap/envelope.rb
-- lib/lolsoap/errors.rb
 - lib/lolsoap/fault.rb
 - lib/lolsoap/hash_builder.rb
 - lib/lolsoap/request.rb
@@ -164,7 +163,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 765502511
+      hash: 2957288385863743172
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:

data/lib/lolsoap/errors.rb

@@ -1,15 +0,0 @@
-module LolSoap
-  class Error < StandardError; end
-
-  class FaultRaised < Error
-    attr_reader :fault
-
-    def initialize(fault)
-      @fault = fault
-    end
-
-    def message
-      "#{fault.reason}\n#{fault.detail}"
-    end
-  end
-end