lolesports-api 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 402fad071f4b0f27a2c731639413bcfb082bd079
-  data.tar.gz: 11f981a8700e4c7094cb6e95bd89f55ce2d56dac
+  metadata.gz: ff0d34fadcde4f55787e960a6088b5868d710406
+  data.tar.gz: 1f964a69c0a67ae53a891b87a84c310c8916fa93
 SHA512:
-  metadata.gz: 4907a696a6a1fa4ae76479431b7a737e8cefcdf1e30e7ffdf4b8a90bd1831965735cb12dbcc6a6f3bc107482a29d3badb0aa0e9782a4fed16c81a4e074f06a3b
-  data.tar.gz: 2fc292e31cba432fad126ccaa1160204fe3b2b067a6cc731ca6fd84351139b7aaf9845bf3a857a86f9cc7cc0740c96642ee0329a4bd75dbd750fb80d1ba4402d
+  metadata.gz: 9988395bf799fc896af9948c2d7d0bca2827843c089e93275b939e7c01b4dab6f8750ab9e8a142cf3666ac33f4c29698ab202f6b3cd7d0531e296c5484bb213b
+  data.tar.gz: 5574fa601fca2e5c452ac33651abcb8a662159cdb2b65d407c8ce1ca7783b1abdf014d2bf59c2c4f2434144e05ee7629a7d5ec3dadf1e595717b33775b1cc346

data/lib/lolesports-api.rb

@@ -1,4 +1,5 @@
 require 'lolesports-api/version'
+require 'lolesports-api/error'
 require 'lolesports-api/base'
 require 'lolesports-api/player'
 require 'lolesports-api/team'

data/lib/lolesports-api/base.rb

@@ -8,6 +8,7 @@ module LolesportsApi
 
     def self.find(base_id)
       response = Faraday.get("#{self::API_URL}/#{base_id}.json")
+      fail_by_status(response) unless response.success?
       @attributes = JSON.parse(response.body)
       @attributes['id'] = base_id
       @base_object = new(@attributes)
@@ -15,9 +16,16 @@ module LolesportsApi
 
     def reload
       response = Faraday.get("#{self.class::API_URL}/#{@id}.json")
+      self.class.fail_by_status(response) unless response.success?
       @attributes = JSON.parse(response.body)
       initialize(@attributes)
       self
     end
+
+    def self.fail_by_status(response)
+      klass =
+        LolesportsApi::Error::ERRORS[response.status] || LolesportsApi::Error
+      fail klass
+    end
   end
 end

data/lib/lolesports-api/error.rb

@@ -0,0 +1,22 @@
+module LolesportsApi
+  class Error < StandardError
+    attr_reader :code
+
+    def initialize(message = '', code = nil)
+      super(message)
+      @code = code
+    end
+
+    UnauthorizedAccess = Class.new(self)
+
+    InternalServerError = Class.new(self)
+
+    BadGateway = Class.new(self)
+
+    ERRORS = {
+      403 => LolesportsApi::Error::UnauthorizedAccess,
+      500 => LolesportsApi::Error::InternalServerError,
+      502 => LolesportsApi::Error::BadGateway
+    }
+  end
+end

data/lib/lolesports-api/team.rb

@@ -22,8 +22,10 @@ module LolesportsApi
 
     def self.find(team_id)
       super
-      @attributes['roster'].each_value do |player|
-        @base_object.roster << LolesportsApi::Player.new(player)
+      if @attributes['roster'].any?
+        @attributes['roster'].each_value do |player|
+          @base_object.roster << LolesportsApi::Player.new(player)
+        end
       end
       @base_object
     end

data/lib/lolesports-api/tournament.rb

@@ -18,7 +18,7 @@ module LolesportsApi
       @name_public = attributes['namePublic']
       @no_vods = attributes['noVods']
       @published = attributes['published']
-      @season = attributes['season'].to_i
+      @season = attributes['season']
       @winner = attributes['winner'].to_i
       @round = attributes['round']
       @matches = []

data/lib/lolesports-api/version.rb

@@ -1,3 +1,3 @@
 module LolesportsApi
-  VERSION = '0.1.0'
+  VERSION = '0.1.2'
 end

data/spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/when_a_team_does_not_have_players/.yml

@@ -0,0 +1,81 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://na.lolesports.com/api/team/4.json
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Sat, 15 Aug 2015 17:42:34 GMT
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '922'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=dc002d92b2b9546b3cd2d5e409e782ea11439660554; expires=Sun, 14-Aug-16
+        17:42:34 GMT; path=/; domain=.lolesports.com; HttpOnly
+      Cache-Control:
+      - public, max-age=1800
+      Etag:
+      - '"1439660254-1"'
+      Expires:
+      - Sat, 15 Aug 2015 18:12:34 GMT
+      Last-Modified:
+      - Sat, 15 Aug 2015 17:37:34 GMT
+      Vary:
+      - Accept-Encoding
+      Via:
+      - 1.1 varnish
+      X-Drupal-Cache:
+      - MISS
+      X-Varnish:
+      - '476039840'
+      X-Varnish-Cache:
+      - MISS
+      Cf-Cache-Status:
+      - HIT
+      Accept-Ranges:
+      - bytes
+      Server:
+      - cloudflare-nginx
+      Cf-Ray:
+      - 2166b26170010707-SJC
+    body:
+      encoding: ASCII-8BIT
+      string: '{"name":"Curse","bio":"Curse''s roster has fluctuated frequently since
+        its inception, with even NyJacky gone from the original team. Their Season
+        2 performance landed them just shy of the top 3 in North America, a curse
+        that would continue even through present-day. After opening with an 8-0 record
+        to the spring split, the team began to lose steam and have been on a downward
+        decline that not even all-star EdwarD could stave off. EdwarD later returned
+        to Gambit in Europe, and Zekent was added as the starting support. Also adding
+        the formerly banned player, IWillDominate, both he and Curse sought to prove
+        that they were turning over a new leaf in the competitive scene.\r\n\r\nThe
+        2014 spring split met Curse with mixed results. They rode out the split in
+        the middle of the pack, more consistent than the bottom teams, yet not advanced
+        enough to break into the top three. During the split, Curse dropped Zekent
+        and briefly fielded Saintvicious in the support role. While he performed well
+        individually, Curse didn\u2019t see marked success with this new swap, and
+        eventually Saintvicious returned to retirement and Curse picked up Bunny FuFuu
+        in the support role. Finishing the split in fourth place, Bunny FuFuu was
+        moved to a substitute role in favor of former TSM member, Xpecial. Curse will
+        look to the summer split to prove that, with enough time, they can compete
+        for the top spot and a trip to the World Championships.  \r\n","noPlayers":"0","roster":[],"logoUrl":"http://riot-web-cdn.s3-us-west-1.amazonaws.com/lolesports/s3fs-public/CurseLogos_RGB.png","profileUrl":"http://na.lolesports.com/node/4","teamPhotoUrl":"http://na.lolesports.com/","acronym":"CRS"}'
+    http_version: 
+  recorded_at: Sat, 15 Aug 2015 17:42:34 GMT
+recorded_with: VCR 2.9.3

data/spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/{.yml → when_a_team_has_players/.yml}

@@ -19,7 +19,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Wed, 05 Aug 2015 05:13:33 GMT
+      - Sat, 15 Aug 2015 17:42:34 GMT
       Content-Type:
       - application/json
       Content-Length:
@@ -27,16 +27,16 @@ http_interactions:
       Connection:
       - keep-alive
       Set-Cookie:
-      - __cfduid=de771f1db6d002794526572affea495441438751612; expires=Thu, 04-Aug-16
-        05:13:32 GMT; path=/; domain=.lolesports.com; HttpOnly
+      - __cfduid=dd637975f1af879bd9d49a1b34f96efaa1439660553; expires=Sun, 14-Aug-16
+        17:42:33 GMT; path=/; domain=.lolesports.com; HttpOnly
       Cache-Control:
       - public, max-age=1800
       Etag:
-      - '"1438751166-1"'
+      - '"1439660554-1"'
       Expires:
-      - Wed, 05 Aug 2015 05:43:33 GMT
+      - Sat, 15 Aug 2015 18:12:34 GMT
       Last-Modified:
-      - Wed, 05 Aug 2015 05:06:06 GMT
+      - Sat, 15 Aug 2015 17:42:34 GMT
       Vary:
       - Accept-Encoding
       Via:
@@ -44,9 +44,9 @@ http_interactions:
       X-Drupal-Cache:
       - MISS
       X-Varnish:
-      - 1377982057 1377979533
+      - '144888865'
       X-Varnish-Cache:
-      - HIT
+      - MISS
       Cf-Cache-Status:
       - EXPIRED
       Accept-Ranges:
@@ -54,7 +54,7 @@ http_interactions:
       Server:
       - cloudflare-nginx
       Cf-Ray:
-      - 2110036c1d66286a-SJC
+      - 2166b25dad9c11d7-SJC
     body:
       encoding: ASCII-8BIT
       string: '{"name":"Cloud9 ","bio":null,"noPlayers":"0","roster":{"players0":{"playerId":"328","name":"Balls","role":"Top
@@ -64,5 +64,5 @@ http_interactions:
         Lane","isStarter":1},"players7":{"playerId":"1313","name":"Sheep","role":"Support","isStarter":0},"players8":{"playerId":"1353","name":"Yusui","role":"Mid
         Lane","isStarter":0},"players9":{"playerId":"2551","name":"Hard","role":"Jungler","isStarter":0}},"logoUrl":"http://riot-web-cdn.s3-us-west-1.amazonaws.com/lolesports/s3fs-public/cloud9-logo.png","profileUrl":"http://na.lolesports.com/node/304","teamPhotoUrl":"http://na.lolesports.com/","acronym":"C9"}'
     http_version: 
-  recorded_at: Wed, 05 Aug 2015 05:13:32 GMT
+  recorded_at: Sat, 15 Aug 2015 17:42:34 GMT
 recorded_with: VCR 2.9.3

data/spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/{.yml → when_the_Tournament_is_available/.yml}

@@ -19,7 +19,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Mon, 10 Aug 2015 02:47:45 GMT
+      - Sat, 15 Aug 2015 19:41:38 GMT
       Content-Type:
       - application/json
       Content-Length:
@@ -27,16 +27,16 @@ http_interactions:
       Connection:
       - keep-alive
       Set-Cookie:
-      - __cfduid=dad0c4258d5805a752f6a014b805760e51439174865; expires=Tue, 09-Aug-16
-        02:47:45 GMT; path=/; domain=.lolesports.com; HttpOnly
+      - __cfduid=db5075e6f93fd40902cd2929a95bd31eb1439667693; expires=Sun, 14-Aug-16
+        19:41:33 GMT; path=/; domain=.lolesports.com; HttpOnly
       Cache-Control:
       - public, max-age=1800
       Etag:
-      - '"1439174870-1"'
+      - '"1439667695-1"'
       Expires:
-      - Mon, 10 Aug 2015 03:17:45 GMT
+      - Sat, 15 Aug 2015 20:11:38 GMT
       Last-Modified:
-      - Mon, 10 Aug 2015 02:47:50 GMT
+      - Sat, 15 Aug 2015 19:41:35 GMT
       Vary:
       - Accept-Encoding
       Via:
@@ -44,17 +44,17 @@ http_interactions:
       X-Drupal-Cache:
       - MISS
       X-Varnish:
-      - '975588137'
+      - '874393733'
       X-Varnish-Cache:
       - MISS
       Cf-Cache-Status:
-      - EXPIRED
+      - MISS
       Accept-Ranges:
       - bytes
       Server:
       - cloudflare-nginx
       Cf-Ray:
-      - 213860ba7c730d85-SJC
+      - 216760ae79cf1e83-SJC
     body:
       encoding: ASCII-8BIT
       string: '{"namePublic":"EU LCS Summer Split","contestants":{"contestant1":{"id":"1100","name":"Copenhagen
@@ -64,5 +64,5 @@ http_interactions:
         Gaming","acronym":"GMB"}},"isFinished":true,"dateBegin":"2014-05-20T15:00Z","dateEnd":"2014-07-31T15:00Z","noVods":0,"season":"2014","published":true,"winner":"69","name":"EU
         LCS Summer Split"}'
     http_version: 
-  recorded_at: Mon, 10 Aug 2015 02:47:45 GMT
+  recorded_at: Sat, 15 Aug 2015 19:41:38 GMT
 recorded_with: VCR 2.9.3

data/spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/when_the_Tournament_is_only_for_authorized_accounts/raises_LolesportsApi_Error_UnauthorizedAccess.yml

@@ -0,0 +1,61 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://na.lolesports.com/api/tournament/192.json
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 403
+      message: ": Access denied for user anonymous"
+    headers:
+      Date:
+      - Sat, 15 Aug 2015 19:41:38 GMT
+      Content-Type:
+      - application/json
+      Content-Length:
+      - '56'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d29b7c65211f27eddb85f1e432836a0801439667698; expires=Sun, 14-Aug-16
+        19:41:38 GMT; path=/; domain=.lolesports.com; HttpOnly
+      Cache-Control:
+      - public, max-age=600
+      Etag:
+      - '"1439667215-1"'
+      Expires:
+      - Sun, 19 Nov 1978 05:00:00 GMT
+      Last-Modified:
+      - Sat, 15 Aug 2015 19:33:35 GMT
+      Vary:
+      - Accept-Encoding
+      Via:
+      - 1.1 varnish
+      X-Drupal-Cache:
+      - MISS
+      X-Varnish:
+      - '1443692253'
+      X-Varnish-Cache:
+      - MISS
+      Cf-Cache-Status:
+      - HIT
+      Server:
+      - cloudflare-nginx
+      Cf-Ray:
+      - 216760cb1aaf1ea7-SJC
+    body:
+      encoding: ASCII-8BIT
+      string: '["Access denied for user anonymous"]'
+    http_version: 
+  recorded_at: Sat, 15 Aug 2015 19:41:38 GMT
+recorded_with: VCR 2.9.3

data/spec/lolesports-api/error_spec.rb

@@ -0,0 +1,7 @@
+describe LolesportsApi::Error do
+  describe '#new' do
+    let(:error) { LolesportsApi::Error.new('Unauthorized Access', 403) }
+    it { expect(error.message).to eq 'Unauthorized Access' }
+    it { expect(error.code).to eq 403 }
+  end
+end

data/spec/lolesports-api/team_spec.rb

@@ -1,12 +1,20 @@
 describe LolesportsApi::Team do
-  describe '.find', vcr: true do
-    let(:team) { LolesportsApi::Team.find(304) }
-    it { expect(team.class).to eq LolesportsApi::Team }
-    it { expect(team.acronym).to eq 'C9' }
-    it { expect(team.id).to eq 304 }
-    it { expect(team.roster.class).to eq Array }
-    it { expect(team.roster.first.class).to eq LolesportsApi::Player }
-    it { expect(team.roster[4].name).to eq 'Meteos' }
-    it { expect(team.roster[4].id).to eq 329 }
+  describe '.find' do
+    context 'when a team has players', vcr: true do
+      let(:team) { LolesportsApi::Team.find(304) }
+      it { expect(team.class).to eq LolesportsApi::Team }
+      it { expect(team.acronym).to eq 'C9' }
+      it { expect(team.id).to eq 304 }
+      it { expect(team.roster.class).to eq Array }
+      it { expect(team.roster.first.class).to eq LolesportsApi::Player }
+      it { expect(team.roster[4].name).to eq 'Meteos' }
+      it { expect(team.roster[4].id).to eq 329 }
+    end
+    context 'when a team does not have players', vcr: true do
+      let(:team) { LolesportsApi::Team.find(4) }
+      it { expect(team.class).to eq LolesportsApi::Team }
+      it { expect(team.name).to eq 'Curse' }
+      it { expect(team.roster).to eq [] }
+    end
   end
 end

data/spec/lolesports-api/tournament_spec.rb

@@ -1,10 +1,19 @@
 describe LolesportsApi::Tournament do
   describe '.find', vcr: true do
-    let(:tournament) { LolesportsApi::Tournament.find(102) }
-    it { expect(tournament.class).to eq LolesportsApi::Tournament }
-    it { expect(tournament.name).to eq 'EU LCS Summer Split' }
-    it { expect(tournament.id).to eq 102 }
-    it { expect(tournament.contestants[0].id).to eq 1100 }
+    context 'when the Tournament is available' do
+      let(:tournament) { LolesportsApi::Tournament.find(102) }
+      it { expect(tournament.class).to eq LolesportsApi::Tournament }
+      it { expect(tournament.name).to eq 'EU LCS Summer Split' }
+      it { expect(tournament.id).to eq 102 }
+      it { expect(tournament.contestants[0].id).to eq 1100 }
+    end
+    context 'when the Tournament is only for authorized accounts' do
+      it 'raises LolesportsApi::Error::UnauthorizedAccess' do
+        expect do
+          LolesportsApi::Tournament.find(192)
+        end.to raise_error LolesportsApi::Error::UnauthorizedAccess
+      end
+    end
   end
 
   describe '#find_matches', vcr: true do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolesports-api
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Jake Mays
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-12 00:00:00.000000000 Z
+date: 2015-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -181,6 +181,7 @@ files:
 - Rakefile
 - lib/lolesports-api.rb
 - lib/lolesports-api/base.rb
+- lib/lolesports-api/error.rb
 - lib/lolesports-api/game.rb
 - lib/lolesports-api/league.rb
 - lib/lolesports-api/match.rb
@@ -199,9 +200,12 @@ files:
 - spec/fixtures/vcr/cassettes/LolesportsApi_Player/_reload/.yml
 - spec/fixtures/vcr/cassettes/LolesportsApi_Series/_all/.yml
 - spec/fixtures/vcr/cassettes/LolesportsApi_Series/_find/.yml
-- spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/.yml
-- spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/when_a_team_does_not_have_players/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/when_a_team_has_players/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/when_the_Tournament_is_available/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/when_the_Tournament_is_only_for_authorized_accounts/raises_LolesportsApi_Error_UnauthorizedAccess.yml
 - spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find_matches/.yml
+- spec/lolesports-api/error_spec.rb
 - spec/lolesports-api/game_spec.rb
 - spec/lolesports-api/league_spec.rb
 - spec/lolesports-api/match_spec.rb
@@ -244,9 +248,12 @@ test_files:
 - spec/fixtures/vcr/cassettes/LolesportsApi_Player/_reload/.yml
 - spec/fixtures/vcr/cassettes/LolesportsApi_Series/_all/.yml
 - spec/fixtures/vcr/cassettes/LolesportsApi_Series/_find/.yml
-- spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/.yml
-- spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/when_a_team_does_not_have_players/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Team/_find/when_a_team_has_players/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/when_the_Tournament_is_available/.yml
+- spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find/when_the_Tournament_is_only_for_authorized_accounts/raises_LolesportsApi_Error_UnauthorizedAccess.yml
 - spec/fixtures/vcr/cassettes/LolesportsApi_Tournament/_find_matches/.yml
+- spec/lolesports-api/error_spec.rb
 - spec/lolesports-api/game_spec.rb
 - spec/lolesports-api/league_spec.rb
 - spec/lolesports-api/match_spec.rb