lolcommits 0.9.4 → 0.9.5.pre1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6bde0388bf4f5618ad723b966a29d357551ab84
-  data.tar.gz: 294abe646e403ec2ff9b120ec9ac9788af38e3aa
+  metadata.gz: dd13587e4a453dcd73506653bba23b9fe19c6903
+  data.tar.gz: beacc833f4169a2309e0fc0927f5dc3c639fda1d
 SHA512:
-  metadata.gz: 572687c4801b036de2bf5e3658eb5087f4f700f5429da5f9ed4e5d8dee7fba659ef4967dd8fd3b3a454f2270173615b365a6b44e4ec77e1ab996a1607c21de04
-  data.tar.gz: b2daed80aa5decba8d64aa4bbe1ba3fe8fdfb69b8c6b528dbe0c54cc34dea714c70825e24992f8ae4315ae5b3ce0304c969fbb7b94e5061b725b2e4eba230893
+  metadata.gz: aa7c9e5065643d109fec9fbcdcf9e75d9f349809bc4e95e43717c3f93b1ec9f203c0a052cf70d72593d3432172170c66fe7345aae2be7c003fc18af6f27518e1
+  data.tar.gz: 41035783d256a3d9929016e898107f51040e2ee03a561c145aab1b227dfe91ef490c9558769afeb58130ecf391ed065a623f078a82db4ef3099c77f08eab49f3

data/.rubocop.yml

@@ -2,5 +2,6 @@ AllCops:
   Exclude:
     - vendor/bundle/**/*
     - .bundle/**/*
+    - '**/.irbrc'
 
 inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -18,7 +18,7 @@ Metrics/AbcSize:
 # Offense count: 2
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 40
+  Max: 60
 
 # Offense count: 5
 # Configuration parameters: CountComments.
@@ -56,7 +56,7 @@ Style/Documentation:
 
 # Offense count: 2
 # Cop supports --auto-correct.
-Style/EmptyLinesAroundBeginBody:
+Layout/EmptyLinesAroundBeginBody:
   Exclude:
     - 'lib/lolcommits/plugin/lol_flowdock.rb'
     - 'lib/lolcommits/plugin/lol_slack.rb'
@@ -65,7 +65,7 @@ Style/EmptyLinesAroundBeginBody:
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Style/IndentHeredoc:
+Layout/IndentHeredoc:
   Exclude:
     - 'lib/lolcommits/backends/installation_git.rb'
 

data/CHANGELOG.md

@@ -8,6 +8,9 @@ project adheres to [Semantic Versioning][Semver].
   * WIP - extract more plugins to gems ...
   * Your contribution here!
 
+## [0.9.5][] (21 July 2017)
+  * Extract Twitter Plugin / refactor Plugin::Base (@matthutchinson [#347][])
+
 ## [0.9.4][] (17 April 2017)
   * Add captureready plugin hook (@matthutchinson [#342][])
   * README changes (@mroth [#341][])
@@ -279,7 +282,8 @@ project adheres to [Semantic Versioning][Semver].
   instead of compositing multiply image Caption objects (this seems to be more
   reliable to not glitch.)
 
-[Unreleased]: https://github.com/mroth/lolcommits/compare/v0.9.4...HEAD
+[Unreleased]: https://github.com/mroth/lolcommits/compare/v0.9.5...HEAD
+[0.9.5]: https://github.com/mroth/lolcommits/compare/v0.9.4...v0.9.5
 [0.9.4]: https://github.com/mroth/lolcommits/compare/v0.9.3...v0.9.4
 [0.9.3]: https://github.com/mroth/lolcommits/compare/v0.9.2...v0.9.3
 [0.9.2]: https://github.com/mroth/lolcommits/compare/v0.9.1...v0.9.2
@@ -443,3 +447,4 @@ project adheres to [Semantic Versioning][Semver].
 [#340]: https://github.com/mroth/lolcommits/pull/340
 [#341]: https://github.com/mroth/lolcommits/pull/341
 [#342]: https://github.com/mroth/lolcommits/pull/342
+[#347]: https://github.com/mroth/lolcommits/pull/347

data/Gemfile

@@ -1,4 +1,2 @@
 source 'https://rubygems.org'
-
-# Specify gem dependencies in lolcommits.gemspec
 gemspec

data/README.md

@@ -209,7 +209,7 @@ Installed plugins can be easily enabled, configured or disabled with the
     lolcommits --config -p loltext
 
 Interested in developing your own plugin? Follow [this simple
-guide](https://github.com/lolcommits/lolcommits-plugin-sample) at the
+guide](https://github.com/lolcommits/lolcommits-plugin-sample#developing-your-own-plugin) at the
 Lolcommits Plugin Sample README.
 
 

data/lib/lolcommits.rb

@@ -30,7 +30,6 @@ require 'lolcommits/backends/mercurial_info'
 
 require 'lolcommits/plugin/base'
 require 'lolcommits/plugin/dot_com'
-require 'lolcommits/plugin/lol_twitter'
 require 'lolcommits/plugin/uploldz'
 require 'lolcommits/plugin/term_output'
 require 'lolcommits/plugin/lolsrv'

data/lib/lolcommits/cli/launcher.rb

@@ -16,6 +16,10 @@ module Lolcommits
         open_with_launchy(path)
       end
 
+      def self.open_url(url)
+        open_with_launchy(url)
+      end
+
       # Opens with Launchy, which knows how to open pretty much anything
       # local files, urls, etc.
       #

data/lib/lolcommits/configuration.rb

@@ -71,7 +71,7 @@ module Lolcommits
       return if plugin_name.empty?
 
       plugin_klass = plugin_manager.find_by_name(plugin_name)
-      return plugin_klass.new(nil) if plugin_klass
+      return plugin_klass.new(config: self) if plugin_klass
 
       puts "Unable to find plugin: '#{plugin_name}'"
       return if plugin_name_option.empty?

data/lib/lolcommits/plugin/base.rb

@@ -1,41 +1,45 @@
 module Lolcommits
   module Plugin
     class Base
-      attr_accessor :runner, :options
+      attr_accessor :runner, :config, :options
 
-      def initialize(runner)
+      def initialize(runner: nil, config: nil)
         self.runner = runner
+        self.config = config || runner.config
         self.options = ['enabled']
       end
 
-      def execute_precapture
+      def execute_pre_capture
         return unless configured_and_enabled?
-        debug 'I am enabled, about to run precapture'
-        run_precapture
+        debug 'I am enabled, about to run pre capture'
+        run_precapture # TODO: remove me (legacy method)
+        run_pre_capture
       end
 
-      def execute_postcapture
+      def execute_post_capture
         return unless configured_and_enabled?
-        debug 'I am enabled, about to run postcapture'
-        run_postcapture
+        debug 'I am enabled, about to run post capture'
+        run_postcapture # TODO: remove me (legacy method)
+        run_post_capture
       end
 
-      def execute_captureready
+      def execute_capture_ready
         return unless configured_and_enabled?
-        debug 'I am enabled, about to run captureready'
-        run_captureready
+        debug 'I am enabled, about to run capture ready'
+        run_captureready # TODO: remove me (legacy method)
+        run_capture_ready
       end
 
-      def run_precapture; end
+      def run_pre_capture; end
 
-      def run_postcapture; end
+      def run_post_capture; end
 
-      def run_captureready; end
+      def run_capture_ready; end
 
       def configuration
-        config = runner.config.read_configuration if runner
-        return {} unless config
-        config[self.class.name] || {}
+        saved_config = config.read_configuration
+        return {} unless saved_config
+        saved_config[self.class.name] || {}
       end
 
       # ask for plugin options
@@ -87,13 +91,18 @@ module Lolcommits
         !configuration.empty?
       end
 
-      # uniform puts for plugins
-      # dont puts if the runner wants to be silent (stealth mode)
+      # uniform puts and print for plugins
+      # dont puts or print if the runner wants to be silent (stealth mode)
       def puts(*args)
         return if runner && runner.capture_stealth
         super(args)
       end
 
+      def print(args)
+        return if runner && runner.capture_stealth
+        super(args)
+      end
+
       # helper to log errors with a message via debug
       def log_error(e, message)
         debug message
@@ -118,12 +127,19 @@ module Lolcommits
       # Three hook positions exist, your plugin code can execute in one or more
       # of these.
       #
-      # @return [Array] the position(s) (:precapture, :postcapture,
-      # :captureready)
+      # @return [Array] the position(s) (:pre_capture, :post_capture,
+      # :capture_ready)
       #
       def self.runner_order
         []
       end
+
+      # TODO: remove these legacy methods
+      def run_precapture; end
+
+      def run_postcapture; end
+
+      def run_captureready; end
     end
   end
 end

data/lib/lolcommits/plugin/dot_com.rb

@@ -5,12 +5,12 @@ module Lolcommits
     class DotCom < Base
       BASE_URL = 'http://lolcommits-dot-com.herokuapp.com'.freeze
 
-      def initialize(runner)
+      def initialize(runner: nil, config: nil)
         super
         options.concat(%w(api_key api_secret repo_id))
       end
 
-      def run_captureready
+      def run_capture_ready
         t = Time.now.to_i.to_s
         HTTMultiParty.post(
           "#{BASE_URL}/git_commits.json",
@@ -43,7 +43,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
     end
   end

data/lib/lolcommits/plugin/lol_flowdock.rb

@@ -11,7 +11,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
 
       def configured?
@@ -45,7 +45,7 @@ module Lolcommits
         options
       end
 
-      def run_captureready
+      def run_capture_ready
         retries = RETRY_COUNT
         begin
 

data/lib/lolcommits/plugin/lol_hipchat.rb

@@ -32,7 +32,7 @@ module Lolcommits
         }
       end
 
-      def run_captureready
+      def run_capture_ready
         http = Net::HTTP.new(api_url.host, api_url.port)
         # http.set_debug_output $stderr # nice for debugging, never ever release with it
         http.start do |connection|
@@ -74,7 +74,7 @@ module Lolcommits
       end
 
       def api_url
-        URI(format('http://%{api_team}.hipchat.com/v2/room/%{api_room}/share/file?auth_token=%{api_token}', symbolized_configuration))
+        URI(format('http://%<api_team>.hipchat.com/v2/room/%<api_room>/share/file?auth_token=%<api_token>', symbolized_configuration))
       end
 
       def symbolized_configuration
@@ -117,7 +117,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
     end
   end

data/lib/lolcommits/plugin/lol_protonet.rb

@@ -3,12 +3,12 @@ require 'rest_client'
 module Lolcommits
   module Plugin
     class LolProtonet < Base
-      def initialize(runner)
+      def initialize(runner: nil, config: nil)
         super
         options.concat(%w(api_token api_endpoint))
       end
 
-      def run_captureready
+      def run_capture_ready
         debug "Posting capture to #{configuration['endpoint']}"
         RestClient.post(
           api_url,
@@ -61,7 +61,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
     end
   end

data/lib/lolcommits/plugin/lol_slack.rb

@@ -11,7 +11,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
 
       def configured?
@@ -40,7 +40,7 @@ module Lolcommits
         options
       end
 
-      def run_captureready
+      def run_capture_ready
         retries = RETRY_COUNT
         begin
 

data/lib/lolcommits/plugin/lol_tumblr.rb

@@ -11,7 +11,7 @@ module Lolcommits
       TUMBLR_CONSUMER_KEY    = '2FtMEDpEPkxjoUdkpHh42h9wqTu9IVS7Ra0QyNZGixdCvhllN2'.freeze
       TUMBLR_CONSUMER_SECRET = 'qWuvxgFUR2YyWKtbWOkDTMAiBEbj7ZGaNLaNQPba0PI1N4JpBs'.freeze
 
-      def run_captureready
+      def run_capture_ready
         puts 'Posting to Tumblr'
         r = client.photo(configuration['tumblr_name'], data: runner.main_image)
         if r.key?('id')
@@ -111,7 +111,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
 
       protected

data/lib/lolcommits/plugin/lol_yammer.rb

@@ -15,7 +15,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
 
       def configured?
@@ -53,7 +53,7 @@ module Lolcommits
         options
       end
 
-      def run_captureready
+      def run_capture_ready
         commit_msg = runner.message
         post = "#{commit_msg} #lolcommits"
         puts "Yammer post: #{post}" unless runner.capture_stealth

data/lib/lolcommits/plugin/lolsrv.rb

@@ -5,12 +5,12 @@ require 'json'
 module Lolcommits
   module Plugin
     class Lolsrv < Base
-      def initialize(runner)
+      def initialize(runner: nil, config: nil)
         super
         options << 'server'
       end
 
-      def run_captureready
+      def run_capture_ready
         fork { sync }
       end
 
@@ -51,7 +51,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
     end
   end

data/lib/lolcommits/plugin/term_output.rb

@@ -3,7 +3,7 @@ require 'base64'
 module Lolcommits
   module Plugin
     class TermOutput < Base
-      def run_captureready
+      def run_capture_ready
         if terminal_supported?
           if !runner.vcs_info || runner.vcs_info.repo.empty?
             debug 'repo is empty, skipping term output'
@@ -21,7 +21,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
 
       def configure_options!

data/lib/lolcommits/plugin/uploldz.rb

@@ -6,7 +6,7 @@ module Lolcommits
     class Uploldz < Base
       attr_accessor :endpoint
 
-      def initialize(runner)
+      def initialize(runner: nil, config: nil)
         super
         options.concat(
           %w(
@@ -18,7 +18,7 @@ module Lolcommits
         )
       end
 
-      def run_captureready
+      def run_capture_ready
         if !runner.vcs_info || runner.vcs_info.repo.empty?
           puts 'Repo is empty, skipping upload'
         else
@@ -58,7 +58,7 @@ module Lolcommits
       end
 
       def self.runner_order
-        :captureready
+        :capture_ready
       end
     end
   end

data/lib/lolcommits/plugin_manager.rb

@@ -19,7 +19,11 @@ module Lolcommits
     end
 
     def plugins_for(position)
-      plugin_klasses.select { |p| Array(p.runner_order).include?(position) }
+      plugin_klasses.select do |p|
+        # TODO: remove (legacy support) position munging after 0.9.5 release
+        Array(p.runner_order).include?(position) ||
+          Array(p.runner_order).include?(position.to_s.delete('_').to_sym)
+      end
     end
 
     # @return [Lolcommits::Plugin] find first plugin matching name

data/lib/lolcommits/runner.rb

@@ -29,8 +29,8 @@ module Lolcommits
     # now we're just using a simple procedural list
     def run
       # do plugins that need to happen before capture
-      plugin_manager.plugins_for(:precapture).each do |plugin|
-        plugin.new(self).execute_precapture
+      plugin_manager.plugins_for(:pre_capture).each do |plugin|
+        plugin.new(runner: self).execute_pre_capture
       end
 
       # do main capture to snapshot_loc
@@ -41,14 +41,14 @@ module Lolcommits
         ## resize snapshot first
         resize_snapshot!
 
-        # execute postcapture plugins, use to alter the capture
-        plugin_manager.plugins_for(:postcapture).each do |plugin|
-          plugin.new(self).execute_postcapture
+        # execute post_capture plugins, use to alter the capture
+        plugin_manager.plugins_for(:post_capture).each do |plugin|
+          plugin.new(runner: self).execute_post_capture
         end
 
-        # execute captureready plugins, capture is ready for export/sharing
-        plugin_manager.plugins_for(:captureready).each do |plugin|
-          plugin.new(self).execute_captureready
+        # execute capture_ready plugins, capture is ready for export/sharing
+        plugin_manager.plugins_for(:capture_ready).each do |plugin|
+          plugin.new(runner: self).execute_capture_ready
         end
 
         # clean away any tmp files

data/lib/lolcommits/version.rb

@@ -1,4 +1,4 @@
 module Lolcommits
-  VERSION  = '0.9.4'.freeze
+  VERSION  = '0.9.5.pre1'.freeze
   GEM_NAME = 'lolcommits'.freeze
 end

data/lolcommits.gemspec

@@ -18,6 +18,26 @@ Gem::Specification.new do |s|
   developers. `git blame` has never been so much fun.
   EOF
 
+  s.post_install_message = <<-EOF
+  -------------------------------------------------------------------------------
+
+  Lolcommits: quick message from the dev team! v0.9.5 extracts the Twitter plugin
+  into a gem. If you want to continue tweeting your lol's install and configure
+  the lolcommits-twitter gem - like this;
+
+    gem install lolcommits-twitter
+    lolcommits --config -p twitter
+    # confirm PIN, options and there's one new setting to auto-open the tweet URL
+
+  That's it! You can revoke the old Lolcommits app token from here:
+
+    https://twitter.com/settings/applications
+
+  Happy Lol'ing!
+
+  -------------------------------------------------------------------------------
+EOF
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = 'lolcommits'
@@ -42,7 +62,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('git', '~> 1.3.0')
 
   # built-in lolcommits plugin
-  s.add_runtime_dependency('lolcommits-loltext')
+  s.add_runtime_dependency('lolcommits-loltext') # TODO: add min 0.0.4
 
   # plugin gems
   s.add_runtime_dependency('yam', '~> 2.5.0')            # yammer

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.5.pre1
 platform: ruby
 authors:
 - Matthew Rothenberg
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-17 00:00:00.000000000 Z
+date: 2017-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aruba
@@ -373,7 +373,6 @@ files:
 - lib/lolcommits/plugin/lol_protonet.rb
 - lib/lolcommits/plugin/lol_slack.rb
 - lib/lolcommits/plugin/lol_tumblr.rb
-- lib/lolcommits/plugin/lol_twitter.rb
 - lib/lolcommits/plugin/lol_yammer.rb
 - lib/lolcommits/plugin/lolsrv.rb
 - lib/lolcommits/plugin/term_output.rb
@@ -387,7 +386,6 @@ files:
 - lolcommits.gemspec
 - test/images/test_image.jpg
 - test/lolcommits_test.rb
-- test/plugins_test.rb
 - vendor/ext/CommandCam/COPYING
 - vendor/ext/CommandCam/CommandCam.exe
 - vendor/ext/CommandCam/LICENSE
@@ -398,7 +396,24 @@ homepage: http://mroth.github.com/lolcommits/
 licenses:
 - LGPL-3
 metadata: {}
-post_install_message: 
+post_install_message: |2
+    -------------------------------------------------------------------------------
+
+    Lolcommits: quick message from the dev team! v0.9.5 extracts the Twitter plugin
+    into a gem. If you want to continue tweeting your lol's install and configure
+    the lolcommits-twitter gem - like this;
+
+      gem install lolcommits-twitter
+      lolcommits --config -p twitter
+      # confirm PIN, options and there's one new setting to auto-open the tweet URL
+
+    That's it! You can revoke the old Lolcommits app token from here:
+
+      https://twitter.com/settings/applications
+
+    Happy Lol'ing!
+
+    -------------------------------------------------------------------------------
 rdoc_options: []
 require_paths:
 - lib
@@ -409,9 +424,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements:
 - imagemagick
 - a webcam

data/lib/lolcommits/plugin/lol_twitter.rb

@@ -1,176 +0,0 @@
-require 'yaml'
-require 'oauth'
-require 'simple_oauth'
-require 'rest_client'
-require 'addressable/uri'
-
-module Lolcommits
-  module Plugin
-    class LolTwitter < Base
-      TWITTER_API_ENDPOINT         = 'https://api.twitter.com'.freeze
-      TWITTER_CONSUMER_KEY         = 'qc096dJJCxIiqDNUqEsqQ'.freeze
-      TWITTER_CONSUMER_SECRET      = 'rvjNdtwSr1H0TvBvjpk6c4bvrNydHmmbvv7gXZQI'.freeze
-      TWITTER_RESERVED_MEDIA_CHARS = 24
-      TWITTER_RETRIES              = 2
-      TWITTER_PIN_REGEX            = /^\d{4,}$/ # 4 or more digits
-      DEFAULT_SUFFIX               = '#lolcommits'.freeze
-
-      def run_captureready
-        tweet = build_tweet(runner.message)
-
-        attempts = 0
-        begin
-          attempts += 1
-          puts "Tweeting: #{tweet}"
-          debug "--> Tweeting! (attempt: #{attempts}, tweet length: #{tweet.length} chars)"
-          post_tweet(tweet, File.open(runner.main_image, 'r'))
-        rescue StandardError => e
-          debug "Tweet FAILED! #{e.class} - #{e.message}"
-          retry if attempts < TWITTER_RETRIES
-          puts "ERROR: Tweet FAILED! (after #{attempts} attempts) - #{e.message}"
-        end
-      end
-
-      def post_url
-        # TODO: this endpoint is deprecated, use the new approach instead
-        # https://dev.twitter.com/rest/reference/post/statuses/update_with_mediath_media
-        @post_url ||= TWITTER_API_ENDPOINT + '/1.1/statuses/update_with_media.json'
-      end
-
-      def post_tweet(status, media)
-        RestClient.post(
-          post_url,
-          {
-            'media[]' => media,
-            'status'  => status
-          }, Authorization: oauth_header
-        )
-      end
-
-      def build_tweet(commit_message)
-        prefix = config_with_default('prefix', '')
-        suffix = " #{config_with_default('suffix', DEFAULT_SUFFIX)}"
-        prefix = "#{prefix} " unless prefix.empty?
-
-        available_commit_msg_size = max_tweet_size - (prefix.length + suffix.length)
-        if commit_message.length > available_commit_msg_size
-          commit_message = "#{commit_message[0..(available_commit_msg_size - 3)]}..."
-        end
-
-        "#{prefix}#{commit_message}#{suffix}"
-      end
-
-      def configure_options!
-        options = super
-        # ask user to configure tokens if enabling
-        if options['enabled']
-          auth_config = configure_auth!
-          return unless auth_config
-          options = options.merge(auth_config).merge(configure_prefix_suffix)
-        end
-        options
-      end
-
-      def configure_auth!
-        puts '---------------------------'
-        puts 'Need to grab twitter tokens'
-        puts '---------------------------'
-
-        request_token = oauth_consumer.get_request_token
-        rtoken        = request_token.token
-        rsecret       = request_token.secret
-
-        print "\n1) Please open this url in your browser to get a PIN for lolcommits:\n\n"
-        puts request_token.authorize_url
-        print "\n2) Enter PIN, then press enter: "
-        twitter_pin = gets.strip.downcase.to_s
-
-        unless twitter_pin =~ TWITTER_PIN_REGEX
-          puts "\nERROR: '#{twitter_pin}' is not a valid Twitter Auth PIN"
-          return
-        end
-
-        begin
-          debug "Requesting Twitter OAuth Token with PIN: #{twitter_pin}"
-          OAuth::RequestToken.new(oauth_consumer, rtoken, rsecret)
-          access_token = request_token.get_access_token(oauth_verifier: twitter_pin)
-        rescue OAuth::Unauthorized
-          puts "\nERROR: Twitter PIN Auth FAILED!"
-          return
-        end
-
-        return unless access_token.token && access_token.secret
-        puts ''
-        puts '------------------------------'
-        puts 'Thanks! Twitter Auth Succeeded'
-        puts '------------------------------'
-        {
-          'access_token' => access_token.token,
-          'secret'       => access_token.secret
-        }
-      end
-
-      def configure_prefix_suffix
-        print "\n3) Prefix all tweets with something? e.g. @user (leave blank for no prefix): "
-        prefix = gets.strip
-        print "\n4) End all tweets with something? e.g. #hashtag (leave blank for default suffix #{DEFAULT_SUFFIX}): "
-        suffix = gets.strip
-
-        config = {}
-        config['prefix'] = prefix unless prefix.empty?
-        config['suffix'] = suffix unless suffix.empty?
-        config
-      end
-
-      def configured?
-        !configuration['enabled'].nil? &&
-          configuration['access_token'] &&
-          configuration['secret']
-      end
-
-      def oauth_header
-        uri = Addressable::URI.parse(post_url)
-        SimpleOAuth::Header.new(:post, uri, {}, oauth_credentials)
-      end
-
-      def oauth_credentials
-        {
-          consumer_key: TWITTER_CONSUMER_KEY,
-          consumer_secret: TWITTER_CONSUMER_SECRET,
-          token: configuration['access_token'],
-          token_secret: configuration['secret']
-        }
-      end
-
-      def oauth_consumer
-        @oauth_consumer ||= OAuth::Consumer.new(
-          TWITTER_CONSUMER_KEY,
-          TWITTER_CONSUMER_SECRET,
-          site: TWITTER_API_ENDPOINT,
-          request_endpoint: TWITTER_API_ENDPOINT,
-          sign_in: true
-        )
-      end
-
-      def config_with_default(key, default = nil)
-        if configuration[key]
-          configuration[key].strip.empty? ? default : configuration[key]
-        else
-          default
-        end
-      end
-
-      def max_tweet_size
-        139 - TWITTER_RESERVED_MEDIA_CHARS
-      end
-
-      def self.name
-        'twitter'
-      end
-
-      def self.runner_order
-        :captureready
-      end
-    end
-  end
-end

data/test/plugins_test.rb

@@ -1,40 +0,0 @@
-require 'coveralls'
-Coveralls.wear!
-
-require 'minitest/autorun'
-require 'ffaker'
-
-# Loads lolcommits directly from the lib folder so don't have to create
-# a gem before testing
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'lolcommits'
-
-include Lolcommits
-
-class PluginsTest < MiniTest::Test
-  def test_lol_twitter_build_tweet
-    # issue #136, https://github.com/mroth/lolcommits/issues/136
-    long_commit_message = FFaker::Lorem.sentence(500)
-    plugin              = Lolcommits::Plugin::LolTwitter.new(nil)
-    max_tweet_size      = 116
-    suffix              = '... #lolcommits'
-
-    Lolcommits::Plugin::LolTwitter.send(:define_method, :max_tweet_size, proc { max_tweet_size })
-    Lolcommits::Plugin::LolTwitter.send(:define_method, :configuration, proc { {} })
-    assert_equal "#{long_commit_message[0..(max_tweet_size - suffix.length)]}#{suffix}", plugin.build_tweet(long_commit_message)
-  end
-
-  def test_lol_twitter_prefix_suffix
-    plugin = Lolcommits::Plugin::LolTwitter.new(nil)
-    Lolcommits::Plugin::LolTwitter.send(:define_method, :max_tweet_size, proc { 116 })
-    assert_match 'commit msg #lolcommits', plugin.build_tweet('commit msg')
-
-    plugin_config = {
-      'prefix' => '@prefixing!',
-      'suffix' => '#suffixing!'
-    }
-    Lolcommits::Plugin::LolTwitter.send(:define_method, :configuration, proc { plugin_config })
-    assert_equal '@prefixing! commit msg #suffixing!', plugin.build_tweet('commit msg')
-  end
-end