lolcommits 0.6.3 → 0.6.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZDJlMjIwMmYyYzE3OTAxZGNmMzk4Nzc0NWY2YjRkZGUzMWE1YjBhMg==
+    MTQ5MmRhOGIwMTQxNjczMTkwZmMxZWE1ZjdkNTJjNTc0OTcxNzM2Mg==
   data.tar.gz: !binary |-
-    MTJhYmJmZDMyOGYzYzMyNjY1NTdhMGNkODhmMzA5YTkxYmUxYzE1ZQ==
+    ODNkMmIxMDYzYjlmNmUyYjZjOTI3OGI2MGNhOWRmZDM5ZTUwZTRkYQ==
 SHA512:
   metadata.gz: !binary |-
-    ZGUyYTVhMmIzOTFjNWZiZDU3MzY0MjZmOWY2NWY4ODIyOTkxYTNkODM5YjEz
-    NzA5Yzc0ZWIxZmRmOTZiNTZhZjNmOGNkYTUxYTFiMzVjNjA2MmRhNjQyMGI4
-    MWVlMDE5YzNkMGI3YTdjZDUxYWFlOWRiMmYwNTJkZDdhNTdiY2Q=
+    NDgxMTJlYWM3ZjEyOTBjZTEwZmExMTA0ZDZjMmU0MGM3MDk3ZTI1ZTc5NDkz
+    ZDhiMzEzZTBjMmJlZjMzOGI0YTViYjI4MGY3ZWE0YTA4MDg3OTFkNzU2ZTg5
+    Y2FhMmJmODhkN2U0OGVhNjY0MzcxODEyOWUxMDU1MzcxZWI1MWM=
   data.tar.gz: !binary |-
-    ZGE4OWYxYTg4OGZiNGFmY2E3Y2FlMjRjN2MzMzNlMmQ1NTE3MTRhOGZiNWVj
-    NmM2M2M3N2IwM2FlNjhhNmM0MjJhZjRjNDdjOGFjMzA0NzdkMjNiNGRjOWE0
-    Nzk0MGY3MWU0Yjg0NDY0ZTNmMGY2NzMyMGEwY2VhYzY3MzYwMGU=
+    OWM3YTRkMzFkZGJiNmQ4MDM2OTUzZWEwZDA3MThiZDBkNTNlYmJlN2U4ZmFl
+    MGQwNmQ4NWU0MzdlNTk4M2I4N2U5OGJiODNmMjg5MDc3ODk2Y2NiYzU3ZjVj
+    NjcyZjA2YjZkZTZkMjg1ZDY1M2MwZTJiOGE4ZTg1NjQ4NDAzM2U=

data/CHANGELOG.md

@@ -1,7 +1,10 @@
 ### Version History
 
 0.7.0 (WIP)
-  * extract plugins to seperate gems ...
+  * extract plugins to separate gems ...
+
+0.6.4 (15 March 2016)
+  * Add quotes to correctly handle paths with spaces (@matthutchinson #298)
 
 0.6.3 (14 March 2016)
   * Add quotes to correctly handle paths with spaces (@pedrocunha #296)

data/lib/lolcommits/capturer/capture_linux_animated.rb

@@ -18,10 +18,12 @@ module Lolcommits
       delay = frame_delay(fps, skip)
       debug "Capturer: anaimated gif choosing every #{skip} frames with a frame delay of #{delay}"
 
-      # create the looping animated gif from frames (picks nth frame with seq)
-      seq_command = "seq -f \"#{frames_location}/%09g.png\" 1 #{skip} #{Dir["#{frames_location}/*"].length}"
+      # create the looping animated gif from frames (picks nth frame with seq,
+      # quotes output and concats to a single line with tr)
+      seq_command = "seq -f \"\\\"#{frames_location}/%09g.png\\\"\" 1 #{skip} #{Dir["#{frames_location}/*"].length} | tr '\\n' ' '"
+      seq_frame_files = system_call(seq_command, true)
       # convert to animated gif with delay and gif optimisation
-      system_call "convert -layers OptimizeTransparency -delay #{delay} -loop 0 `#{seq_command}` -coalesce \"#{snapshot_location}\" > /dev/null"
+      system_call "convert -layers OptimizeTransparency -delay #{delay} -loop 0 #{seq_frame_files} -coalesce \"#{snapshot_location}\""
     end
 
     private
@@ -39,7 +41,7 @@ module Lolcommits
 
     def video_fps(file)
       # inspect fps of the captured video file (default to 29.97)
-      fps = system_call("ffmpeg -i #{file} 2>&1 | sed -n \"s/.*, \\(.*\\) fp.*/\\1/p\"", true)
+      fps = system_call("ffmpeg -i \"#{file}\" 2>&1 | sed -n \"s/.*, \\(.*\\) fp.*/\\1/p\"", true)
       fps.to_i < 1 ? 29.97 : fps.to_f
     end
 

data/lib/lolcommits/capturer/capture_mac_animated.rb

@@ -19,10 +19,12 @@ module Lolcommits
       delay = frame_delay(fps, skip)
       debug "Capturer: animated gif choosing every #{skip} frames with a frame delay of #{delay}"
 
-      # create the looping animated gif from frames (picks nth frame with seq)
-      seq_command = "seq -f \"#{frames_location}/%09g.png\" 1 #{skip} #{Dir["#{frames_location}/*"].length}"
+      # create the looping animated gif from frames (picks nth frame with seq,
+      # quotes output and concats to a single line with tr)
+      seq_command = "seq -f \"\\\"#{frames_location}/%09g.png\\\"\" 1 #{skip} #{Dir["#{frames_location}/*"].length} | tr '\\n' ' '"
+      seq_frame_files = system_call(seq_command, true)
       # convert to animated gif with delay and gif optimisation
-      system_call "convert -layers OptimizeTransparency -delay #{delay} -loop 0 `#{seq_command}` -coalesce \"#{snapshot_location}\""
+      system_call "convert -layers OptimizeTransparency -delay #{delay} -loop 0 #{seq_frame_files} -coalesce \"#{snapshot_location}\" > /dev/null"
     end
 
     def executable_path
@@ -44,7 +46,7 @@ module Lolcommits
 
     def video_fps(file)
       # inspect fps of the captured video file (default to 29.97)
-      fps = system_call("ffmpeg -i #{file} 2>&1 | sed -n \"s/.*, \\(.*\\) fp.*/\\1/p\"", true)
+      fps = system_call("ffmpeg -i \"#{file}\" 2>&1 | sed -n \"s/.*, \\(.*\\) fp.*/\\1/p\"", true)
       fps.to_i < 1 ? 29.97 : fps.to_f
     end
 

data/lib/lolcommits/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module Lolcommits
-  VERSION = '0.6.3'.freeze
+  VERSION = '0.6.4'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - Matthew Rothenberg
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-14 00:00:00.000000000 Z
+date: 2016-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client