lolcommits-yammer 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c9ea8f74e12842296bf334f8a99ee029b043e439
-  data.tar.gz: f384e0024ed3b5ddd79fecd2453250b868b37717
+SHA256:
+  metadata.gz: 266f3f5b30c81456ccda01ed9d3c68d50f493d687ca468e780b4b34c4fc641cb
+  data.tar.gz: 7a27ba82818b97f7162943795f850fb8f61088d98099fb073da10db45ed7eabf
 SHA512:
-  metadata.gz: a06deed14f85544ecd2a546186e3052a56807493e49c3f4bc17c2f8dfda94a689dd9860e867d7867dccd05eee2ef4355a1a76de2188cfb1329484bc3d0cdec9e
-  data.tar.gz: c7492621ce2a83620a561aa95bc879ea808c9d51574e662cb424819ec96bfb822e2cc87e2bb6bf68c0031edab7f68f0cc279c8c36fa0c55977205422764c258e
+  metadata.gz: d35905e72761615ab8351182a2a3c2578f710f5dc8a646f12511db85c8c4d24784c1a48f8cb16ed14f041241562bcd901c42a11e686029553a7040939c384d73
+  data.tar.gz: be7f0bbdb92719617cc4b9454a6af412bb5fbee7e82adba4f6c7277787d954ad3b2ae609f68faaf5adcbcf05678aac93f8b36e29524d2f0d69954471521b6cfc

data/.travis.yml

@@ -2,18 +2,19 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
- - 2.0.0
- - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
- - ruby-head
+  - 2.0.0
+  - 2.1.10
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
+  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
- - git --version
- - git config --global user.email "lol@commits.org"
- - git config --global user.name "Lolcommits"
+  - gem update --system
+  - git --version
+  - git config --global user.email "lol@commits.org"
+  - git config --global user.name "Lolcommits"
 
 matrix:
   allow_failures:

data/lib/lolcommits/plugin/yammer.rb

@@ -15,15 +15,6 @@ module Lolcommits
       OAUTH_REDIRECT_PORT = 5429
       OAUTH_REDIRECT_URL  = "http://localhost:#{OAUTH_REDIRECT_PORT}".freeze
 
-      ##
-      # Returns the name of the plugin.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'yammer'
-      end
-
       ##
       # Returns position(s) of when this plugin should run during the capture
       # process. Posting to Yammer happens when a new capture is ready.
@@ -35,13 +26,13 @@ module Lolcommits
       end
 
       ##
-      # Returns true if the plugin has been configured.
-      #
-      # @return [Boolean] true/false indicating if plugin has been configured.
+      # Returns true if the plugin has been configured correctly.
       # The access_token must be set.
       #
-      def configured?
-        !configuration['access_token'].nil?
+      # @return [Boolean] true/false
+      #
+      def valid_configuration?
+        !configuration[:access_token].nil?
       end
 
       ##
@@ -56,13 +47,13 @@ module Lolcommits
       #
       def configure_options!
         options = super
-        if options['enabled']
+        if options[:enabled]
           oauth_access_token = fetch_access_token
           if oauth_access_token
-            options.merge!('access_token' => oauth_access_token)
+            options.merge!(access_token: oauth_access_token)
           else
             puts "Aborting.. Plugin disabled since Yammer Oauth was denied"
-            options['enabled'] = false
+            options[:enabled] = false
           end
         end
         options
@@ -80,7 +71,7 @@ module Lolcommits
         response = RestClient.post(
           "https://www.yammer.com/api/v1/messages",
           { body: yammer_message, attachment1: File.new(runner.main_image) },
-          { 'Authorization' => "Bearer #{configuration["access_token"]}" }
+          { 'Authorization' => "Bearer #{configuration[:access_token]}" }
         )
 
         if response.code != 201

data/lib/lolcommits/yammer/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Yammer
-    VERSION = "0.0.4".freeze
+    VERSION = "0.0.5".freeze
   end
 end

data/lolcommits-yammer.gemspec

@@ -38,7 +38,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "rest-client"
   spec.add_runtime_dependency "webrick"
 
-  spec.add_development_dependency "lolcommits", ">= 0.9.5"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "pry"

data/test/lolcommits/plugin/yammer_test.rb

@@ -6,14 +6,6 @@ describe Lolcommits::Plugin::Yammer do
   include Lolcommits::TestHelpers::GitRepo
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    "yammer"
-  end
-
-  it "should have a name" do
-    ::Lolcommits::Plugin::Yammer.name.must_equal plugin_name
-  end
-
   it "should run on capture ready" do
     ::Lolcommits::Plugin::Yammer.runner_order.must_equal [:capture_ready]
   end
@@ -22,11 +14,7 @@ describe Lolcommits::Plugin::Yammer do
     def runner
       # a simple lolcommits runner with an empty configuration Hash
       @runner ||= Lolcommits::Runner.new(
-        main_image: Tempfile.new('main_image.jpg'),
-        config: OpenStruct.new(
-          read_configuration: {},
-          loldir: File.expand_path("#{__dir__}../../../images")
-        )
+        main_image: Tempfile.new('main_image.jpg')
       )
     end
 
@@ -35,30 +23,26 @@ describe Lolcommits::Plugin::Yammer do
     end
 
     def valid_enabled_config
-      @config ||= OpenStruct.new(
-        read_configuration: {
-          "yammer" => {
-            "enabled" => true,
-            "access_token" => "oV4MuwnNKql3ebJMAYZRaD"
-          }
-        }
-      )
+      {
+        enabled: true,
+        access_token: "oV4MuwnNKql3ebJMAYZRaD"
+      }
     end
 
     describe "#enabled?" do
       it "is false by default" do
-        plugin.enabled?.must_equal false
+        assert_nil plugin.enabled?
       end
 
       it "is true when configured" do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
 
     describe "run_capture_ready" do
       before do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         commit_repo_with_message("first commit!")
       end
 
@@ -96,13 +80,16 @@ describe Lolcommits::Plugin::Yammer do
     end
 
     describe "configuration" do
-      it "returns false when not configured" do
-        plugin.configured?.must_equal false
-      end
 
-      it "returns true when configured" do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
+      describe "#valid_configuration?" do
+        it "returns false when not configured correctly" do
+          plugin.valid_configuration?.must_equal false
+        end
+
+        it "returns true when configured" do
+          plugin.configuration = valid_enabled_config
+          plugin.valid_configuration?.must_equal true
+        end
       end
 
       describe "configuring with Yammer Oauth" do
@@ -127,7 +114,7 @@ describe Lolcommits::Plugin::Yammer do
             "Aborting.. Plugin disabled since Yammer Oauth was denied"
           )
 
-          configured_plugin_options.must_equal({ "enabled" => false })
+          configured_plugin_options.must_equal({ enabled: false })
         end
 
         it "configures successfully with a Yammer Oauth access token" do
@@ -158,8 +145,8 @@ describe Lolcommits::Plugin::Yammer do
           end
 
           configured_plugin_options.must_equal({
-            "enabled" => true,
-            "access_token" => "yam-oauth-token"
+            enabled: true,
+            access_token: "yam-oauth-token"
           })
         end
       end

data/test/test_helper.rb

@@ -1,10 +1,7 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-# necessary libs from lolcommits (allowing plugin to run)
-require 'git'
-require 'lolcommits/runner'
-require 'lolcommits/vcs_info'
-require 'lolcommits/backends/git_info'
+# lolcommits gem
+require 'lolcommits'
 
 # lolcommit test helpers
 require 'lolcommits/test_helpers/git_repo'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-yammer
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -183,7 +183,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Uploads lolcommits to Yammer