lolcommits-twitter 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c2e6ca5a48db6a374a75549ac5c71511ad261da1
-  data.tar.gz: bd3cf98cbb1c1e54cfbb3aa0a3ee84d541ad1beb
+SHA256:
+  metadata.gz: dda1729a3916ac1f7b263e100d3cfa6fe44b77059b0f0a06233bd392b57d9b4c
+  data.tar.gz: ea083a54e32198bf114c652442055e1b9377822ee9fcc08c7c035e6ea43ceb01
 SHA512:
-  metadata.gz: 045f56f6322053db7d13f2f1b0973fc87aed5b0628fab3e749a0c60b6a39ae89b3dc8038f4c6ffc2a8ac1a464752b3867b915d21d2954e245f766e49d0f43d17
-  data.tar.gz: f9a762e2c0c8a917600b72e811472600aec9b94d17f79d5189bbc91db3cb6560aa7e1f7fe43ba113fdcdb75f7a8f6f48aefd004ab4936906766695ae0577ff58
+  metadata.gz: abfce6434ffe7c021a432ef3575c72fa56941e23f830ccac62bf0c164627eced124a1f6ffccedfb565d8e4931392c30449afa559aa3f3a68cf3962e143b1be1d
+  data.tar.gz: e8e23a6cf2ae6d80e411bc7ab829cfbef8a006ef0873c906acfe6b88a95c9a3a2a8942368a9325046caba04ff90ae94fdc50dafd92338d98157f32a2fd7b8cba

data/.travis.yml

@@ -2,18 +2,19 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
- - 2.0.0
- - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
- - ruby-head
+  - 2.0.0
+  - 2.1.10
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
+  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
- - git --version
- - git config --global user.email "lol@commits.org"
- - git config --global user.name "Lolcommits"
+  - gem update --system
+  - git --version
+  - git config --global user.email "lol@commits.org"
+  - git config --global user.name "Lolcommits"
 
 matrix:
   allow_failures:

data/lib/lolcommits/plugin/twitter.rb

@@ -8,15 +8,6 @@ module Lolcommits
 
       DEFAULT_SUFFIX  = '#lolcommits'.freeze
 
-      ##
-      # Returns the name of the plugin. Identifies the plugin to lolcommits.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'twitter'
-      end
-
       ##
       # Returns position(s) of when this plugin should run during the capture
       # process. We want to post to Twitter when the capture is ready (after all
@@ -29,12 +20,12 @@ module Lolcommits
       end
 
       ##
-      # Plugin is configured when a token and token secret exist
+      # Indicate if the plugin is configured correctly.
       #
-      # @return [Boolean] true/false if the plugin has been configured
+      # @return [Boolean] true/false
       #
-      def configured?
-        !!(configuration['token'] && configuration['token_secret'])
+      def valid_configuration?
+        !!(configuration[:token] && configuration[:token_secret])
       end
 
       ##
@@ -46,7 +37,7 @@ module Lolcommits
       def configure_options!
         options = super
         # ask user to configure all options (if enabling)
-        if options['enabled']
+        if options[:enabled]
           auth_config = configure_auth!
           return unless auth_config
           options = options.merge(auth_config).
@@ -74,8 +65,8 @@ module Lolcommits
 
         begin
           client = twitter_client.new(
-            configuration['token'],
-            configuration['token_secret']
+            configuration[:token],
+            configuration[:token_secret]
           )
 
           debug "--> Uploading media (#{file.size} bytes)"
@@ -85,7 +76,7 @@ module Lolcommits
 
           tweet_url = status_response['entities']['media'][0]['url']
           print "#{tweet_url}\n"
-          open_url(tweet_url) if configuration['open_tweet_url']
+          open_url(tweet_url) if configuration[:open_tweet_url]
         rescue StandardError => e
           puts "ERROR: Tweeting FAILED! - #{e.message}"
         end
@@ -98,10 +89,10 @@ module Lolcommits
       end
 
       def build_tweet(commit_message)
-        prefix = configuration['prefix'].to_s
-        suffix = configuration['suffix'].to_s
-        prefix = "#{configuration['prefix']} " unless prefix.empty?
-        suffix = " #{configuration['suffix']}" unless suffix.empty?
+        prefix = configuration[:prefix].to_s
+        suffix = configuration[:suffix].to_s
+        prefix = "#{configuration[:prefix]} " unless prefix.empty?
+        suffix = " #{configuration[:suffix]}" unless suffix.empty?
 
         available_commit_msg_size = twitter_client::MAX_TWEET_CHARS - (prefix.length + suffix.length)
         if commit_message.length > available_commit_msg_size
@@ -118,9 +109,9 @@ module Lolcommits
       end
 
       def configure_auth!
-        if configured?
+        if valid_configuration?
           print "\n* Reset Twitter Auth ? (y/N): "
-          return configuration.select {|k,v| k =~ /^token/ } if !ask_yes_or_no?
+          return configuration.select {|k,v| k.to_s =~ /^token/ } if !ask_yes_or_no?
         end
 
         puts ''
@@ -129,8 +120,6 @@ module Lolcommits
         puts '-----------------------------------'
 
         request_token = twitter_client.oauth_consumer.get_request_token
-        rtoken        = request_token.token
-        rsecret       = request_token.secret
         authorize_url = request_token.authorize_url
 
         open_url(authorize_url)
@@ -156,8 +145,8 @@ module Lolcommits
         puts '-----------------------------------'
 
         {
-          'token'        => access_token.token,
-          'token_secret' => access_token.secret
+          token: access_token.token,
+          token_secret: access_token.secret
         }
       end
 
@@ -168,14 +157,14 @@ module Lolcommits
         suffix = gets.strip
 
         config = {}
-        config['prefix'] = prefix.empty? ? '' : prefix
-        config['suffix'] = suffix.empty? ? DEFAULT_SUFFIX : suffix
+        config[:prefix] = prefix.empty? ? '' : prefix
+        config[:suffix] = suffix.empty? ? DEFAULT_SUFFIX : suffix
         config
       end
 
       def configure_open_tweet_url
         print "\n* Automatically open Tweet URL after posting (y/N): "
-        { 'open_tweet_url' => ask_yes_or_no? }
+        { open_tweet_url:  ask_yes_or_no? }
       end
 
       def open_url(url)

data/lib/lolcommits/twitter/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Twitter
-    VERSION = "0.0.4".freeze
+    VERSION = "0.0.5".freeze
   end
 end

data/lolcommits-twitter.gemspec

@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "simple_oauth"
   spec.add_runtime_dependency "addressable"
 
-  spec.add_development_dependency "lolcommits", ">= 0.9.5"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest"

data/test/lolcommits/plugin/twitter_test.rb

@@ -4,36 +4,21 @@ describe Lolcommits::Plugin::Twitter do
 
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    'twitter'
-  end
-
-  it 'should have a name' do
-    ::Lolcommits::Plugin::Twitter.name.must_equal plugin_name
-  end
-
   it 'should run on post capturing' do
     ::Lolcommits::Plugin::Twitter.runner_order.must_equal [:capture_ready]
   end
 
   describe 'with a runner' do
     def runner
-      # a simple lolcommits runner with an empty configuration Hash
-      @_runner ||= Lolcommits::Runner.new(
-        config: OpenStruct.new(read_configuration: {})
-      )
+      @_runner ||= Lolcommits::Runner.new
     end
 
     def valid_enabled_config
-      @_valid_enabled_config ||= OpenStruct.new(
-        read_configuration: {
-          plugin.class.name => {
-            'enabled'      => true,
-            'token'        => 'abc-xyz',
-            'token_secret' => '123XYZ'
-          }
-        }
-      )
+      {
+        enabled: true,
+        token: 'abc-xyz',
+        token_secret: '123XYZ'
+      }
     end
 
     def plugin
@@ -44,32 +29,25 @@ describe Lolcommits::Plugin::Twitter do
       Lolcommits::Twitter::Client
     end
 
-    describe 'initalizing' do
-      it 'should assign runner and an enabled option' do
-        plugin.runner.must_equal runner
-        plugin.options.must_equal ['enabled']
-      end
-    end
-
     describe '#enabled?' do
       it 'should be false by default' do
-        plugin.enabled?.must_equal false
+        assert_nil plugin.enabled?
       end
 
       it 'should true when configured' do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
 
     describe 'configuration' do
-      it 'should not be configured by default' do
-        plugin.configured?.must_equal false
+      it 'should not have a valid config by default' do
+        plugin.valid_configuration?.must_equal false
       end
 
-      it 'should indicate when configured' do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
+      it 'should indicate when configured correctly' do
+        plugin.configuration = valid_enabled_config
+        plugin.valid_configuration?.must_equal true
       end
 
       it 'should allow plugin options to be configured' do
@@ -88,12 +66,12 @@ describe Lolcommits::Plugin::Twitter do
         end
 
         configured_plugin_options.must_equal({
-          'enabled'        => true,
-          'token'          => 'oauthtoken',
-          'token_secret'   => 'oauthtokensecret',
-          'prefix'         => 'LOL-prefix',
-          'suffix'         => 'LOL-suffix',
-          'open_tweet_url' => true
+          enabled: true,
+          token: 'oauthtoken',
+          token_secret: 'oauthtokensecret',
+          prefix: 'LOL-prefix',
+          suffix: 'LOL-suffix',
+          open_tweet_url: true
         })
       end
     end

data/test/test_helper.rb

@@ -1,10 +1,7 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-# necessary libs from lolcommits (allowing plugin to run)
-require 'git'
-require 'lolcommits/runner'
-require 'lolcommits/vcs_info'
-require 'lolcommits/backends/git_info'
+# lolcommits gem
+require 'lolcommits'
 
 # lolcommit test helpers
 require 'lolcommits/test_helpers/git_repo'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-twitter
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -210,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Post lolcommits to Twitter