lolcommits-protonet 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 10ea184082c909baf4a87e3f8c4b788e4671ec3c
-  data.tar.gz: 3188f2b91ba7645c6b09b16cfb7e296088c19f02
+SHA256:
+  metadata.gz: 5d5c6d6dcf571bb25ddafc41ae5e6310279d7add83e7c72180bd5235676ed78b
+  data.tar.gz: 922722865b187778e492c352deecf0e6f81888fc3ac926fb4d6598257a1bc42c
 SHA512:
-  metadata.gz: 1b7093593ae2b91500060f2e90e57cc1eaf76940d8d7ff351001cc797240a2e54fb4275a2a3cbbbf5bc9b80b4d829d5357a7f0ae69389c4d834dbe2736c5909b
-  data.tar.gz: 80647d9f8c1b785c7fff6b355987fd4dd1586394686c72eab7645af6acfe0a5876131a0f35939d1721c463667f3e08bcc7700fef14652500be763c46b1396cb1
+  metadata.gz: 052c32971e12c4ff0bfb6964a81d976befd08ebdcdd84690e2207a03566423be608ce1c8eed1d90912d97c3e0509936df13b1ae0b98468ef041b21f9f5425bf9
+  data.tar.gz: 988be000eba92897f14fce1decdf29a2534da8f7b8693ddd97b34f23fbdd1c2b129caa5fd9a3c8d62f76eedf5ac7413e136d11b43b6fc570b1484982303c4c7f

data/.travis.yml

@@ -4,13 +4,14 @@ cache: bundler
 rvm:
  - 2.0.0
  - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
+ - 2.2.9
+ - 2.3.6
+ - 2.4.3
+ - 2.5.0
  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
+ - gem update --system
  - git --version
  - git config --global user.email "lol@commits.org"
  - git config --global user.name "Lolcommits"

data/lib/lolcommits/plugin/protonet.rb

@@ -10,16 +10,7 @@ module Lolcommits
       #
       def initialize(runner: nil, config: nil)
         super
-        options.concat(plugin_options)
-      end
-
-      ##
-      # Returns the name of the plugin to identify the plugin to lolcommits.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'protonet'
+        options.concat([:api_endpoint, :api_token])
       end
 
       ##
@@ -49,18 +40,6 @@ module Lolcommits
         super
       end
 
-      ##
-      # Returns true if the plugin has been configured.
-      #
-      # @return [Boolean] true/false indicating if plugin is configured. An API
-      # token and endpoint are required.
-      #
-      def configured?
-        !!(configuration['enabled'] &&
-           configuration['api_token'] &&
-           configuration['api_endpoint'])
-      end
-
       ##
       # Post-capture hook, runs after lolcommits captures a snapshot. Posts the
       # lolcommit image with a message to the Protonet box. API Documentation
@@ -70,14 +49,14 @@ module Lolcommits
       # @return [Nil] if any error occurs
       #
       def run_capture_ready
-        debug "Posting image (and message) to #{configuration['api_endpoint']}"
+        debug "Posting image (and message) to #{configuration[:api_endpoint]}"
         RestClient.post(
-          configuration['api_endpoint'],
+          configuration[:api_endpoint],
           {
             files: [File.new(runner.main_image)],
             message: message
           },
-          'X-Protonet-Token' => configuration['api_token']
+          'X-Protonet-Token' => configuration[:api_token]
         )
       rescue => e
         log_error(e, "ERROR: RestClient POST FAILED #{e.class} - #{e.message}")
@@ -125,16 +104,6 @@ module Lolcommits
           'heartbleeding', 'juciy', 'supercalifragilisticexpialidocious', 'failing', 'loving'
         ].sample
       end
-
-      ##
-      # Returns all configuration options available for this plugin. An API
-      # endpoint and token.
-      #
-      # @return [Array] the option names
-      #
-      def plugin_options
-        %w(api_endpoint api_token)
-      end
     end
   end
 end

data/lib/lolcommits/protonet/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Protonet
-    VERSION = "0.0.2".freeze
+    VERSION = "0.0.3".freeze
   end
 end

data/lolcommits-protonet.gemspec

@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "rest-client"
 
-  spec.add_development_dependency "lolcommits", ">= 0.9.5"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "pry"

data/test/lolcommits/plugin/protonet_test.rb

@@ -5,14 +5,6 @@ describe Lolcommits::Plugin::Protonet do
   include Lolcommits::TestHelpers::GitRepo
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    "protonet"
-  end
-
-  it "should have a name" do
-    ::Lolcommits::Plugin::Protonet.name.must_equal plugin_name
-  end
-
   it "should run on capture ready" do
     ::Lolcommits::Plugin::Protonet.runner_order.must_equal [:capture_ready]
   end
@@ -22,7 +14,6 @@ describe Lolcommits::Plugin::Protonet do
       # a simple lolcommits runner with an empty configuration Hash
       @runner ||= Lolcommits::Runner.new(
         main_image: Tempfile.new('main_image.jpg'),
-        config: OpenStruct.new(read_configuration: {})
       )
     end
 
@@ -31,15 +22,11 @@ describe Lolcommits::Plugin::Protonet do
     end
 
     def valid_enabled_config
-      @config ||= OpenStruct.new(
-        read_configuration: {
-          "protonet" => {
-            "enabled" => true,
-            "api_endpoint" => api_endpoint,
-            "api_token" => "proto-token"
-          }
-        }
-      )
+      {
+        enabled: true,
+        api_endpoint: api_endpoint,
+        api_token: "proto-token"
+      }
     end
 
     def api_endpoint
@@ -49,17 +36,17 @@ describe Lolcommits::Plugin::Protonet do
     describe "initalizing" do
       it "assigns runner and all plugin options" do
         plugin.runner.must_equal runner
-        plugin.options.must_equal %w(enabled api_endpoint api_token)
+        plugin.options.must_equal [:enabled, :api_endpoint, :api_token]
       end
     end
 
     describe "#enabled?" do
       it "is false by default" do
-        plugin.enabled?.must_equal false
+        assert_nil plugin.enabled?
       end
 
       it "is true when configured" do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
@@ -70,7 +57,7 @@ describe Lolcommits::Plugin::Protonet do
 
       it "posts lolcommit with message to protonet box" do
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
 
           stub_request(:post, api_endpoint).to_return(status: 200)
 
@@ -87,7 +74,7 @@ describe Lolcommits::Plugin::Protonet do
 
       it "returns nil if an error occurs" do
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           stub_request(:post, api_endpoint).to_return(status: 501)
 
           assert_nil plugin.run_capture_ready
@@ -96,15 +83,6 @@ describe Lolcommits::Plugin::Protonet do
     end
 
     describe "configuration" do
-      it "returns false when not configured" do
-        plugin.configured?.must_equal false
-      end
-
-      it "returns true when configured" do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
-      end
-
       it "allows plugin options to be configured" do
         # enabled, api endpoint, api token
         inputs = %W(true #{api_endpoint} proto-token)
@@ -116,9 +94,9 @@ describe Lolcommits::Plugin::Protonet do
         end
 
         configured_plugin_options.must_equal({
-          "enabled"      => true,
-          "api_endpoint" => api_endpoint,
-          "api_token"    => inputs[2]
+          enabled: true,
+          api_endpoint: api_endpoint,
+          api_token: inputs[2]
         })
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-protonet
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -168,7 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Posts lolcommits to a Protonet box