lolcommits-lolsrv 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0faac8f4f97346ba5d9c9051568b7d29140e13c7
-  data.tar.gz: 471e84328f17c36894949e45b33a82e412c3d767
+SHA256:
+  metadata.gz: 468cfa2577bf86022ec68a8ee3e88a719be4940a18a773d72d3cf67282301e29
+  data.tar.gz: e24a4bb2b49ce3114ed770bec218c1cbba8b261c1fcb4f661002446659aa8f60
 SHA512:
-  metadata.gz: e21ba06befe194cd95d29423d7c21cbed06a7970ea911ecdb5eeea7772a968de2c76fb9e41503eda936480d8eb57dfa9a9093e3521b03a7b65f8617e42c70002
-  data.tar.gz: 992510e23e933834451388f9503a27daf3d65f09d3672444fb8907efd8344687c9d08a80e8806eb8220acac507f0c0dc0f74688e885b6706c41abfcfe6437c2c
+  metadata.gz: ce2ce5780a2f8eaf1ed20a19f058fac3308a04984e5a0e759e7a1a55f60cdddbd025712781963113f739df6c9b8f668f743c6b0a5de418bd71f442d933096c6f
+  data.tar.gz: 4dfdbc3dab4e21297a47e9a3d0a81159f1659ac88d0f67d10999505cd8dca12a6c02702876ea081e835d4b95b470d82ffca353660970dffa5d98349288ae376b

data/.travis.yml

@@ -4,13 +4,14 @@ cache: bundler
 rvm:
  - 2.0.0
  - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
+ - 2.2.9
+ - 2.3.6
+ - 2.4.3
+ - 2.5.0
  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
+ - gem update --system
  - git --version
  - git config --global user.email "lol@commits.org"
  - git config --global user.name "Lolcommits"

data/lib/lolcommits/lolsrv/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Lolsrv
-    VERSION = "0.0.5".freeze
+    VERSION = "0.0.6".freeze
   end
 end

data/lib/lolcommits/plugin/lolsrv.rb

@@ -5,15 +5,6 @@ module Lolcommits
   module Plugin
     class Lolsrv < Base
 
-      ##
-      # Returns the name of the plugin. Identifies the plugin to lolcommits.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'lolsrv'
-      end
-
       ##
       # Returns position(s) of when this plugin should run during the capture
       # process. Sync/uploading happens when a new capture is ready.
@@ -33,7 +24,7 @@ module Lolcommits
       # configured
       #
       def valid_configuration?
-        !!(configuration['server'] =~ /^http(s)?:\/\//)
+        !!(configuration[:server] =~ /^http(s)?:\/\//)
       end
 
       ##
@@ -43,9 +34,9 @@ module Lolcommits
       #
       def configure_options!
         options = super
-        if options['enabled']
+        if options[:enabled]
           print "server: "
-          options.merge!('server' => parse_user_input(gets.strip))
+          options.merge!(server: parse_user_input(gets.strip))
           puts '---------------------------------------------------------------'
           puts '  Lolsrv - Sync lolcommits to a remote server'
           puts ''
@@ -183,7 +174,7 @@ module Lolcommits
       # @return [String] `server` config option + '/uplol'
       #
       def upload_endpoint
-        configuration['server'] + '/uplol'
+        configuration[:server] + '/uplol'
       end
 
       ##
@@ -195,7 +186,7 @@ module Lolcommits
       # @return [String] `server` config option + '/lols'
       #
       def lols_endpoint
-        configuration['server'] + '/lols'
+        configuration[:server] + '/lols'
       end
     end
   end

data/lolcommits-lolsrv.gemspec

@@ -38,7 +38,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "rest-client"
 
-  spec.add_development_dependency "lolcommits", ">= 0.9.7"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "pry"

data/test/lolcommits/plugin/lolsrv_test.rb

@@ -6,14 +6,6 @@ describe Lolcommits::Plugin::Lolsrv do
   include Lolcommits::TestHelpers::GitRepo
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    "lolsrv"
-  end
-
-  it "should have a name" do
-    ::Lolcommits::Plugin::Lolsrv.name.must_equal plugin_name
-  end
-
   it "should run on capture ready" do
     ::Lolcommits::Plugin::Lolsrv.runner_order.must_equal [:capture_ready]
   end
@@ -24,7 +16,6 @@ describe Lolcommits::Plugin::Lolsrv do
       @runner ||= Lolcommits::Runner.new(
         main_image: Tempfile.new('main_image.jpg'),
         config: OpenStruct.new(
-          read_configuration: {},
           loldir: File.expand_path("#{__dir__}../../../images")
         )
       )
@@ -35,30 +26,19 @@ describe Lolcommits::Plugin::Lolsrv do
     end
 
     def valid_enabled_config
-      @config ||= OpenStruct.new(
-        read_configuration: {
-          "lolsrv" => {
-            "enabled" => true,
-            "server" => "https://lolsrv.com"
-          }
-        }
-      )
-    end
-
-    describe "initalizing" do
-      it "assigns runner and an enabled option" do
-        plugin.runner.must_equal runner
-        plugin.options.must_equal ["enabled"]
-      end
+      {
+        enabled: true,
+        server: "https://lolsrv.com"
+      }
     end
 
     describe "#enabled?" do
-      it "is false by default" do
-        plugin.enabled?.must_equal false
+      it "it is disabled by default" do
+        assert_nil plugin.enabled?
       end
 
       it "is true when configured" do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
@@ -72,7 +52,7 @@ describe Lolcommits::Plugin::Lolsrv do
 
       it "syncs lolcommits" do
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           existing_sha  = "sha123"
 
           stub_request(:get, "https://lolsrv.com/lols").
@@ -97,7 +77,7 @@ describe Lolcommits::Plugin::Lolsrv do
 
       it "shows error and aborts on failed lols endpoint" do
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           stub_request(:get, "https://lolsrv.com/lols").to_return(status: 404)
 
           output = fake_io_capture do
@@ -111,15 +91,6 @@ describe Lolcommits::Plugin::Lolsrv do
     end
 
     describe "configuration" do
-      it "returns false when not configured" do
-        plugin.configured?.must_equal false
-      end
-
-      it "returns true when configured" do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
-      end
-
       it "allows plugin options to be configured" do
         # enabled and server option
         inputs = ["true", "https://my-lolsrv.com"]
@@ -130,21 +101,19 @@ describe Lolcommits::Plugin::Lolsrv do
         end
 
         configured_plugin_options.must_equal({
-          "enabled" => true,
-          "server" => "https://my-lolsrv.com"
+          enabled: true,
+          server: "https://my-lolsrv.com"
         })
       end
 
       describe "#valid_configuration?" do
         it "returns false for an invalid configuration" do
-          plugin.config = OpenStruct.new(read_configuration: {
-            "lolsrv" => { "server" => "gibberish" }
-          })
+          plugin.configuration = { server: "gibberish" }
           plugin.valid_configuration?.must_equal false
         end
 
         it "returns true with a valid configuration" do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           plugin.valid_configuration?.must_equal true
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-lolsrv
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-21 00:00:00.000000000 Z
+date: 2018-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.7
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.7
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Sync lolcommits to a remote server