lol_data_fetcher 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7cf99a663e6a86de3bb2bab4aa9a2237dbe6a6fb4400429f0c0866c605472426
-  data.tar.gz: c99bb67f229a840db389e1324ace988992d8768b402d43cb5c4c913d595c36e7
+  metadata.gz: 84b940340e873c546e540b47349ceb1cae28e4503fbc0f4056226dd2d2cfe2d7
+  data.tar.gz: 5bd9d64f06def02eb3c70e168be0d2825cfcb61ec377a6296470a119abfcb15d
 SHA512:
-  metadata.gz: fbf7a156f906d9b9c2182da7c9e9da80a91acadfee7870b9cda9f7c2628ac928ebace11345d589303e47aff524919c22ba98d328ae134337044eeb31778ded02
-  data.tar.gz: 69f2a49fe2999c5706f50a9bc2b989e126ee5b3aee5158658e230c50bfa7e5b64499747a2d45b137fa69f0be6a465d627ffcaa2e5b04bc323dd17a141219b8d2
+  metadata.gz: fe02fd0be3d0413f3954143702624fc0e3c96e55cacb2c6376ebf2b72220bcc57c78fb10322060b2c6cd6438b5139d5a924ed8546a3c0c870b2729a44ac80934
+  data.tar.gz: 2bed146707485387697355cd10d51fecfb4f69c385f002062f306ceffeb5c1fea674f84b539b87a40188d77dbdf959706c09ef9961c7330557d2a555f2416933

data/README.md

@@ -7,6 +7,7 @@ A Ruby client for the League of Legends Data Dragon API. Fetch champions, items,
 - Fetch all champions with detailed information including skills/spells
 - Get all items and search by name
 - Retrieve champion skins with image URLs
+- **Case-insensitive search** for champions, items, and skins
 - Support for multiple game versions and languages
 - Command-line interface (CLI) for quick data access
 - Comprehensive test coverage with RSpec
@@ -67,12 +68,17 @@ ahri_data = ahri["data"]["Ahri"]
 puts ahri_data["name"]  # => "Ahri"
 puts ahri_data["title"] # => "the Nine-Tailed Fox"
 
+# Case-insensitive search (works with any casing!)
+client.champions.find("ahri")     # => Works!
+client.champions.find("AHRI")     # => Works!
+client.champions.find("DrAvEn")   # => Works!
+
 # Access champion's passive ability
 passive = ahri_data["passive"]
 puts "#{passive['name']}: #{passive['description']}"
 
-# Or use the helper method
-passive = client.champions.passive("Ahri")
+# Or use the helper method (also case-insensitive)
+passive = client.champions.passive("ahri")
 puts "#{passive['name']}: #{passive['description']}"
 
 # Access champion spells/skills
@@ -101,8 +107,12 @@ end
 boots = client.items.find("1001")
 puts boots["name"] # => "Boots"
 
-# Search items by name
-swords = client.items.search("sword")
+# Find item by name (case-insensitive exact match)
+boots = client.items.find_by_name("boots")  # Works with any casing
+puts boots["name"] # => "Boots"
+
+# Search items by name (case-insensitive partial match)
+swords = client.items.search("SWORD")  # Case doesn't matter
 swords.each do |item|
   puts item["name"]
 end
@@ -114,8 +124,8 @@ ids = client.items.list_ids
 #### Fetching Skins
 
 ```ruby
-# Get all skins for a specific champion
-skins = client.skins.for_champion("Ahri")
+# Get all skins for a specific champion (case-insensitive)
+skins = client.skins.for_champion("ahri")  # Works with any casing
 skins.each do |skin|
   puts skin["name"]
   puts "Splash: #{skin['splash_url']}"
@@ -272,27 +282,34 @@ client = LolDataFetcher::Client.new(version: "15.23.1", language: "en_US")
 
 ### Champions Resource
 
+All champion name searches are **case-insensitive**.
+
 ```ruby
 client.champions.all                  # Get all champions (overview)
-client.champions.find("Ahri")         # Get detailed champion data
-client.champions.passive("Ahri")      # Get champion's passive ability
+client.champions.find("ahri")         # Get detailed champion data (case-insensitive)
+client.champions.passive("AHRI")      # Get champion's passive ability (case-insensitive)
 client.champions.list_names           # List all champion names
 client.champions.find_by_id("103")    # Find champion by ID
 ```
 
 ### Items Resource
 
+Item searches are **case-insensitive**.
+
 ```ruby
 client.items.all                      # Get all items
 client.items.find("1001")             # Find item by ID
+client.items.find_by_name("boots")    # Find item by name (case-insensitive)
 client.items.list_ids                 # List all item IDs
-client.items.search("sword")          # Search items by name
+client.items.search("SWORD")          # Search items by name (case-insensitive)
 ```
 
 ### Skins Resource
 
+Champion name searches are **case-insensitive**.
+
 ```ruby
-client.skins.for_champion("Ahri")     # Get skins for a champion
+client.skins.for_champion("ahri")     # Get skins for a champion (case-insensitive)
 ```
 
 ### Versions Resource

data/lib/lol_data_fetcher/cli.rb

@@ -51,7 +51,10 @@ module LolDataFetcher
       client = create_client
       data = client.champions.find(name)
 
-      champion_data = data.dig("data", name)
+      # Extract the normalized champion name from the response
+      normalized_name = data.dig("data")&.keys&.first
+      champion_data = data.dig("data", normalized_name)
+
       unless champion_data
         error("Champion '#{name}' not found")
         return
@@ -130,7 +133,12 @@ module LolDataFetcher
       client = create_client
       skins = client.skins.for_champion(champion_name)
 
-      puts "\n#{champion_name}'s Skins:"
+      # Get the correctly-cased champion name from the first skin's URL if available
+      # Or fetch it directly from the champions resource
+      champion_data = client.champions.find(champion_name)
+      normalized_name = champion_data.dig("data")&.keys&.first || champion_name
+
+      puts "\n#{normalized_name}'s Skins:"
       puts "=" * 50
 
       skins.each do |skin|

data/lib/lol_data_fetcher/resources/champions.rb

@@ -11,17 +11,23 @@ module LolDataFetcher
       end
 
       # Fetch detailed data for a specific champion including skills
-      # @param name [String] Champion name (e.g., "Ahri", "MasterYi")
+      # Supports case-insensitive search (e.g., "ahri", "AHRI", "Ahri")
+      # @param name [String] Champion name (case-insensitive)
       # @return [Hash] Detailed champion data including spells/skills
       def find(name)
-        get(cdn_path("champion/#{name}"))
+        normalized_name = normalize_name(name)
+        data = get(cdn_path("champion/#{normalized_name}"))
+        # Return data with the normalized name key
+        data
       end
 
       # Get passive ability for a specific champion
-      # @param name [String] Champion name (e.g., "Ahri", "MasterYi")
+      # Supports case-insensitive search
+      # @param name [String] Champion name (case-insensitive)
       # @return [Hash, nil] Passive ability data or nil if not found
       def passive(name)
-        find(name).dig("data", name, "passive")
+        normalized_name = normalize_name(name)
+        find(normalized_name).dig("data", normalized_name, "passive")
       end
 
       # List all champion names
@@ -36,6 +42,33 @@ module LolDataFetcher
       def find_by_id(id)
         all.dig("data")&.find { |_key, champ| champ["key"] == id.to_s }&.last
       end
+
+      private
+
+      # Normalize champion name to match Data Dragon API casing
+      # Performs case-insensitive lookup to find the correct champion name
+      # @param name [String] Champion name in any casing
+      # @return [String] Properly-cased champion name for API
+      # @raise [NotFoundError] If champion is not found
+      def normalize_name(name)
+        return name if name.nil? || name.empty?
+
+        # Get all champion names from the API
+        champions_data = all.dig("data")
+        return name unless champions_data
+
+        # Find the champion with case-insensitive matching
+        normalized = champions_data.keys.find do |champion_name|
+          champion_name.downcase == name.downcase
+        end
+
+        # If not found, raise an error
+        unless normalized
+          raise NotFoundError, "Champion '#{name}' not found. Check spelling and try again."
+        end
+
+        normalized
+      end
     end
   end
 end

data/lib/lol_data_fetcher/resources/items.rb

@@ -23,13 +23,21 @@ module LolDataFetcher
         all.dig("data")&.keys || []
       end
 
-      # Search items by name
-      # @param query [String] Search query
+      # Search items by name (case-insensitive)
+      # @param query [String] Search query (case-insensitive)
       # @return [Array<Hash>] Array of matching items
       def search(query)
         items = all.dig("data") || {}
         items.select { |_id, item| item["name"]&.downcase&.include?(query.downcase) }.values
       end
+
+      # Find item by exact name match (case-insensitive)
+      # @param name [String] Item name (case-insensitive)
+      # @return [Hash, nil] Item data or nil if not found
+      def find_by_name(name)
+        items = all.dig("data") || {}
+        items.find { |_id, item| item["name"]&.downcase == name.downcase }&.last
+      end
     end
   end
 end

data/lib/lol_data_fetcher/resources/skins.rb

@@ -5,19 +5,27 @@ module LolDataFetcher
     # Resource for fetching champion skin data
     class Skins < Base
       # Fetch skins for a specific champion
-      # @param champion_name [String] Champion name (e.g., "Ahri")
+      # Supports case-insensitive search (e.g., "ahri", "AHRI", "Ahri")
+      # @param champion_name [String] Champion name (case-insensitive)
       # @return [Array<Hash>] Array of skin data with image URLs
       def for_champion(champion_name)
-        champion_data = get(cdn_path("champion/#{champion_name}"))
-        skins = champion_data.dig("data", champion_name, "skins") || []
+        # Use the champions resource to get the data with normalized name
+        champion_data = client.champions.find(champion_name)
+
+        # The find method returns data with the normalized name as key
+        # We need to extract that key from the data
+        normalized_name = champion_data.dig("data")&.keys&.first
+        return [] unless normalized_name
+
+        skins = champion_data.dig("data", normalized_name, "skins") || []
 
         skins.map do |skin|
           {
             "id" => skin["id"],
             "num" => skin["num"],
             "name" => skin["name"],
-            "splash_url" => splash_url(champion_name, skin["num"]),
-            "loading_url" => loading_url(champion_name, skin["num"]),
+            "splash_url" => splash_url(normalized_name, skin["num"]),
+            "loading_url" => loading_url(normalized_name, skin["num"]),
             "chromas" => skin["chromas"] || false
           }
         end

data/lib/lol_data_fetcher/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LolDataFetcher
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lol_data_fetcher
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Mark Chavez