logtail 0.1.22 → 0.1.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84414eb8a10b295d9bf8629509de491717403874ad1bbef6f4fabdb5b4134fd8
-  data.tar.gz: 6837e1d87cfa646cf009c3813523b4c7da902d778983ad3f4cf2687e4c634691
+  metadata.gz: 3d5ab231af5dc942cabbb907be7db40167b6fc170e114c86cc537eb5b0655131
+  data.tar.gz: 036d73c755c4f2b790fb021fda88c8ab80e29671a11650385abdc78fb28324ef
 SHA512:
-  metadata.gz: ab2d5306bc84875a365f0e47493a8b3597e14e7cf2a370f8dae7fd731d7e643d458029708cfc84070c673ed0286438b294d87905589d94bd1ea14d2f443bfb75
-  data.tar.gz: 48c1a7a0aad9f56e9ffe5cbc5a9cd44fd7befdaae602cbabaefd5ae51ef3ea377a1ae014b6ba959b30a68f252d3f6da511f3571dbe8ee38b936c7c0a615c8a3c
+  metadata.gz: 84c6722d3dd83456274005c933ecde9fbcfea6111cf2dcfa6b28434a32acde03e3fe709061222cd6f3cb8ccaed1d7eb20d75978b6078ce33b005ad84d874823a
+  data.tar.gz: 3e5ae00d1d0a20d325849f9f0b712ccb16ea43d05537a0907ecba624d6ae2b6b76357c804769ad744e65fa73c90986d5d5ee53fdfa14d78cedb1eb43d9988a56

data/lib/logtail/log_devices/http.rb

@@ -702,8 +702,9 @@ Logtail::Config.instance.debug_logger = ::Logger.new(STDOUT)
         # seconds or as an HTTP date, at most {MAX_RETRY_AFTER}. 0 without a valid header.
         def retry_after(resp)
           value = resp["Retry-After"].to_s.strip
-          seconds = value.match?(/\A\d+\z/) ? value.to_i : (Time.httpdate(value) - Time.now).ceil
-          seconds.clamp(0, MAX_RETRY_AFTER)
+          # =~, min and max, not match? and clamp: Ruby 2.3, which the gemspec allows, has neither
+          seconds = value =~ /\A\d+\z/ ? value.to_i : (Time.httpdate(value) - Time.now).ceil
+          [[seconds, MAX_RETRY_AFTER].min, 0].max
         rescue ArgumentError
           0
         end

data/lib/logtail/logger.rb

@@ -41,6 +41,11 @@ module Logtail
           level = SEVERITY_MAP.fetch(severity, :unknown)
           tags = extract_active_support_tagged_logging_tags.clone
 
+          if logged_obj.is_a?(::Exception)
+            logged_obj = Events::Error.new(name: logged_obj.class.name, error_message: logged_obj.message,
+                                           backtrace: logged_obj.backtrace)
+          end
+
           if logged_obj.is_a?(Event)
             LogEntry.new(level, time, progname, logged_obj.message, context_snapshot, logged_obj,
                          tags: tags)

data/lib/logtail/version.rb

@@ -1,3 +1,3 @@
 module Logtail
-  VERSION = "0.1.22"
+  VERSION = "0.1.23"
 end

data/spec/logtail/logger_spec.rb

@@ -237,6 +237,85 @@ describe Logtail::Logger do
       expect(io.string).to include('"level":"error"')
       expect(io.string).to include('"tags":["tag"]')
     end
+
+    context "with an exception" do
+      let(:exception) do
+        RuntimeError.new("boom").tap do |e|
+          e.set_backtrace(["app/models/order.rb:12:in 'Order#charge'", "app/jobs/charge_job.rb:5:in 'ChargeJob#perform'"])
+        end
+      end
+
+      it "should log a rescued exception as an error event with its backtrace" do
+        begin
+          raise "boom"
+        rescue => e
+          logger.error(e)
+        end
+
+        line = JSON.parse(io.string)
+        expect(line["level"]).to eq("error")
+        expect(line["message"]).to eq("RuntimeError (boom)")
+        expect(line["error"]).to include("name" => "RuntimeError", "message" => "boom")
+        expect(line["error"]["backtrace_json"]).to include("/spec/logtail/logger_spec.rb:")
+        expect(JSON.parse(line["error"]["backtrace_json"])).to eq(e.backtrace)
+      end
+
+      it "should log an exception that was never raised without a backtrace" do
+        logger.error(RuntimeError.new("never raised"))
+
+        line = JSON.parse(io.string)
+        expect(line["message"]).to eq("RuntimeError (never raised)")
+        expect(line["error"]).to eq("name" => "RuntimeError", "message" => "never raised", "backtrace_json" => nil)
+      end
+
+      it "should log an exception returned by a block the same way" do
+        logger.error { exception }
+
+        line = JSON.parse(io.string)
+        expect(line["message"]).to eq("RuntimeError (boom)")
+        expect(line["error"]).to eq(
+          "name" => "RuntimeError",
+          "message" => "boom",
+          "backtrace_json" => %q(["app/models/order.rb:12:in 'Order#charge'","app/jobs/charge_job.rb:5:in 'ChargeJob#perform'"])
+        )
+      end
+
+      it "should log the error event as metadata with the AugmentedFormatter" do
+        logger.formatter = Logtail::Logger::AugmentedFormatter.new
+        logger.error(exception)
+
+        expect(io.string).to start_with(%q(RuntimeError (boom) @metadata {"level":"error",))
+        expect(io.string).to include(%q("error":{"name":"RuntimeError","message":"boom","backtrace_json":"[\"app/models/order.rb:12:in 'Order#charge'\",\"app/jobs/charge_job.rb:5:in 'ChargeJob#perform'\"]"}))
+      end
+
+      it "should log the class and message with the MessageOnlyFormatter" do
+        logger.formatter = Logtail::Logger::MessageOnlyFormatter.new
+        logger.error(exception)
+
+        expect(io.string).to eq("RuntimeError (boom)\n")
+      end
+
+      it "should deliver the error event with the HTTP log device" do
+        http_device = Logtail::LogDevices::HTTP.new("MYKEY", flush_continuously: false)
+        logger = Logtail::Logger.new(http_device)
+
+        logger.error(exception)
+
+        http_device.send(:flush_async)
+        request = http_device.instance_variable_get(:@request_queue).deq.request
+        entries = MessagePack.unpack(Zlib::Inflate.inflate(request.body))
+        expect(entries.size).to eq(1)
+        expect(entries[0]).to include(
+          "level" => "error",
+          "message" => "RuntimeError (boom)",
+          "error" => {
+            "name" => "RuntimeError",
+            "message" => "boom",
+            "backtrace_json" => %q(["app/models/order.rb:12:in 'Order#charge'","app/jobs/charge_job.rb:5:in 'ChargeJob#perform'"])
+          }
+        )
+      end
+    end
   end
 
   describe "#unknown" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logtail
 version: !ruby/object:Gem::Version
-  version: 0.1.22
+  version: 0.1.23
 platform: ruby
 authors:
 - Better Stack