logstash-output-tcp 5.0.3 → 5.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0565e34927d080a0ba41372bde33cbf966cb449b910acaf9ea38b91b2b7495a4
-  data.tar.gz: 88e584541dbccec6843e39edb6d497c8213b13d61498785eac6470ba62708012
+  metadata.gz: c1daa767cf92bff4f20058bc66c08898e89fefba31dc99ae3eb0171101a5e143
+  data.tar.gz: 1518bd235d036c6cfb538773dee084399e8f9a664c31df2667b1e8725f412e3c
 SHA512:
-  metadata.gz: 70c66b5b78646393b5e2848b4ce51dc076b3b79a7730929520145519c7b4a7ca498df78ba47f049794fa0d10d7b0f74e52f0c87274c4da3ca269d392b7624da4
-  data.tar.gz: e408f19d748abde5c03e18c9525ab0d9d5ebb6f11e0c0893e448892f4dcea32a49faf4450bea9ded566bdc09db46a6fbb850984b52e925110a92cfb4558d3bca
+  metadata.gz: d0caa01c562e8a919569a9a7545f481eb6af8ef8fc80c8198613d3abde6ff3b3fee84006949a816218cd92255235cf17d5e5e3ffe5d770a06001ea751716fcd6
+  data.tar.gz: e28019c283857fb53553dec35e1a434caf19ccaaabd276e71e40321cc333ead2580d1fd2c02eabece191f2010b7edc98910800b5b40d6268df7d78d3dc43944a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 5.0.4
+  - Removed requirement to have a certificate/key pair when enabling ssl
+
 ## 5.0.3
   - Docs: Set the default_codec doc attribute.
 

data/lib/logstash/outputs/tcp.rb

@@ -85,8 +85,12 @@ class LogStash::Outputs::Tcp < LogStash::Outputs::Base
     require "openssl"
 
     @ssl_context = OpenSSL::SSL::SSLContext.new
-    @ssl_context.cert = OpenSSL::X509::Certificate.new(File.read(@ssl_cert))
-    @ssl_context.key = OpenSSL::PKey::RSA.new(File.read(@ssl_key),@ssl_key_passphrase)
+    if @ssl_cert
+      @ssl_context.cert = OpenSSL::X509::Certificate.new(File.read(@ssl_cert))
+      if @ssl_key
+        @ssl_context.key = OpenSSL::PKey::RSA.new(File.read(@ssl_key),@ssl_key_passphrase)
+      end
+    end
     if @ssl_verify
       @cert_store = OpenSSL::X509::Store.new
       # Load the system default certificate path to the store

data/logstash-output-tcp.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-output-tcp'
-  s.version         = '5.0.3'
+  s.version         = '5.0.4'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Writes events over a TCP socket"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
@@ -26,5 +26,6 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'stud'
 
   s.add_development_dependency 'logstash-devutils'
+  s.add_development_dependency 'flores'
 end
 

data/spec/outputs/tcp_spec.rb

@@ -1 +1,33 @@
 require "logstash/devutils/rspec/spec_helper"
+require "logstash/outputs/tcp"
+require "flores/pki"
+
+describe LogStash::Outputs::Tcp do
+  subject { described_class.new(config) }
+  let(:config) { {
+    "host" => "localhost",
+    "port" => 2000 + rand(3000),
+  } }
+
+  context "when enabling SSL" do
+    let(:config) { super.merge("ssl_enable" => true) }
+    context "and not providing a certificate/key pair" do
+      it "registers without error" do
+        expect { subject.register }.to_not raise_error
+      end
+    end
+    context "and providing a certificate/key pair" do
+      let(:cert_key_pair) { Flores::PKI.generate }
+      let(:certificate) { cert_key_pair.first }
+      let(:cert_file) do
+        path = Tempfile.new('foo').path
+        IO.write(path, certificate.to_s)
+        path
+      end
+      let(:config) { super.merge("ssl_cert" => true, "ssl_cert" => cert_file) }
+      it "registers without error" do
+        expect { subject.register }.to_not raise_error
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-tcp
 version: !ruby/object:Gem::Version
-  version: 5.0.3
+  version: 5.0.4
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-04-06 00:00:00.000000000 Z
+date: 2019-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -72,6 +72,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: flores
+  prerelease: false
+  type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This gem is a Logstash plugin required to be installed on top of the
   Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This
   gem is not a stand-alone program
@@ -112,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key:
 specification_version: 4
 summary: Writes events over a TCP socket