logstash-output-newrelic 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 919ba065702c9f7774dd7898efa8a0c830005c042d626d0d9702436ddc04041e
-  data.tar.gz: 291a24c6aee606b51a571510d00f82038b2b343ac8fb883a6cdf0931cdab4892
+  metadata.gz: f099ad9c408ec722141c72268c3bdc038adbe98c0760da028f5149f87077a0eb
+  data.tar.gz: 45817bcb9ada5fa8ca81a57f102878fc752111f7a0b7e3d3a7fc9c681a6df480
 SHA512:
-  metadata.gz: '056379637da0ddc0534dd534d9ab2641a1e10717054f48f722f18cf4bf412871ba21d820d32ffae0a6982575f67ee36842a84f3e30fb5257376c4de3baadc03c'
-  data.tar.gz: 6e53748461e7cd38826ae76e37e7c35a7fc0630c7315ee691a800e7a7f6275f396270807888fd3d3a09381b32af3baa7034c70ca20374a51d51b8b51138e56b0
+  metadata.gz: de3784b9f1ca8300c99a7adea011e95b5ac5140ffd01d7a18dfc6cf5c5c5bbd2767cc4ac519e763bea7e0e7d12a509b9dcde98cc890b52d41ae901d750086511
+  data.tar.gz: acfc744ccc74de945848c3b76ade20b6e858fce52d1951e1533b302a2c55b4ae2f6156f507a8b0f949967981a5a304f293973f632f8c3863ab04fc1f1463a82b

data/DEVELOPER.md

@@ -0,0 +1,26 @@
+# Developing the plugin
+
+# Getting started
+
+* Install JRuby: `rbenv install jruby-9.2.5.0`
+* Use that JRuby: `rbenv local jruby-9.2.5.0`
+* Install Bundler gem: `jruby -S gem install bundler`
+
+# Developing
+
+* Install dependencies: `jruby -S bundle install`
+* Write tests and production code!
+* Bump version: edit version file `version.rb`
+* Run tests: `jruby -S bundle exec rspec`
+* Build the gem: `jruby -S gem build logstash-output-newrelic.gemspec`
+
+# Testing it with a local Logstash install
+
+Note: you may need to run the following commands outside of your checkout, since these should not
+be run with the JRuby version that you've configured your checkout to use (by using rbenv). 
+
+* Remove previous version: `logstash-plugin remove logstash-output-newrelic`
+* Add new version: `logstash-plugin install logstash-output-newrelic-<version>.gem`
+* Restart logstash: For Homebrew: `brew services restart logstash`
+* Cause a change that you've configured Logstash to pick up (for instance, append to a file you're having it monitor)
+* Look in `https://one.newrelic.com/launcher/logger.log-launcher` for your log message

data/lib/logstash/outputs/config/bigdecimal_patch.rb

@@ -0,0 +1,24 @@
+require 'bigdecimal'
+
+class BigDecimal
+    # Floating-point numbers that go through the 'json' Logstash filter get automatically converted into BigDecimals.
+    # Example of such a filter:
+    #
+    # filter {
+    #   json {
+    #     source => "message"
+    #   }
+    # }
+    #
+    # The problem is that { "value" => BigDecimal('0.12345') } gets serialized into { "value": "0.12345e0"}. We do
+    # want to keep floating point numbers serialized as floating point numbers, even at the expense of loosing a little
+    # bit of precision during the conversion. So, in the above example, the correct serialization would be:
+    # { "value": 0.12345}
+    def to_json(options = nil) #:nodoc:
+      if finite?
+        self.to_f.to_s
+      else
+        'null'
+      end
+    end
+  end

data/lib/logstash/outputs/newrelic.rb

@@ -6,6 +6,7 @@ require 'uri'
 require 'zlib'
 require 'json'
 require 'java'
+require_relative './config/bigdecimal_patch'
 
 class LogStash::Outputs::NewRelic < LogStash::Outputs::Base
   java_import java.util.concurrent.Executors;

data/lib/logstash/outputs/newrelic_version/version.rb

@@ -1,7 +1,7 @@
 module LogStash
   module Outputs
     module NewRelicVersion
-      VERSION = "1.1.3"
+      VERSION = "1.1.4"
     end
   end
 end

data/spec/outputs/newrelic_spec.rb

@@ -21,7 +21,6 @@ describe LogStash::Outputs::NewRelic do
     }
   }
 
-
   before(:each) do
     @newrelic_output = LogStash::Plugin.lookup("output", "newrelic").new(simple_config)
     @newrelic_output.register
@@ -32,6 +31,7 @@ describe LogStash::Outputs::NewRelic do
       @newrelic_output.shutdown
     end
   end
+
   context "license key tests" do
     it "sets license key when given in the header" do
       stub_request(:any, base_uri).to_return(status: 200)
@@ -280,4 +280,48 @@ describe LogStash::Outputs::NewRelic do
         .to have_been_made
     end
   end
+
+  context "JSON serialization" do
+    it "serializes floating point numbers as floating point numbers" do
+      stub_request(:any, base_uri).to_return(status: 200)
+
+      event = LogStash::Event.new({ "floatingpoint" => 0.12345 })
+      @newrelic_output.multi_receive([event])
+
+      wait_for(a_request(:post, base_uri)
+        .with { |request|
+          message = single_gzipped_message(request.body)
+          message['attributes']['floatingpoint'] == 0.12345
+        }
+      ).to have_been_made
+    end
+
+    it "serializes BigDecimals as floating point numbers" do
+      stub_request(:any, base_uri).to_return(status: 200)
+
+      event = LogStash::Event.new({ "bigdecimal" => BigDecimal('0.12345') })
+      @newrelic_output.multi_receive([event])
+
+      wait_for(a_request(:post, base_uri)
+        .with { |request|
+          message = single_gzipped_message(request.body)
+          message['attributes']['bigdecimal'] == 0.12345
+        }
+      ).to have_been_made
+    end
+
+    it "serializes NaN as null" do
+      stub_request(:any, base_uri).to_return(status: 200)
+
+      event = LogStash::Event.new({ "nan" => BigDecimal('NaN') })
+      @newrelic_output.multi_receive([event])
+
+      wait_for(a_request(:post, base_uri)
+        .with { |request|
+          message = single_gzipped_message(request.body)
+          message['attributes']['nan'] == nil
+        }
+      ).to have_been_made
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-newrelic
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - New Relic Logging Team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-22 00:00:00.000000000 Z
+date: 2020-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -116,9 +116,11 @@ extra_rdoc_files: []
 files:
 - CHANGELOG.md
 - CONTRIBUTORS
+- DEVELOPER.md
 - Gemfile
 - LICENSE
 - README.md
+- lib/logstash/outputs/config/bigdecimal_patch.rb
 - lib/logstash/outputs/newrelic.rb
 - lib/logstash/outputs/newrelic_version/version.rb
 - logstash-output-newrelic.gemspec