logstash-output-kafka 5.1.11 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab8c64c41a0113d3e77d4d74adac247424d6a7c5
-  data.tar.gz: ea85a76f270acd51915e1a1a7a80da0e83e9e82e
+  metadata.gz: 3fbe7d272d3d724287711d102a7f95c9ebb0a12d
+  data.tar.gz: 26bca0940efcb7a509ee256f939043aada0618d0
 SHA512:
-  metadata.gz: 18927151780d0b0d085e5472b9d8d6a07601bd847163a3bd6578b9359227c73344d4f24ef1ed498d756e3fea8594860e3cafd0ddb15a2eb566b14ed3a340f890
-  data.tar.gz: 76f4b59eec073cefafe18db46fae720cdede9a234d39aab6da3acc4e6588921e089e076afc8a2cd4542ba81572322229fd9e9332a66d38ea8420e5f7a49899f4
+  metadata.gz: 6947a968db077a2b434565940083e5f2727e1b303af01ffb33e7b7a80629707c2efaeaf84ad85ad02e0abfbc1eee625ff317d40e582b37def0d48bfcd32bfab3
+  data.tar.gz: 92eae1ac1ca9812e11bf042167cefa518616c6b2a142d14c354cd47461bca823c5ce0cd79a43b7314b80c2077d7acb47ce0f4b4f6a41a49d67010c4a9facfe54

data/CHANGELOG.md

@@ -1,44 +1,5 @@
-## 5.1.11
-  - Bugfix: Sends are now retried until successful. Previously, failed transmissions to Kafka 
-    could have been lost by the KafkaProducer library. Now we verify transmission explicitly.
-    This changes the default 'retry' from 0 to retry-forever. It was a bug that we defaulted
-    to a retry count of 0.
-    https://github.com/logstash-plugins/logstash-output-kafka/pull/151
-
-  - Docs: Fix misleading info about the default codec
-
-## 5.1.10
-  - Doc fixes
-
-## 5.1.9
-  - Doc fixes
-
-## 5.1.8
-  - Docs: Fix topic title
-
-## 5.1.7
-  - Docs: Fix asciidoc
-
-## 5.1.6
-  - Fix a bug when SASL_SSL+PLAIN (no Kerberos) was specified.
-
-## 5.1.5
-  - Fix a bug where consumer was not correctly setup when `SASL_SSL` option was specified.
-
-## 5.1.4
-  - Docs: Move info about security features out of the compatibility matrix and into the main text.
-  
-## 5.1.3
-  - Docs: Clarify compatibility matrix and remove it from the changelog to avoid duplication.
-
-## 5.1.2
-  - bump sl4j version dep to 1.7.21 to align with input plugin and kafka-clients maven deps
-
-## 5.1.1
-  - Docs: Update the doc to mention the plain codec instead of the json codec.
-
-## 5.1.0
-  - Add Kerberos authentication feature.
+## 6.0.0
+  - BREAKING: update to 0.10.1.0 client protocol. not backwards compatible with 5.0 (protocol versions <= 10.0.0.1)
 
 ## 5.0.5
   - Fix logging

data/README.md

@@ -6,6 +6,19 @@ This is a plugin for [Logstash](https://github.com/elastic/logstash).
 
 It is fully free and fully open source. The license is Apache 2.0, meaning you are pretty much free to use it however you want in whatever way.
 
+## Kafka Compatibility
+
+Here's a table that describes the compatibility matrix for Kafka Broker support. Please remember that it is good advice to upgrade brokers before consumers/producers since brokers target backwards compatibility. The 0.9 broker will work with both the 0.8 consumer and 0.9 consumer APIs but not the other way around.
+
+| Kafka Broker Version | Logstash Version | Input Plugin | Output Plugin | Why? |
+|:---------------:|:------------------:|:--------------:|:---------------:|:------|
+| 0.8           | 2.0 - 2.x   | < 3.0.0 | <3.0.0 | Legacy, 0.8 is still popular |
+| 0.9           | 2.0 - 2.3.x   |   3.0.0 | 3.0.0  | Intermediate release before 0.10 that works with old Ruby Event API `[]`  |
+| 0.9          | 2.4, 5.0           |   4.0.0 | 4.0.0  | Intermediate release before 0.10 with new get/set API |
+| 0.10.0.x         | 2.4, 5.0           |   5.0.0 | 5.0.0  | Track latest Kafka release. Not compatible with 0.9 broker |
+| 0.10.1.x         | 2.4, 5.0           |   6.0.0 | X  | Track latest Kafka release. Not compatible with < 0.10.0.x broker |
+
+
 ## Documentation
 
 Logstash provides infrastructure to automatically generate documentation for this plugin. We use the asciidoc format to write documentation so any comments in the source code will be first converted into asciidoc and then into html. All plugin documentation are placed under one [central location](http://www.elastic.co/guide/en/logstash/current/).

data/lib/logstash/outputs/kafka.rb

@@ -11,25 +11,19 @@ require 'logstash-output-kafka_jars.rb'
 # 
 # [options="header"]
 # |==========================================================
-# |Kafka Client Version |Logstash Version |Plugin Version |Why?
-# |0.8       |2.0.0 - 2.x.x   |<3.0.0 |Legacy, 0.8 is still popular 
-# |0.9       |2.0.0 - 2.3.x   | 3.x.x |Works with the old Ruby Event API (`event['product']['price'] = 10`)
-# |0.9       |2.4.x - 5.x.x   | 4.x.x |Works with the new getter/setter APIs (`event.set('[product][price]', 10)`)
-# |0.10.0.x  |2.4.x - 5.x.x   | 5.x.x |Not compatible with the <= 0.9 broker
+# |Kafka Client Version |Logstash Version |Plugin Version |Security Features |Why?
+# |0.8       |2.0.0 - 2.x.x   |<3.0.0 | |Legacy, 0.8 is still popular 
+# |0.9       |2.0.0 - 2.3.x   | 3.x.x |Basic Auth, SSL |Works with the old Ruby Event API (`event['product']['price'] = 10`)
+# |0.9       |2.4.0 - 5.0.x   | 4.x.x |Basic Auth, SSL |Works with the new getter/setter APIs (`event.set('[product][price]', 10)`)
+# |0.10.0.x  |2.4.0 - 5.0.x   | 5.x.x |Basic Auth, SSL |Not compatible with the <= 0.9 broker
+# |0.10.1.x  |2.4.0 - 5.0.x   | 6.x.x |Basic Auth, SSL |Not compatible with <= 0.10.0.x broker
 # |==========================================================
-# 
+#
 # NOTE: We recommended that you use matching Kafka client and broker versions. During upgrades, you should
 # upgrade brokers before clients because brokers target backwards compatibility. For example, the 0.9 broker
 # is compatible with both the 0.8 consumer and 0.9 consumer APIs, but not the other way around.
 #
-# This output supports connecting to Kafka over:
-#
-# * SSL (requires plugin version 3.0.0 or later)
-# * Kerberos SASL (requires plugin version 5.1.0 or later)
-#
-# By default security is disabled but can be turned on as needed.
-#
-# The only required configuration is the topic_id. The default codec is plain,
+# The only required configuration is the topic_id. The default codec is json,
 # so events will be persisted on the broker in json format. If you select a codec of plain,
 # Logstash will encode your messages with not only the message but also with a timestamp and
 # hostname. If you do not want anything but your message passing through, you should make the output
@@ -111,63 +105,23 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
   # elapses the client will resend the request if necessary or fail the request if
   # retries are exhausted.
   config :request_timeout_ms, :validate => :string
-  # The default retry behavior is to retry until successful. To prevent data loss,
-  # the use of this setting is discouraged.
-  #
-  # If you choose to set `retries`, a value greater than zero will cause the
-  # client to only retry a fixed number of times. This will result in data loss
-  # if a transient error outlasts your retry count.
-  #
-  # A value less than zero is a configuration error.
-  config :retries, :validate => :number
+  # Setting a value greater than zero will cause the client to
+  # resend any record whose send fails with a potentially transient error.
+  config :retries, :validate => :number, :default => 0
   # The amount of time to wait before attempting to retry a failed produce request to a given topic partition.
   config :retry_backoff_ms, :validate => :number, :default => 100
   # The size of the TCP send buffer to use when sending data.
   config :send_buffer_bytes, :validate => :number, :default => 131072
   # Enable SSL/TLS secured communication to Kafka broker.
-  config :ssl, :validate => :boolean, :default => false, :deprecated => "Use security_protocol => 'ssl'"
-  # The truststore type.
-  config :ssl_truststore_type, :validate => :string
+  config :ssl, :validate => :boolean, :default => false
   # The JKS truststore path to validate the Kafka broker's certificate.
   config :ssl_truststore_location, :validate => :path
   # The truststore password
   config :ssl_truststore_password, :validate => :password
-  # The keystore type.
-  config :ssl_keystore_type, :validate => :string
   # If client authentication is required, this setting stores the keystore path.
   config :ssl_keystore_location, :validate => :path
   # If client authentication is required, this setting stores the keystore password
   config :ssl_keystore_password, :validate => :password
-  # The password of the private key in the key store file.
-  config :ssl_key_password, :validate => :password
-  # Security protocol to use, which can be either of PLAINTEXT,SSL,SASL_PLAINTEXT,SASL_SSL
-  config :security_protocol, :validate => ["PLAINTEXT", "SSL", "SASL_PLAINTEXT", "SASL_SSL"], :default => "PLAINTEXT"
-  # http://kafka.apache.org/documentation.html#security_sasl[SASL mechanism] used for client connections. 
-  # This may be any mechanism for which a security provider is available.
-  # GSSAPI is the default mechanism.
-  config :sasl_mechanism, :validate => :string, :default => "GSSAPI"
-  # The Kerberos principal name that Kafka broker runs as. 
-  # This can be defined either in Kafka's JAAS config or in Kafka's config.
-  config :sasl_kerberos_service_name, :validate => :string
-  # The Java Authentication and Authorization Service (JAAS) API supplies user authentication and authorization 
-  # services for Kafka. This setting provides the path to the JAAS file. Sample JAAS file for Kafka client:
-  # [source,java]
-  # ----------------------------------
-  # KafkaClient {
-  #   com.sun.security.auth.module.Krb5LoginModule required
-  #   useTicketCache=true
-  #   renewTicket=true
-  #   serviceName="kafka";
-  #   };
-  # ----------------------------------
-  #
-  # Please note that specifying `jaas_path` and `kerberos_config` in the config file will add these 
-  # to the global JVM system properties. This means if you have multiple Kafka inputs, all of them would be sharing the same 
-  # `jaas_path` and `kerberos_config`. If this is not desirable, you would have to run separate instances of Logstash on 
-  # different JVM instances.
-  config :jaas_path, :validate => :path
-  # Optional path to kerberos config file. This is krb5.conf style as detailed in https://web.mit.edu/kerberos/krb5-1.12/doc/admin/conf_files/krb5_conf.html
-  config :kerberos_config, :validate => :path
   # The configuration controls the maximum amount of time the server will wait for acknowledgments
   # from followers to meet the acknowledgment requirements the producer has specified with the
   # acks configuration. If the requested number of acknowledgments are not met when the timeout
@@ -181,17 +135,6 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
 
   public
   def register
-    @thread_batch_map = Concurrent::Hash.new
-
-    if !@retries.nil? 
-      if @retries < 0
-        raise ConfigurationError, "A negative retry count (#{@retries}) is not valid. Must be a value >= 0"
-      end
-
-      @logger.warn("Kafka output is configured with finite retry. This instructs Logstash to LOSE DATA after a set number of send attempts fails. If you do not want to lose data if Kafka is down, then you must remove the retry setting.", :retries => @retries)
-    end
-
-
     @producer = create_producer
     @codec.on_event do |event, data|
       begin
@@ -200,7 +143,7 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
         else
           record = org.apache.kafka.clients.producer.ProducerRecord.new(event.sprintf(@topic_id), event.sprintf(@message_key), data)
         end
-        prepare(record)
+        @producer.send(record)
       rescue LogStash::ShutdownSignal
         @logger.debug('Kafka producer got shutdown signal')
       rescue => e
@@ -208,89 +151,14 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
                      :exception => e)
       end
     end
-  end # def register
-
-  def prepare(record)
-    # This output is threadsafe, so we need to keep a batch per thread.
-    @thread_batch_map[Thread.current].add(record)
-  end
-
-  def multi_receive(events)
-    t = Thread.current
-    if !@thread_batch_map.include?(t)
-      @thread_batch_map[t] = java.util.ArrayList.new(events.size)
-    end
-
-    events.each do |event|
-      break if event == LogStash::SHUTDOWN
-      @codec.encode(event)
-    end
-
-    batch = @thread_batch_map[t]
-    if batch.any?
-      retrying_send(batch)
-      batch.clear
-    end
-  end
 
-  def retrying_send(batch)
-    remaining = @retries;
-
-    while batch.any?
-      if !remaining.nil?
-        if remaining < 0
-          # TODO(sissel): Offer to DLQ? Then again, if it's a transient fault,
-          # DLQing would make things worse (you dlq data that would be successful
-          # after the fault is repaired)
-          logger.info("Exhausted user-configured retry count when sending to Kafka. Dropping these events.",
-                      :max_retries => @retries, :drop_count => batch.count)
-          break
-        end
-
-        remaining -= 1
-      end
-
-      failures = []
-
-      futures = batch.collect do |record| 
-        begin
-          # send() can throw an exception even before the future is created.
-          @producer.send(record)
-        rescue org.apache.kafka.common.errors.TimeoutException => e
-          failures << record
-          nil
-        rescue org.apache.kafka.common.errors.InterruptException => e
-          failures << record
-          nil
-        rescue org.apache.kafka.common.errors.SerializationException => e
-          # TODO(sissel): Retrying will fail because the data itself has a problem serializing.
-          # TODO(sissel): Let's add DLQ here.
-          failures << record
-          nil
-        end
-      end.compact
-
-      futures.each_with_index do |future, i|
-        begin
-          result = future.get()
-        rescue => e
-          # TODO(sissel): Add metric to count failures, possibly by exception type.
-          logger.debug? && logger.debug("KafkaProducer.send() failed: #{e}", :exception => e);
-          failures << batch[i]
-        end
-      end
-
-      # No failures? Cool. Let's move on.
-      break if failures.empty?
+  end # def register
 
-      # Otherwise, retry with any failed transmissions
-      batch = failures
-      delay = 1.0 / @retry_backoff_ms
-      logger.info("Sending batch to Kafka failed. Will retry after a delay.", :batch_size => batch.size,
-                  :failures => failures.size, :sleep => delay);
-      sleep(delay)
+  def receive(event)
+    if event == LogStash::SHUTDOWN
+      return
     end
-
+    @codec.encode(event)
   end
 
   def close
@@ -314,23 +182,24 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
       props.put(kafka::MAX_REQUEST_SIZE_CONFIG, max_request_size.to_s)
       props.put(kafka::RECONNECT_BACKOFF_MS_CONFIG, reconnect_backoff_ms) unless reconnect_backoff_ms.nil?
       props.put(kafka::REQUEST_TIMEOUT_MS_CONFIG, request_timeout_ms) unless request_timeout_ms.nil?
-      props.put(kafka::RETRIES_CONFIG, retries.to_s) unless retries.nil?
-      props.put(kafka::RETRY_BACKOFF_MS_CONFIG, retry_backoff_ms.to_s) 
+      props.put(kafka::RETRIES_CONFIG, retries.to_s)
+      props.put(kafka::RETRY_BACKOFF_MS_CONFIG, retry_backoff_ms.to_s)
       props.put(kafka::SEND_BUFFER_CONFIG, send_buffer_bytes.to_s)
       props.put(kafka::VALUE_SERIALIZER_CLASS_CONFIG, value_serializer)
 
-      props.put("security.protocol", security_protocol) unless security_protocol.nil?
+      if ssl
+        if ssl_truststore_location.nil?
+          raise LogStash::ConfigurationError, "ssl_truststore_location must be set when SSL is enabled"
+        end
+        props.put("security.protocol", "SSL")
+        props.put("ssl.truststore.location", ssl_truststore_location)
+        props.put("ssl.truststore.password", ssl_truststore_password.value) unless ssl_truststore_password.nil?
 
-      if security_protocol == "SSL" || ssl
-        set_trustore_keystore_config(props)
-      elsif security_protocol == "SASL_PLAINTEXT"
-        set_sasl_config(props)
-      elsif security_protocol == "SASL_SSL"
-        set_trustore_keystore_config(props)
-        set_sasl_config(props)
+        #Client auth stuff
+        props.put("ssl.keystore.location", ssl_keystore_location) unless ssl_keystore_location.nil?
+        props.put("ssl.keystore.password", ssl_keystore_password.value) unless ssl_keystore_password.nil?
       end
 
-
       org.apache.kafka.clients.producer.KafkaProducer.new(props)
     rescue => e
       logger.error("Unable to create Kafka producer from given configuration", :kafka_error_message => e)
@@ -338,31 +207,4 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base
     end
   end
 
-  def set_trustore_keystore_config(props)
-    if ssl_truststore_location.nil?
-      raise LogStash::ConfigurationError, "ssl_truststore_location must be set when SSL is enabled"
-    end
-    props.put("ssl.truststore.type", ssl_truststore_type) unless ssl_truststore_type.nil?
-    props.put("ssl.truststore.location", ssl_truststore_location)
-    props.put("ssl.truststore.password", ssl_truststore_password.value) unless ssl_truststore_password.nil?
-
-    # Client auth stuff
-    props.put("ssl.keystore.type", ssl_keystore_type) unless ssl_keystore_type.nil?
-    props.put("ssl.key.password", ssl_key_password.value) unless ssl_key_password.nil?
-    props.put("ssl.keystore.location", ssl_keystore_location) unless ssl_keystore_location.nil?
-    props.put("ssl.keystore.password", ssl_keystore_password.value) unless ssl_keystore_password.nil?
-  end
-
-  def set_sasl_config(props)
-    java.lang.System.setProperty("java.security.auth.login.config",jaas_path) unless jaas_path.nil?
-    java.lang.System.setProperty("java.security.krb5.conf",kerberos_config) unless kerberos_config.nil?
-
-    props.put("sasl.mechanism",sasl_mechanism)
-    if sasl_mechanism == "GSSAPI" && sasl_kerberos_service_name.nil?
-      raise LogStash::ConfigurationError, "sasl_kerberos_service_name must be specified when SASL mechanism is GSSAPI"
-    end
-
-    props.put("sasl.kerberos.service.name",sasl_kerberos_service_name) unless sasl_kerberos_service_name.nil?
-  end
-
 end #class LogStash::Outputs::Kafka

data/logstash-output-kafka.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-output-kafka'
-  s.version         = '5.1.11'
+  s.version         = '6.0.0'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = 'Output events to a Kafka topic. This uses the Kafka Producer API to write messages to a topic on the broker'
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   # Special flag to let us know this is actually a logstash plugin
   s.metadata = { 'logstash_plugin' => 'true', 'group' => 'output'}
 
-  s.requirements << "jar 'org.apache.kafka:kafka-clients', '0.10.0.1'"
+  s.requirements << "jar 'org.apache.kafka:kafka-clients', '0.10.1.0'"
   s.requirements << "jar 'org.slf4j:slf4j-log4j12', '1.7.21'"
 
   s.add_development_dependency 'jar-dependencies', '~> 0.3.2'

data/spec/integration/outputs/kafka_spec.rb

@@ -157,7 +157,7 @@ describe "outputs/kafka", :integration => true do
   def load_kafka_data(config)
     kafka = LogStash::Outputs::Kafka.new(config)
     kafka.register
-    kafka.multi_receive(num_events.times.collect { event })
+    num_events.times do kafka.receive(event) end
     kafka.close
   end
 

data/spec/unit/outputs/kafka_spec.rb

@@ -25,118 +25,34 @@ describe "outputs/kafka" do
   context 'when outputting messages' do
     it 'should send logstash event to kafka broker' do
       expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send)
-        .with(an_instance_of(org.apache.kafka.clients.producer.ProducerRecord)).and_call_original
+        .with(an_instance_of(org.apache.kafka.clients.producer.ProducerRecord))
       kafka = LogStash::Outputs::Kafka.new(simple_kafka_config)
       kafka.register
-      kafka.multi_receive([event])
+      kafka.receive(event)
     end
 
     it 'should support Event#sprintf placeholders in topic_id' do
       topic_field = 'topic_name'
       expect(org.apache.kafka.clients.producer.ProducerRecord).to receive(:new)
-        .with("my_topic", event.to_s).and_call_original
-      expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send).and_call_original
+        .with("my_topic", event.to_s)
+      expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send)
       kafka = LogStash::Outputs::Kafka.new({'topic_id' => "%{#{topic_field}}"})
       kafka.register
-      kafka.multi_receive([event])
+      kafka.receive(event)
     end
 
     it 'should support field referenced message_keys' do
       expect(org.apache.kafka.clients.producer.ProducerRecord).to receive(:new)
-        .with("test", "172.0.0.1", event.to_s).and_call_original
-      expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send).and_call_original
+        .with("test", "172.0.0.1", event.to_s)
+      expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send)
       kafka = LogStash::Outputs::Kafka.new(simple_kafka_config.merge({"message_key" => "%{host}"}))
       kafka.register
-      kafka.multi_receive([event])
+      kafka.receive(event)
     end
     
     it 'should raise config error when truststore location is not set and ssl is enabled' do
-      kafka = LogStash::Outputs::Kafka.new(simple_kafka_config.merge("security_protocol" => "SSL"))
+      kafka = LogStash::Outputs::Kafka.new(simple_kafka_config.merge({"ssl" => "true"}))
       expect { kafka.register }.to raise_error(LogStash::ConfigurationError, /ssl_truststore_location must be set when SSL is enabled/)
     end
   end
-  
-  context "when KafkaProducer#send() raises an exception" do
-    let(:failcount) { (rand * 10).to_i }
-    let(:sendcount) { failcount + 1 }
-
-    let(:exception_classes) { [
-      org.apache.kafka.common.errors.TimeoutException,
-      org.apache.kafka.common.errors.InterruptException,
-      org.apache.kafka.common.errors.SerializationException
-    ] }
-
-    before do
-      count = 0
-      expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send)
-        .exactly(sendcount).times
-        .and_wrap_original do |m, *args|
-        if count < failcount # fail 'failcount' times in a row.
-          count += 1
-          # Pick an exception at random
-          raise exception_classes.shuffle.first.new("injected exception for testing")
-        else
-          m.call(*args) # call original
-        end
-      end
-    end
-
-    it "should retry until successful" do
-      kafka = LogStash::Outputs::Kafka.new(simple_kafka_config)
-      kafka.register
-      kafka.multi_receive([event])
-    end
-  end
-
-  context "when a send fails" do
-    context "and the default retries behavior is used" do
-      # Fail this many times and then finally succeed.
-      let(:failcount) { (rand * 10).to_i }
-
-      # Expect KafkaProducer.send() to get called again after every failure, plus the successful one.
-      let(:sendcount) { failcount + 1 }
-
-      it "should retry until successful" do
-        count = 0;
-
-        expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send)
-              .exactly(sendcount).times
-              .and_wrap_original do |m, *args|
-          if count < failcount
-            count += 1
-            # inject some failures.
-
-            # Return a custom Future that will raise an exception to simulate a Kafka send() problem.
-            future = java.util.concurrent.FutureTask.new { raise "Failed" }
-            future.run
-            future
-          else
-            m.call(*args)
-          end
-        end
-        kafka = LogStash::Outputs::Kafka.new(simple_kafka_config)
-        kafka.register
-        kafka.multi_receive([event])
-      end
-    end
-
-    context "and when retries is set by the user" do
-      let(:retries) { (rand * 10).to_i }
-      let(:max_sends) { retries + 1 }
-
-      it "should give up after retries are exhausted" do
-        expect_any_instance_of(org.apache.kafka.clients.producer.KafkaProducer).to receive(:send)
-              .at_most(max_sends).times
-              .and_wrap_original do |m, *args|
-          # Always fail.
-          future = java.util.concurrent.FutureTask.new { raise "Failed" }
-          future.run
-          future
-        end
-        kafka = LogStash::Outputs::Kafka.new(simple_kafka_config.merge("retries" => retries))
-        kafka.register
-        kafka.multi_receive([event])
-      end
-    end
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-kafka
 version: !ruby/object:Gem::Version
-  version: 5.1.11
+  version: 6.0.0
 platform: ruby
 authors:
 - Elasticsearch
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-10-09 00:00:00.000000000 Z
+date: 2016-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -132,7 +132,7 @@ files:
 - logstash-output-kafka.gemspec
 - spec/integration/outputs/kafka_spec.rb
 - spec/unit/outputs/kafka_spec.rb
-- vendor/jar-dependencies/runtime-jars/kafka-clients-0.10.0.1.jar
+- vendor/jar-dependencies/runtime-jars/kafka-clients-0.10.1.0.jar
 - vendor/jar-dependencies/runtime-jars/log4j-1.2.17.jar
 - vendor/jar-dependencies/runtime-jars/lz4-1.3.0.jar
 - vendor/jar-dependencies/runtime-jars/slf4j-api-1.7.21.jar
@@ -159,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements:
-- jar 'org.apache.kafka:kafka-clients', '0.10.0.1'
+- jar 'org.apache.kafka:kafka-clients', '0.10.1.0'
 - jar 'org.slf4j:slf4j-log4j12', '1.7.21'
 rubyforge_project:
 rubygems_version: 2.4.8