logstash-input-file 3.1.2 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 517e94fddd4ca73a733b01e023edf1675030d6f8
-  data.tar.gz: a325e49d3bf6597fe0ade161ff4942c9dd4145cf
+  metadata.gz: 00f5e922badbdd1b31300eb066d5d9b3917ed967
+  data.tar.gz: 06bd5932092a2b1989f7478c469d587d4d240928
 SHA512:
-  metadata.gz: 83584264653eb07b7a7600744c1e45565f68f4c10f4bb53c7736fedc1801386d73cfbcdb77070058aefd8361dc2a875a6b81e91f7fdb46455fe0ae5745be6556
-  data.tar.gz: 31ad48d0a47159dfcf8d5df2706688c89dd30618c1209d8dae744d180c65936665b931b4af8ce3a9a50f8e232853143d2862c1deb32c654bda7358db43d80cba
+  metadata.gz: e7b898485e484698a4774dadd163402ba0492d8bcda39559fa5b4be14ff8d9ededc7fbe2f7831de16092770b9ce688131d0e22be4c0568c8ed354ce62e82e676
+  data.tar.gz: bd425a072f2c1b262d522db2a36f53ec2ac88e47f6f406f69bc2c3dec8370bc8f7d70562065a87b108e1ebb09aae2d4f26765a09aa46e168c4a2feeede64c516

data/CHANGELOG.md

@@ -1,21 +1,36 @@
+## 4.0.0
+  - Breaking: `ignore_older` settings is disabled by default. Previously if the file was older than 
+    24 hours (the default for ignore_older), it would be ignored. This confused new users a lot, specially 
+    when they were reading new files with Logstash (with `start_position => beginning`). This setting also 
+    makes it consistent with Filebeat.
+
 ## 3.1.2
   - Adjust a few log call levels
+
 ## 3.1.1
   - Add host to @metadata
+
 ## 3.1.0
-  - Use native `--path.data` for Logstash 5.0 for sincedb files.
+  - Breaking: Use native `--path.data` for Logstash 5.0 for sincedb files.
+
 ## 3.0.3
   - Relax constraint on logstash-core-plugin-api to >= 1.60 <= 2.99
+
 ## 3.0.2
   - relax constrains of `logstash-devutils` see https://github.com/elastic/logstash-devutils/issues/48
+
 ## 3.0.1
   - Republish all the gems under jruby.
+
 ## 3.0.0
   - Update the plugin to the version 2.0 of the plugin api, this change is required for Logstash 5.0 compatibility. See https://github.com/elastic/logstash/issues/5141
+
 # 2.2.5
   - Depend on logstash-core-plugin-api instead of logstash-core, removing the need to mass update plugins on major releases of logstash
+
 # 2.2.3
   - New dependency requirements for logstash-core for the 5.0 release
+
 ## 2.2.2
  - Fix for: Filewatch library complains if HOME or SINCEDB_PATH variables are unset.
    - [Issue #101](https://github.com/logstash-plugins/logstash-input-file/issues/101)

data/lib/logstash/inputs/file.rb

@@ -146,8 +146,9 @@ class LogStash::Inputs::File < LogStash::Inputs::Base
   # When the file input discovers a file that was last modified
   # before the specified timespan in seconds, the file is ignored.
   # After it's discovery, if an ignored file is modified it is no
-  # longer ignored and any new data is read. The default is 24 hours.
-  config :ignore_older, :validate => :number, :default => 24 * 60 * 60
+  # longer ignored and any new data is read. By default, this option is
+  # disabled. Note this unit is in seconds.
+  config :ignore_older, :validate => :number
 
   # The file input closes any files that were last read the specified
   # timespan in seconds ago.

data/logstash-input-file.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-input-file'
-  s.version         = '3.1.2'
+  s.version         = '4.0.0'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Stream events from files."
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/inputs/file_spec.rb

@@ -129,6 +129,41 @@ describe LogStash::Inputs::File do
       insist { events[1].get("[@metadata][host]") } == "#{Socket.gethostname.force_encoding(Encoding::UTF_8)}"
     end
 
+    it "should read old files" do
+      tmpfile_path = Stud::Temporary.pathname
+
+      conf = <<-CONFIG
+        input {
+          file {
+            type => "blah"
+            path => "#{tmpfile_path}"
+            start_position => "beginning"
+            codec => "json"
+          }
+        }
+      CONFIG
+
+      File.open(tmpfile_path, "w") do |fd|
+        fd.puts('{"path": "my_path", "host": "my_host"}')
+        fd.puts('{"my_field": "my_val"}')
+        fd.fsync
+      end
+      # arbitrary old file (2 days)
+      FileInput.make_file_older(tmpfile_path, 48 * 60 * 60)
+
+      events = input(conf) do |pipeline, queue|
+        2.times.collect { queue.pop }
+      end
+
+      insist { events[0].get("path") } == "my_path"
+      insist { events[0].get("host") } == "my_host"
+      insist { events[0].get("[@metadata][host]") } == "#{Socket.gethostname.force_encoding(Encoding::UTF_8)}"
+
+      insist { events[1].get("path") } == "#{tmpfile_path}"
+      insist { events[1].get("host") } == "#{Socket.gethostname.force_encoding(Encoding::UTF_8)}"
+      insist { events[1].get("[@metadata][host]") } == "#{Socket.gethostname.force_encoding(Encoding::UTF_8)}"
+    end
+
     context "when sincedb_path is an existing directory" do
       let(:tmpfile_path) { Stud::Temporary.pathname }
       let(:sincedb_path) { Stud::Temporary.directory }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-input-file
 version: !ruby/object:Gem::Version
-  version: 3.1.2
+  version: 4.0.0
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-09-15 00:00:00.000000000 Z
+date: 2016-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement