logstash-filter-dns 3.0.7 → 3.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f70cd3ab7af0b1558159896ccda3e5b24b827fc3c56e0c5ad6524bf01ee1edb9
-  data.tar.gz: 7c565bc456246cf07fd94a824235f3d505cae4e1ae3a9a6ab98a2b8f2ca4d9c2
+  metadata.gz: 92de1abd5a69194705cf89576e76e5fb5c592972b295eed707af3ae5e45a8ed8
+  data.tar.gz: 134d58100b23b1847ae0d72ffbbc2a77662a3dca46365530c1a1aae26e764ed6
 SHA512:
-  metadata.gz: d623329ec59b4a0a96878e7f6bc6aa5353e14acd2ecee2b486967963b8da99255adb922f015cdc5c01fbd08645f5798895026a9e93b8091d6a4e1ea380031af4
-  data.tar.gz: 291ab5d248faba4610d61cdd0b5e0f42194fc88b99743d22e817d7c9481e614f2ba8554fbddcc6bed87094ea9c9cb80030883b49dcef5bb288146b5db79e1a2a
+  metadata.gz: a0aaa47fd116162311bbf714477e88d2c321c0df538fc95b783b5bd9089c2a6a9ef9c586e2ec26ff7ae0a405e4b54565a1115bdcadd349f2041ae956fe69f922
+  data.tar.gz: c8010e5d0f90917b2b6edf95f4e70974eb716c21088dcd9b3b269290b14ce91bedde3588b4e6768d7f2ea836a709bb4bbb10e7424e8e357e0568c5cc7a229312

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.0.8
+  - Fix bug where forward lookups would not cache timeout errors
+
 ## 3.0.7
   - Update gemspec summary
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012–2016 Elasticsearch <http://www.elastic.co>
+Copyright (c) 2012-2018 Elasticsearch <http://www.elastic.co>
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/lib/logstash/filters/dns.rb

@@ -69,6 +69,9 @@ class LogStash::Filters::DNS < LogStash::Filters::Base
   # Use custom hosts file(s). For example: `["/var/db/my_custom_hosts"]`
   config :hostsfile, :validate => :array
 
+  attr_reader :hit_cache
+  attr_reader :failed_cache
+
   public
   def register
     if @nameserver.nil? && @hostsfile.nil?
@@ -90,7 +93,6 @@ class LogStash::Filters::DNS < LogStash::Filters::Base
 
   public
   def filter(event)
-
     if @resolve
       return if resolve(event).nil?
     end
@@ -150,6 +152,7 @@ class LogStash::Filters::DNS < LogStash::Filters::Base
                       :field => field, :value => raw)
         return
       rescue Resolv::ResolvTimeout, Timeout::Error
+        @failed_cache[raw] = true if @failed_cache
         @logger.error("DNS: timeout on resolving the hostname.",
                       :field => field, :value => raw)
         return
@@ -216,6 +219,7 @@ class LogStash::Filters::DNS < LogStash::Filters::Base
                       :field => field, :value => raw)
         return
       rescue Resolv::ResolvTimeout, Timeout::Error
+        @failed_cache[raw] = true if @failed_cache
         @logger.error("DNS: timeout on resolving address.",
                       :field => field, :value => raw)
         return

data/logstash-filter-dns.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-dns'
-  s.version         = '3.0.7'
+  s.version         = '3.0.8'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Performs a standard or reverse DNS lookup"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/dns_spec.rb

@@ -364,10 +364,11 @@ describe LogStash::Filters::DNS do
 
     describe "retries" do
 
+      let(:host) { "unknownhost" }
       let(:subject) { LogStash::Filters::DNS.new(config) }
-      let(:event) { LogStash::Event.new("message" => "unkownhost") }
+      let(:event) { LogStash::Event.new("message" => host) }
       let(:max_retries) { 3 }
-      let(:config) { { "resolve" => ["message"], "max_retries" => max_retries } }
+      let(:config) { { "resolve" => ["message"], "max_retries" => max_retries, "failed_cache_size" => 10 } }
 
       before(:each) { subject.register }
 
@@ -380,6 +381,12 @@ describe LogStash::Filters::DNS do
           expect(subject).to receive(:getaddress).exactly(max_retries+1).times
           subject.filter(event)
         end
+
+        it "should cache the timeout" do
+          expect do
+            subject.filter(event)
+          end.to change { subject.failed_cache[host] }.from(nil).to(true)
+        end
       end
 
       context "when failing temporarily" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-dns
 version: !ruby/object:Gem::Version
-  version: 3.0.7
+  version: 3.0.8
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-07 00:00:00.000000000 Z
+date: 2018-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -99,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key:
 specification_version: 4
 summary: Performs a standard or reverse DNS lookup