logstash-filter-dns 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2588795adf083d4812dc3c59973afd5109e97f78
-  data.tar.gz: 129c2b1c78212afb83dc0a76ea52072e62b31639
+  metadata.gz: 23bd0ad7f0cb35f1fbd7bf887225925d3cd8387d
+  data.tar.gz: e65faad679055d46e9f36e02e4cf244d1682fe86
 SHA512:
-  metadata.gz: 4a440cdd51ec786800ff5d387f82dcbe0359832db7ea7ec3bed9323e1ffae7495516e684f15e32e9ac2c943715b89cef754c17aa94cc5563f93f1a32e590f59f
-  data.tar.gz: ae8c839ce54b097491394a4383e77c6a6afd18ee38c69c178374ca9b0e1a20d1a3288fd3f00d750b0c9d61b2d17290569a3ec87dde443e1a4187b8cf17e19863
+  metadata.gz: 4512979f4fdad4a716b2e52501bf7216b5b9f1bf6eadf5ca570f632d691c09eff60e4f642f29c58b71416584d7722825bad0e73b4ccc17121826ae0ced48f9c7
+  data.tar.gz: ff0ef459e2952a74d6da4c997ede4af97f314dd617a0825079c1cae45336a767f4e0a8a3815a325ddfa7e796fcf6a53f98785c22c16ef806fe6dd565e50f0939

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.0.4
+  - Log a warning on missing resolve/reverse fields rather than crashing
+
 ## 3.0.3
   - Relax constraint on logstash-core-plugin-api to >= 1.60 <= 2.99
 

data/docs/index.asciidoc

@@ -12,7 +12,7 @@ START - GENERATED VARIABLES, DO NOT EDIT!
 END - GENERATED VARIABLES, DO NOT EDIT!
 ///////////////////////////////////////////
 
-[id="plugins-{type}-{plugin}"]
+[id="plugins-{type}s-{plugin}"]
 
 === Dns filter plugin
 

data/lib/logstash/filters/dns.rb

@@ -122,6 +122,12 @@ class LogStash::Filters::DNS < LogStash::Filters::Base
     @resolve.each do |field|
       is_array = false
       raw = event.get(field)
+
+      if raw.nil?
+        @logger.warn("DNS filter could not resolve missing field", :field => field)
+        next
+      end
+
       if raw.is_a?(Array)
         is_array = true
         if raw.length > 1
@@ -176,6 +182,12 @@ class LogStash::Filters::DNS < LogStash::Filters::Base
   def reverse(event)
     @reverse.each do |field|
       raw = event.get(field)
+
+      if raw.nil?
+        @logger.warn("DNS filter could not perform reverse lookup on missing field", :field => field)
+        next
+      end
+
       is_array = false
       if raw.is_a?(Array)
           is_array = true

data/logstash-filter-dns.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-dns'
-  s.version         = '3.0.4'
+  s.version         = '3.0.5'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "This filter will resolve any IP addresses from a field of your choosing."
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/dns_spec.rb

@@ -30,6 +30,27 @@ describe LogStash::Filters::DNS do
       end
     end
 
+    describe "dns reverse lookup, missing field" do
+      let(:plugin) { ::LogStash::Filters::DNS.new("reverse" => "foo") }
+      let(:event) { ::LogStash::Event.new }
+
+      before do
+        plugin.register
+        allow(plugin.logger).to receive(:warn).with(any_args)
+      end
+
+      it "should not throw an error when filtering" do
+        expect do
+          plugin.filter(event)
+        end.not_to raise_error
+      end
+
+      it "should log a warning" do
+        plugin.filter(event)
+        expect(plugin.logger).to have_received(:warn).with("DNS filter could not perform reverse lookup on missing field", :field => "foo")
+      end
+    end
+
     describe "dns reverse lookup, append" do
       config <<-CONFIG
         filter {
@@ -77,6 +98,27 @@ describe LogStash::Filters::DNS do
       end
     end
 
+    describe "dns resolve lookup, missing field" do
+      let(:plugin) { ::LogStash::Filters::DNS.new("resolve" => "foo") }
+      let(:event) { ::LogStash::Event.new }
+
+      before do
+        plugin.register
+        allow(plugin.logger).to receive(:warn).with(any_args)
+      end
+
+      it "should not throw an error when filtering" do
+        expect do
+          plugin.filter(event)
+        end.not_to raise_error
+      end
+
+      it "should log a warning" do
+        plugin.filter(event)
+        expect(plugin.logger).to have_received(:warn).with("DNS filter could not resolve missing field", :field => "foo")
+      end
+    end
+
     describe "dns fail resolve lookup, don't add tag" do
       config <<-CONFIG
         filter {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-dns
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-06-23 00:00:00.000000000 Z
+date: 2017-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement