logstash-filter-clone 3.0.6 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e80f8ceb5e269a81734e52206c69149f1faa86c08c668bf017e12ed91da17128
-  data.tar.gz: 3c75d867ceaa7723bc49aa6c5756bdd42aa5e18d6429d3dc09631ee4b32c9c79
+  metadata.gz: 047c1ddf2a3374d9e2bbe1191922564e7f9157eee8cf4ecd3e2fef4c99fe6eef
+  data.tar.gz: 9e2d9ca3326e42df4a292fb412dab7539dff7ada30e599688c67d80db9f90312
 SHA512:
-  metadata.gz: 6d0b670e87d48b5588af9455f0d64f026040e6cc0dd29dcc8156ed8521e18356c4c4fc7d565e8bd54b826d5d4c5ef0596a6fb9d3d7ee295fd871e138db2e91f5
-  data.tar.gz: e2a6fa57e05cca4a2838749cd7209a8d4a3f93f43bfd1cffa2c8f681ae358d0d9512330178561ddbc7cf59f4f843d8067046bc38b62b7f8e0ffb3dfeb666e982
+  metadata.gz: aa553ba1b4b1e111597a2bcc6c067b3d41727294ed6b6833727a515323f14636a19f9b603115a6176a346bd1924f827166df9e92d007478ffd29f018f299d7d4
+  data.tar.gz: 32d31a0c7ab4641575e2f826f37a54242efa02a25fddb24514acef5af82c426c9ddcceacdcf2655235724c31a99c7e483005010296af8c44864953eb381bcf9a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 4.0.0
+  - Make 'clones' a required option
+
 ## 3.0.6
   - Added a warning when 'clones' is empty since that results in a no-op https://github.com/logstash-plugins/logstash-filter-clone/issues/14
 

data/docs/index.asciidoc

@@ -35,7 +35,7 @@ This plugin supports the following configuration options plus the <<plugins-{typ
 [cols="<,<,<",options="header",]
 |=======================================================================
 |Setting |Input type|Required
-| <<plugins-{type}s-{plugin}-clones>> |<<array,array>>|No
+| <<plugins-{type}s-{plugin}-clones>> |<<array,array>>|Yes
 |=======================================================================
 
 Also see <<plugins-{type}s-{plugin}-common-options>> for a list of options supported by all
@@ -46,12 +46,14 @@ filter plugins.
 [id="plugins-{type}s-{plugin}-clones"]
 ===== `clones` 
 
+  * This is a required setting.
   * Value type is <<array,array>>
-  * Default value is `[]`
+  * There is no default value for this setting.
 
 A new clone will be created with the given type for each type in this list.
 
+Note: setting an empty array will not create any clones. A warning message is logged.
 
 
 [id="plugins-{type}s-{plugin}-common-options"]
-include::{include_path}/{type}.asciidoc[]
+include::{include_path}/{type}.asciidoc[]

data/lib/logstash/filters/clone.rb

@@ -13,7 +13,7 @@ class LogStash::Filters::Clone < LogStash::Filters::Base
   config_name "clone"
 
   # A new clone will be created with the given type for each type in this list.
-  config :clones, :validate => :array, :default => []
+  config :clones, :validate => :array, :required => true
 
   public
   def register

data/logstash-filter-clone.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-clone'
-  s.version         = '3.0.6'
+  s.version         = '4.0.0'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Duplicates events"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/clone_spec.rb

@@ -81,16 +81,15 @@ describe LogStash::Filters::Clone do
   describe "#register" do
     context "when clones is an empty array" do
       subject { described_class.new("clones" => []) }
-      it "should log a warning" do
+      it "logs a warning" do
         expect(subject.logger).to receive(:warn)
-        subject.register
+        expect { subject.register }.to_not raise_error
       end
     end
-    context "when clones is not empty" do
-      subject { described_class.new("clones" => ["clone1", "clone2"]) }
-      it "should not log a warning" do
-        expect(subject.logger).to_not receive(:warn)
-        subject.register
+    context "when clones is not set" do
+      subject { described_class.new }
+      it "raises an error" do
+        expect { subject.register }.to raise_error(ArgumentError)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-clone
 version: !ruby/object:Gem::Version
-  version: 3.0.6
+  version: 4.0.0
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-09-04 00:00:00.000000000 Z
+date: 2019-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement