logstash-codec-gzip_lines 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '078e37f6d953996943a59209406519d4409632e5888d347915cb7cd8d11f9f49'
-  data.tar.gz: daec1c98eb056cc95c304b6f96c4a9cd264792b81a00cb911af93ecb0883dbba
+  metadata.gz: 5a8d6e1df05470e50b267a05a2c84af5b87a233604d459e9eeadd1812951fcaa
+  data.tar.gz: 36716ee63274ba9a68ff940ac9636a0fc67b1c2996007d2fb1cce4e33c1d92e9
 SHA512:
-  metadata.gz: cc4e36c0494800f96f7dff431821ceebc8befd56724c55c9648be5cff3211d0ac6eeace84dc929e63ba30fc84b374bc0177ec7a67e076704f9bce3e5021fa883
-  data.tar.gz: 6bc5262297874c5312016a7a74c4ce944474762076d8fce5395cd772d656089e833179b82cd42bf6e3f2f59ffe56511c96ba5d72a15f9ba0a7776094b1370702
+  metadata.gz: 543609bdb2fc35724003150cf79223a42051857e8ffd74be421b57df04c1dc5532448faa06b9e58c6b79dec7066cc8babe80928771696a192ddc57045907fcd9
+  data.tar.gz: 396c1d8e258291c621cff2af6c9f4f5d584ed1acf5531571aeebc48c070c2d81e8837e786abfd6df0dee2973bf448229e34f100b6b0afcde1163a461f8c0d7a7

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.0.4
+ - Fixes issue where decode operation did not support string arguments [#3](https://github.com/logstash-plugins/logstash-codec-gzip_lines/issues/3)
+
 ## 3.0.3
   - Update gemspec summary
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012–2016 Elasticsearch <http://www.elastic.co>
+Copyright (c) 2012-2018 Elasticsearch <http://www.elastic.co>
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/lib/logstash/codecs/gzip_lines.rb

@@ -3,6 +3,7 @@ require "logstash/codecs/base"
 require "logstash/codecs/plain"
 require "logstash/json"
 require "zlib"
+require "stringio"
 
 # This codec will read gzip encoded content
 class LogStash::Codecs::GzipLines < LogStash::Codecs::Base
@@ -29,6 +30,8 @@ class LogStash::Codecs::GzipLines < LogStash::Codecs::Base
 
   public
   def decode(data)
+    data = StringIO.new(data) if data.kind_of?(String)
+
     @decoder = Zlib::GzipReader.new(data)
 
     begin

data/logstash-codec-gzip_lines.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-codec-gzip_lines'
-  s.version         = '3.0.3'
+  s.version         = '3.0.4'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Reads `gzip` encoded content"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/codecs/gzip_lines_spec.rb

@@ -26,18 +26,42 @@ describe LogStash::Codecs::GzipLines do
     str << "2010-03-12   23:51:21   SEA4   192.0.2.222   play   3914   OK   bfd8a98bee0840d9b871b7f6ade9908f   rtmp://shqshne4jdp4b6.cloudfront.net/cfx/st​  key=value   http://player.longtailvideo.com/player.swf   http://www.longtailvideo.com/support/jw-player-setup-wizard?example=204   LNX%2010,0,32,18   myvideo   p=2&q=4   flv   1\n"
 
     str.rewind
+
     str
   end
 
   describe "#decode" do
-    it "should create events from a gzip file" do
-      events = []
+    let(:compressed_log) { compress_with_gzip(uncompressed_log) }
+
+    # Legacy tests and implementation _required_ an `IO`-like object to be
+    # provided to `LogStash::Codecs::GzipLines#decode`, despite the Logstash
+    # API specifying that a `String` is provided. Continue supporting this
+    # to avoid breaking implementations that provide an IO.
+    context 'when given a StringIO' do
+      it "creates one event per line" do
+        events = []
+
+        subject.decode(compressed_log) do |event|
+          events << event
+        end
 
-      subject.decode(compress_with_gzip(uncompressed_log)) do |event|
-        events << event
+        expect(events.size).to eq(2)
       end
+    end
+
+    context 'when given a String' do
 
-      expect(events.size).to eq(2)
+      let(:compressed_log) { super().string }
+
+      it "creates one event per line" do
+        events = []
+
+        subject.decode(compressed_log) do |event|
+          events << event
+        end
+
+        expect(events.size).to eq(2)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-codec-gzip_lines
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-07 00:00:00.000000000 Z
+date: 2019-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -98,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key:
 specification_version: 4
 summary: Reads `gzip` encoded content