logic_tools 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0921177eea23a3eaec47a7c1f6f9a3885dad5759
-  data.tar.gz: c0a30c5a79a38e4113096c97398cdaf390a02b8b
+  metadata.gz: 68b786dcea5db0011ebf3b7c4c8452ce7b1fd689
+  data.tar.gz: 8685d8a03576b28ba0601ca57a3a3dc22d3b5b9f
 SHA512:
-  metadata.gz: 07164addc2bbf46d49af509e473e42daab575fa89a2494661d603a8b2f58389924b0b0f2753d0c09511e747d626636fb1da31a8f167b00461b360bb4a0a99288
-  data.tar.gz: 7e2de12c7322b4a8a67301839dc185e277f7984afebf7984e848da188ed5eacacc2274cae63d1a03b28a934395f6a484be1767523774ba2669f863dcd2c0cf14
+  metadata.gz: e77ca46d2725b382528d08d9b180ea1864c3247c5c9114f4215be309333262dce348ba0d00b982034e5b26d9b1db96406991627c361bf05115c0815b0c049c5a
+  data.tar.gz: db8fa9b7b684f0597a9c50097c53893cfa8904cededad976f871c8b22d08dd6a197cd2fbca1a8b1a0ff53d04edd74ea6d0a96f72cbe8a928a4efc2762d523075

data/README.md

@@ -2,10 +2,14 @@
 
 LogicTools is a set of command-line tools for processing logic expressions.
 The tools include:
- * simplify_qm:  for simplifying a logic expression.
- * std_conj:  for computing the conjunctive normal form of a logic expression.
- * std_dij:   for computing the disjunctive normal form a of logic expression.
- * truth_tbl: for generating the truth table of a logic expression.
+ * simplify\_qm:  for simplifying a logic expression.
+ * std\_conj:  for computing the conjunctive normal form of a logic expression.
+ * std\_dij:   for computing the disjunctive normal form a of logic expression.
+ * truth\_tbl: for generating the truth table of a logic expression.
+
+## Disclaimer
+
+There is still a nasty bug in the logic simplifying tool (simplify_qm) which makes it give a wrong result. Fortunately, it seems to happen in some rare cases only.
 
 ## Installation
 
@@ -26,21 +30,20 @@ Or install it yourself as:
 ## Usage
 
 LogicTools is a command line-based set of tool. Each tool is used as follows:
-tool "logical expression"
+tool\_name "logical expression"
 
 The logical expression is an expression where:
 * a logical variable is represented by a single alphabetical character (hence there is in total 56 possible variables);
 * a logical OR is represented by a '+' character;
 * a logical AND is represented by a '.' character (but it can be omitted);
 * a logical NOT is represented by a '~' or a '!' character;
-* opening and closing parenthesis are represented by, respectively,
-* '(' and ')' characters.
+* opening and closing parenthesis are represented by, respectively, '(' and ')' characters.
 
 Important notice: 
 * the priority among logical operators is as follows: NOT > AND > OR
 * logical expressions must be put between quotes (the '"' character).
 
-For instance the following are valid logical expression using the a,b and c variables:
+For instance the followings are valid logical expression using the a,b and c variables:
 "ab+ac"
 "a.b.c"
 "a+b+!c"
@@ -48,16 +51,16 @@ For instance the following are valid logical expression using the a,b and c vari
 
 Finally, here are a few examples of LogicTool usage:
 * simplifying the expression a+ab:
-simplify_qm "a+ab"
+simplify\_qm "a+ab"
 -> a
 * compute the conjunctive normal form of the expression a+ab:
-std_conj "a+ab"
+std\_conj "a+ab"
 -> ab+a~b
 * compute the disjunctive normal form of the expression a+ab:
-std_conj "a+ab"
+std\_dij "a+ab"
 -> (a+b)(a+~b)
 * compute the truth table of the expression a+ab:
-truth_tbl "a+ab"
+truth\_tbl "a+ab"
 -> a b
    0 0 0
    0 1 0
@@ -72,10 +75,21 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/civol/logic_tools.
+Bug reports and pull requests are welcome on GitHub at https://github.com/civol/logic\_tools.
 
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
 
+
+## To do
+### High priority
+* Fix the bug that makes simplify\_qm produce sometimes a wrong result. 
+* Downgrade the user interface: actually the interface can do much more than what is described in the documentation, but this is not really useful, so it should better to remove these features.
+
+### Low priority
+
+* Add a more efficient alternative command to simplify_qm, based on the Espresso algorithm for example.
+
+

data/lib/logic_tools/logicsimplify.rb

@@ -331,6 +331,7 @@ module LogicTools
                     NodeVar.new(vars[0])
                 end
             end
+            # print "sums = #{sums.to_s}\n"
             # Then the product
             # expr = NodeAnd.new(*sums).uniq
             if sums.size > 1 then

data/lib/logic_tools/logictree.rb

@@ -611,7 +611,12 @@ module LogicTools
                 dist = []
                 nsons.each_slice(2) do |left,right|
                     # print "left=#{left}, right=#{right}\n"
-                    dist << (right ? left.distribute(:and,right) : left)
+                    if right then
+                        dist << (left.op == :or ? left.distribute(:and,right) :
+                                                  right.distribute(:and,left))
+                    else
+                        dist << left
+                    end
                 end
                 # print "dist=#{dist}\n"
                 nsons = dist

data/lib/logic_tools/simplify_bug.txt

@@ -1,3 +1,6 @@
-~a~b~c~d+~a~bc+~ac~d+b~cd+a~b~c~d+a~bd
+*     ~a~b~c~d+~a~bc+~ac~d+b~cd+a~b~c~d+a~bd
 got:  ~ac~d+~b~c~d+~bcd+b~cd
-good: ~b~c~d+b~cd+a~bd+~a~bc+~ac~d
+good: ~ac~d+a~bd+~b~c~d+~bcd+b~cd
+FIXED!
+
+

data/lib/logic_tools/version.rb

@@ -1,3 +1,3 @@
 module LogicTools
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logic_tools
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Lovic Gauthier
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-04 00:00:00.000000000 Z
+date: 2016-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler