loggregator_emitter 0.0.15.pre → 0.0.16

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    loggregator_emitter (0.0.15.pre)
+    loggregator_emitter (0.0.16)
       beefcake (~> 0.3.7)
 
 GEM

data/lib/loggregator_emitter/emit.rb

@@ -31,10 +31,10 @@ module LoggregatorEmitter
     end
 
     def emit_message(app_id, message, type)
-      if app_id
-        lm = create_log_message(app_id, message, type)
-        send_message(lm)
-      end
+      return unless app_id && message && message.strip.length > 0
+
+      lm = create_log_message(app_id, message, type)
+      send_message(lm)
     end
 
     def create_log_message(app_id, message, type)

data/loggregator_emitter.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "loggregator_emitter"
-  spec.version       = '0.0.15.pre'
+  spec.version       = '0.0.16'
   spec.authors       = ["Pivotal"]
   spec.email         = ["cf-eng@pivotallabs.com"]
   spec.description   = "Library to emit data to Loggregator"

data/spec/loggregator_emitter/emit_spec.rb

@@ -53,13 +53,17 @@ describe LoggregatorEmitter do
         @server.start
       end
 
+      after do
+        @server.stop
+      end
+
       it "successfully writes protobuffers using ipv4" do
         emitter = make_emitter("0.0.0.0")
         emitter.send(emit_method, "my_app_id", "Hello there!")
         emitter.send(emit_method, "my_app_id", "Hello again!")
         emitter.send(emit_method, nil, "Hello again!")
 
-        @server.wait_for_messages_and_stop(2)
+        @server.wait_for_messages(2)
 
         messages = @server.messages
 
@@ -79,7 +83,7 @@ describe LoggregatorEmitter do
         emitter = make_emitter("::1")
         emitter.send(emit_method, "my_app_id", "Hello there!")
 
-        @server.wait_for_messages_and_stop(1)
+        @server.wait_for_messages(1)
 
         messages = @server.messages
         expect(messages.length).to eq 1
@@ -90,25 +94,43 @@ describe LoggregatorEmitter do
         emitter = make_emitter("localhost")
         emitter.send(emit_method, "my_app_id", "Hello there!")
 
-        @server.wait_for_messages_and_stop(1)
+        @server.wait_for_messages(1)
 
         messages = @server.messages
         expect(messages.length).to eq 1
         expect(messages[0].message).to eq "Hello there!"
       end
+
+      it "swallows empty messages" do
+        emitter = make_emitter("localhost")
+        emitter.send(emit_method, "my_app_id", nil)
+        emitter.send(emit_method, "my_app_id", "")
+        emitter.send(emit_method, "my_app_id", "   ")
+
+        sleep 0.5
+
+        messages = @server.messages
+        expect(messages.length).to eq 0
+      end
     end
   end
 
   describe "source id" do
-    let(:emit_message) do
-      server = FakeLoggregatorServer.new(free_port)
-      server.start
+    before do
+      @server = FakeLoggregatorServer.new(free_port)
+      @server.start
+    end
 
-      @emitter.emit_error("my_app_id", "Hello there!")
+    after do
+      @server.stop
+    end
+
+    let(:emit_message) do
+       @emitter.emit_error("my_app_id", "Hello there!")
 
-      server.wait_for_messages_and_stop(2)
+      @server.wait_for_messages(2)
 
-      server.messages[0]
+      @server.messages[0]
     end
 
     it "can be nil" do

data/spec/support/fake_loggregator_server.rb

@@ -19,14 +19,16 @@ class FakeLoggregatorServer
     bind_and_record(0, @sockets[1], "::1")
   end
 
-  def wait_for_messages_and_stop(number_expected_messages)
+  def wait_for_messages(number_expected_messages)
     max_tries = 0
     while messages.length < number_expected_messages
       sleep 0.2
       max_tries += 1
       break if max_tries > 10
     end
+  end
 
+  def stop
     @sockets.each { |socket| socket.close}
     @threads.each { |thread| Thread.kill(thread) }
   end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: loggregator_emitter
 version: !ruby/object:Gem::Version
-  version: 0.0.15.pre
-  prerelease: 7
+  version: 0.0.16
+  prerelease: 
 platform: ruby
 authors:
 - Pivotal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-09 00:00:00.000000000 Z
+date: 2013-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: beefcake
@@ -114,9 +114,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>'
+  - - ! '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
+      segments:
+      - 0
+      hash: -297387469996156866
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25