logger_facade 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a44006ba93de9dceaa753368eb3b452fe733e416
-  data.tar.gz: 654b4861ab41420d47ed09e825af6672c7a8683b
+  metadata.gz: 23cc1584b5cfa42c103b970633ce4ae8b0a53690
+  data.tar.gz: 2886973542c5e009e047e29c7c4d150e6a77d9b9
 SHA512:
-  metadata.gz: 57d9fa7a05c8819f5976d0b38296d8efa1a5a4e55a2989339ecb03ec0af7166ebb72ab3d6638350d27dbb57db693167f8b20cb7509a9ea7195bde31256aaea1c
-  data.tar.gz: da2c70344b93d61fc57d6d84804a959f56aa6977032ab149e8edc2aa003daa13b815fa5078c79fc66a9344194fe0477c8c6269649158fec4a89b20d66d079942
+  metadata.gz: 5c9fd2d2e1e416cc28da978ba219c6ff3c4202c8f99a8acb6aa41df8a15d1b1c3e64d007eb78ed18ec2e2846baa3bd037e9ca60c71a8b5bd0d0f7281a54fe616
+  data.tar.gz: a18d4667ceb7cd90e2d9b323ab0c17c4f96299a1018a9f58b1c5ff883f52e9fe47f11fbf70cda146f9626830c54362eb78e445136e68decc53d57454c69f4020

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    logger_facade (0.3.0)
+    logger_facade (0.3.1)
       airbrake (~> 4.0)
       hashie (~> 3.2)
       sucker_punch (~> 1.1)

data/lib/logger_facade/middleware/rack.rb

@@ -19,7 +19,8 @@ module LoggerFacade::Middleware
         metadata["bytes"],
         metadata["request_time"] ]
 
-      @logger.info(msg, metadata)
+      severity = get_severity(metadata["response"])
+      @logger.send(severity, msg, metadata)
     end
 
     def get_metadata(env, status, header, began_at)
@@ -39,5 +40,16 @@ module LoggerFacade::Middleware
       }
     end
 
+    def get_severity(status)
+      status = status.to_i
+      if status >= 400 and status < 500
+        :warn
+      elsif status >= 500
+        :error
+      else
+        :info
+      end
+    end
+
   end
 end

data/lib/logger_facade/plugins/airbrake.rb

@@ -2,21 +2,14 @@ require 'airbrake'
 
 module LoggerFacade::Plugins
 
-  class Airbrake
+  class Airbrake < Base
 
-    attr_reader :name, :environment
+    attr_reader :environment
 
     def initialize(environment = nil)
-      @name = "LoggerFacade::Plugins::Airbrake"
+      super("LoggerFacade::Plugins::Airbrake", { level: :error })
       @environment = environment.to_s
-
-      ::Airbrake.configure do |config|
-        config.host    = nil
-        config.port    = 80
-        config.secure  = config.port == 443
-        config.async   = true
-        config.development_environments = %w(development test)
-      end
+      set_default_airbrake_config
     end
 
     def configure(&block)
@@ -25,27 +18,17 @@ module LoggerFacade::Plugins
       end
     end
 
-    def is_debug
-      false
-    end
-
-    def trace(logger, message)
-      # do nothing
-    end
+    protected
 
-    def debug(logger, message)
-      # do nothing
-    end
+    def log(log_level, message, logger, metadata)
+      return unless is_level_active(log_level)
 
-    def info(logger, message)
-      # do nothing
+      notify(logger, message, metadata)
     end
 
-    def warn(logger, message)
-      # do nothing
-    end
+    private
 
-    def error(logger, message)
+    def notify(logger, message, metadata)
       return unless valid_config
 
       if message.is_a? Exception
@@ -55,7 +38,15 @@ module LoggerFacade::Plugins
       end
     end
 
-    private
+    def set_default_airbrake_config
+      ::Airbrake.configure do |config|
+        config.host    = nil
+        config.port    = 80
+        config.secure  = config.port == 443
+        config.async   = true
+        config.development_environments = %w(development test)
+      end
+    end
 
     def valid_config
       config = ::Airbrake.configuration

data/lib/logger_facade/version.rb

@@ -1,3 +1,3 @@
 module LoggerFacade
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/spec/unit/middleware/rack_spec.rb

@@ -45,7 +45,33 @@ describe LoggerFacade::Middleware::Rack do
       Rack::MockRequest.new(described_class.new(app)).get("/path?q=true")
     end
   end
-  
+
+  context 'severity' do
+
+    it "log 200 status to info" do
+      expect(logger).to receive(:info)
+      Rack::MockRequest.new(described_class.new(app)).get("/path")
+    end
+
+    it "log 300 status to info" do
+      expect(logger).to receive(:info)
+      Rack::MockRequest.new(described_class.new(app)).get("/path")
+    end
+
+    it "log 400 status to warn" do
+      expect(logger).to receive(:warn)
+      app = -> (env) { [400, env, "app"] }
+      Rack::MockRequest.new(described_class.new(app)).get("/path")
+    end
+
+    it "log 500 status to error" do
+      expect(logger).to receive(:error)
+      app = -> (env) { [500, env, "app"] }
+      Rack::MockRequest.new(described_class.new(app)).get("/path")
+    end
+
+  end
+
   context 'with proper metadata' do
 
     after do

data/spec/unit/plugins/airbrake_spec.rb

@@ -4,6 +4,8 @@ describe LoggerFacade::Plugins::Airbrake do
 
   subject { described_class.new(:test) }
 
+  let(:message) { "call with message" }
+
   before :each do
 
     subject.configure do |c|
@@ -39,13 +41,27 @@ describe LoggerFacade::Plugins::Airbrake do
     context("logging in #{level} level") do
 
       it("doesn't notify") do
-        message = "call with message"
         expect(::Airbrake).not_to receive(:notify_or_ignore)
         subject.send(level.to_sym, "name", message)
       end
 
     end
 
+    context("accepts metadata") do
+
+      it("logging in #{level} level with metadata") do
+        expect(::Airbrake).not_to receive(:notify_or_ignore)
+        subject.send(level.to_sym, "name", message, metadata: { context: "info" })
+      end
+
+    end
+
+  end
+
+  %w(trace debug info warn error).each do |level|
+
+
+
   end
 
   context("logging in error level") do
@@ -53,7 +69,6 @@ describe LoggerFacade::Plugins::Airbrake do
     context('with message') do
 
       it("notify") do
-        message = "call with message"
         expect(::Airbrake).to receive(:notify_or_ignore)
            .with(hash_including(
              :error_class     => "NAME::LogError",
@@ -81,6 +96,11 @@ describe LoggerFacade::Plugins::Airbrake do
 
     end
 
+    it("accepts metadata") do
+      expect(::Airbrake).to receive(:notify_or_ignore)
+      subject.error("name", message, metadata: { context: "information" })
+    end
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logger_facade
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Pedro Januário
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-08 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler