logger 1.2.7.1 → 1.2.8.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: fca3ed305eb759ed28a0ea917d653feee81fc4d399a53a44e6649d8e8389defb
+  data.tar.gz: 90cef9d07cb58cb5049c1a869ae56ec609e0dfd1befcac6053b97602e11ee609
+SHA512:
+  metadata.gz: c2c96afb68a6e3a22e53673119f673bd6490d6d1c5c184da06677633648c0e86ce6c7eaacbb4dca55c4d3c800ea8d7708c55235a854987c98ed3f20feee185f9
+  data.tar.gz: c5e39c441722c99cd6fee091939303d22448a329543699b1deac011d3500f3cf939987ff6c4c64db1cff526a746e1e6050f9af801f057f3aca5181ea734599fa

data/lib/logger.rb

@@ -1,7 +1,6 @@
 # logger.rb - simple logging utility
-# Copyright (C) 2000-2003, 2005, 2008  NAKAMURA, Hiroshi <nahi@ruby-lang.org>.
+# Copyright (C) 2000-2003, 2005, 2008, 2011  NAKAMURA, Hiroshi <nahi@ruby-lang.org>.
 #
-# Author:: NAKAMURA, Hiroshi  <nakahiro@sarion.co.jp>
 # Documentation:: NAKAMURA, Hiroshi and Gavin Sinclair
 # License::
 #   You can redistribute it and/or modify it under the same terms of Ruby's
@@ -41,6 +40,21 @@ require 'monitor'
 # want to know about the program's internal state, and would set them to
 # +DEBUG+.
 #
+# **Note**: Logger does not escape or sanitize any messages passed to it.
+# Developers should be aware of when potentially malicious data (user-input)
+# is passed to Logger, and manually escape the untrusted data:
+#
+#   logger.info("User-input: #{input.dump}")
+#   logger.info("User-input: %p" % input)
+#
+# You can use Logger#formatter= for escaping all data.
+#
+#   original_formatter = Logger::Formatter.new
+#   logger.formatter = proc { |severity, datetime, progname, msg|
+#     original_formatter.call(severity, datetime, progname, msg.dump)
+#   }
+#   logger.info(input)
+#
 # === Example
 #
 # A simple example demonstrates the above explanation:
@@ -175,15 +189,8 @@ require 'monitor'
 
 
 class Logger
-  VERSION = "1.2.7.1"
-  id, name, rev = %w$Id$
-  if name
-    name = name.chomp(",v")
-  else
-    name = File.basename(__FILE__)
-  end
-  rev ||= "v#{VERSION}"
-  ProgName = "#{name}/#{rev}"
+  VERSION = "1.2.8.1"
+  ProgName = "#{File.basename(__FILE__)}/#{VERSION}"
 
   class Error < RuntimeError; end
   class ShiftingError < Error; end # not used after 1.2.7. just for compat.
@@ -210,6 +217,8 @@ class Logger
     @default_formatter.datetime_format = datetime_format
   end
 
+  # Returns the date format (string passed to +strftime+) being used (it's set
+  # using datetime_format=)
   def datetime_format
     @default_formatter.datetime_format
   end
@@ -290,8 +299,8 @@ class Logger
   # +message+::
   #   The log message.  A String or Exception.
   # +progname+::
-  #   Program name string.  Can be omitted.  Treated as a message if no +message+ and
-  #   +block+ are given.
+  #   Program name string.  Can be omitted.  Treated as a message if no
+  #   +message+ and +block+ are given.
   # +block+::
   #   Can be omitted.  Called to get a message string if +message+ is nil.
   #
@@ -530,7 +539,7 @@ private
         @mutex.synchronize do
           @dev.close rescue nil
         end
-      rescue Exception => ignored
+      rescue Exception
         @dev.close rescue nil
       end
     end
@@ -593,7 +602,7 @@ private
       if FileTest.exist?(age_file)
         # try to avoid filename crash caused by Timestamp change.
         idx = 0
-        # .99 can be overriden; avoid too much file search with 'loop do'
+        # .99 can be overridden; avoid too much file search with 'loop do'
         while idx < 100
           idx += 1
           age_file = "#{@filename}.#{postfix}.#{idx}"

data/test/logger/test_logger.rb

@@ -311,10 +311,14 @@ class TestLogDevice < Test::Unit::TestCase
     end
     # create logfile whitch is already exist.
     logdev = d(@filename)
-    logdev.write('world')
-    logfile = File.read(@filename)
-    assert_equal(2, logfile.split(/\n/).size)
-    assert_match(/^helloworld$/, logfile)
+    begin
+      logdev.write('world')
+      logfile = File.read(@filename)
+      assert_equal(2, logfile.split(/\n/).size)
+      assert_match(/^helloworld$/, logfile)
+    ensure
+      logdev.close
+    end
   end
 
   def test_write
@@ -328,13 +332,19 @@ class TestLogDevice < Test::Unit::TestCase
     assert_equal("msg2\n\n", msg)
     #
     logdev = d(LogExcnRaiser.new)
+    class << (stderr = '')
+      alias write <<
+    end
+    $stderr, stderr = stderr, $stderr
     begin
       assert_nothing_raised do
         logdev.write('hello')
       end
     ensure
       logdev.close
+      $stderr, stderr = stderr, $stderr
     end
+    assert_equal "log writing failed. disk is full\n", stderr
   end
 
   def test_close
@@ -458,6 +468,7 @@ class TestLogDevice < Test::Unit::TestCase
       assert(File.exist?(filename2))
       assert(File.exist?(filename3))
     ensure
+      logger.close if logger
       [filename1, filename2, filename3].each do |filename|
         File.unlink(filename) if File.exist?(filename)
       end
@@ -485,20 +496,32 @@ class TestLoggerApplication < Test::Unit::TestCase
 
   def test_start
     @app.set_log(@filename)
-    @app.level = Logger::UNKNOWN
-    @app.start # logs FATAL log 
-    assert_equal(1, File.read(@filename).split(/\n/).size)
+    begin
+      @app.level = Logger::UNKNOWN
+      @app.start # logs FATAL log 
+      assert_equal(1, File.read(@filename).split(/\n/).size)
+    ensure
+      @app.logger.close
+    end
   end
 
   def test_logger
     @app.level = Logger::WARN
     @app.set_log(@filename)
-    assert_equal(Logger::WARN, @app.logger.level)
+    begin
+      assert_equal(Logger::WARN, @app.logger.level)
+    ensure
+      @app.logger.close
+    end
     @app.logger = logger = Logger.new(STDOUT)
     assert_equal(logger, @app.logger)
     assert_equal(Logger::WARN, @app.logger.level)
     @app.log = @filename
-    assert(logger != @app.logger)
-    assert_equal(Logger::WARN, @app.logger.level)
+    begin
+      assert(logger != @app.logger)
+      assert_equal(Logger::WARN, @app.logger.level)
+    ensure
+      @app.logger.close
+    end
   end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logger
 version: !ruby/object:Gem::Version
-  version: 1.2.7.1
-  prerelease: 
+  version: 1.2.8.1
 platform: ruby
 authors:
 - NAKAMURA, Hiroshi
@@ -10,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-11 00:00:00.000000000 Z
+date: 2019-01-19 00:00:00.000000000 Z
 dependencies: []
 description: Provides a simple logging utility for outputting messages.
 email:
@@ -25,26 +24,24 @@ files:
 homepage: https://github.com/ruby/logger
 licenses:
 - BSD-2-Clause
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.23.2
+rubygems_version: 3.0.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Provides a simple logging utility for outputting messages.
 test_files: []