loga 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a962ebefb507146c9e7e2586efb356fd9615db7d
-  data.tar.gz: d1cc277cb5364e6b017d1c2e8f5524da815d9f88
+  metadata.gz: dbc2c1df2c8703af85a48cec027481b51e963a7d
+  data.tar.gz: 81e5b8afc0c7bf47a65e68b2682ceb3f764b56c1
 SHA512:
-  metadata.gz: cd8aa79bea6fc3f231a11da411e4157ba61b9c7ed26bd016cf6627a211ca74cc46e41577ee1a3480c046323d5cc9a936bcea175c3bdb9f52aef4a8af91bae60b
-  data.tar.gz: af8f9e6abb19c279a1b3ca59310e33a0123e6b9e7d618d6a4e8bdca14ba237f2c8f929377d3f95c03157e06add6e0b011ba0bfe111154da2eb4411191c0992c0
+  metadata.gz: 35ac2f6b11c4adb23ebf976bef30c6e3bdd59da23ecf62e93a1ebc74d8a49378e2bc87ec9725622c8518b1f0da75d080080604d8993fd9adef065f7dd440d43d
+  data.tar.gz: bb92378034091e09808ad93a4e549102a2173330bdd8eaf372eee3b93b6f6fe79e6b883479b481bee0fd7f245a46a8ccc055ab7786562d1d26bc6bb46ad84108

data/.rubocop.yml

@@ -5,7 +5,11 @@ AllCops:
     - 'spec/fixtures/**/*'
     - '*.gemspec'
 
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArguments:
   Enabled: true
   EnforcedStyleForMultiline: comma
 
@@ -17,3 +21,9 @@ Style/FormatString:
 
 Style/PerlBackrefs:
   Enabled: false
+
+Style/ExtraSpacing:
+  Enabled: false
+
+Style/SpaceAroundOperators:
+  Enabled: false

data/circle.yml

@@ -1,15 +1,11 @@
 dependencies:
   override:
-    - rvm-exec 1.9.3-p392 bundle install -j 4
-    - rvm-exec 1.9.3-p392 bundle exec appraisal install -j 4
     - rvm-exec 2.0.0-p353 bundle install -j 4
     - rvm-exec 2.0.0-p353 bundle exec appraisal install -j 4
     - rvm-exec 2.2.2 bundle install -j 4
     - rvm-exec 2.2.2 bundle exec appraisal install -j 4
 test:
   override:
-    - RACK_ENV=development rvm-exec 1.9.3-p392 bundle exec appraisal rspec
-    - RACK_ENV=production  rvm-exec 1.9.3-p392 bundle exec appraisal rspec
     - RACK_ENV=development rvm-exec 2.0.0-p353 bundle exec appraisal rspec
     - RACK_ENV=production  rvm-exec 2.0.0-p353 bundle exec appraisal rspec
     - RACK_ENV=development rvm-exec 2.2.2      bundle exec appraisal rspec

data/lib/loga/configuration.rb

@@ -29,7 +29,7 @@ module Loga
     end
 
     def initialize!
-      @service_name.to_s.strip!
+      @service_name = service_name.to_s.strip
       @service_version = compute_service_version
 
       initialize_logger

data/lib/loga/rack/request.rb

@@ -52,7 +52,7 @@ module Loga
         parameter_filter.filter(hash)
       end
 
-      KV_RE   = '[^&;=]+'
+      KV_RE   = '[^&;=]+'.freeze
       PAIR_RE = /(#{KV_RE})=(#{KV_RE})/
       def filtered_query_string
         query_string.gsub(PAIR_RE) do |_|

data/lib/loga/rack/request_id.rb

@@ -3,7 +3,7 @@ require 'securerandom'
 require 'active_support/core_ext/string/access'
 require 'active_support/core_ext/object/blank'
 
-# rubocop:disable Metrics/LineLength, Lint/AssignmentInCondition, Style/GuardClause
+# rubocop:disable Metrics/LineLength, Lint/AssignmentInCondition
 module Loga
   module Rack
     # Makes a unique request id available to the action_dispatch.request_id env variable (which is then accessible through

data/lib/loga/version.rb

@@ -1,3 +1,3 @@
 module Loga
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'.freeze
 end

data/loga.gemspec

@@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rack-test'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec',    '~> 3.0.0'
-  spec.add_development_dependency 'rubocop',  '~> 0.30.0'
+  spec.add_development_dependency 'rubocop',  '~> 0.40.0'
   spec.add_development_dependency 'timecop'
 end

data/spec/spec_helper.rb

@@ -28,7 +28,7 @@ when /unit/
   rspec_pattern = 'unit/**/*_spec.rb'
   require 'loga'
 else
-  fail 'BUNDLE_GEMFILE is unknown. Ensure the appraisal is present in Appraisals'
+  raise 'BUNDLE_GEMFILE is unknown. Ensure the appraisal is present in Appraisals'
 end
 
 RSpec.configure do |config|

data/spec/unit/loga/formatter_spec.rb

@@ -20,15 +20,13 @@ describe Loga::Formatter do
                               'host'          => host,
                               'short_message' => be_a(String),
                               'timestamp'     => be_a(Float),
-                              'level'         => 6,
-                             )
+                              'level'         => 6)
     end
 
     it 'includes Loga additional fields' do
       expect(json).to include('_service.name'    => service_name,
                               '_service.version' => service_version,
-                              '_tags'            => [],
-                             )
+                              '_tags'            => [])
     end
 
     it 'outputs the timestamp in seconds since UNIX epoch' do

data/spec/unit/loga/rack/logger_spec.rb

@@ -57,7 +57,7 @@ describe Loga::Rack::Logger do
     let(:response_status)  { 200 }
 
     context 'when an exception is raised' do
-      let(:app) {  ->(_env) { fail exception } }
+      let(:app) {  ->(_env) { raise exception } }
 
       it 'does not rescue the exception' do
         expect { subject.call(env) }.to raise_error(StandardError)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: loga
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Funding Circle
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.30.0
+        version: 0.40.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.30.0
+        version: 0.40.0
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement