log_parser_notifier 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c53c7da371f4a6fd7f062ca48bf0e0c98e1840d
-  data.tar.gz: 16090b43f86e33cadfbe5b1752bde2c9b28f1057
+  metadata.gz: 36101de3a98440c4c74be32a2951adbca54a43db
+  data.tar.gz: 276b3bab5bc44d9b98a753c9d7331c4b7a744283
 SHA512:
-  metadata.gz: eab6a4ce0768bb4069faeb74cf9a36f1509a0153a88f90fdf0966c5deea8f4be4121ab36f1c0ccc9388745390e8f0b8b70f144ce33b9c8e91e24692493c24462
-  data.tar.gz: 1f5fc1f06017d1392a57a6a086490b80c59634c8405b13f71627dbd402edc0e3a3684daab7d9a7044ea14bd31749d690116ac360ed145cf63e337b67a55b91a3
+  metadata.gz: fced35f02dbc4537717e824bc3a0f9e1748f11134c9552da5e2eded9d1bb7d73f84557bca66a9fb36f53eccd1eb31f66789cb41ae4d80752a432472d052fc9e0
+  data.tar.gz: a697b16fe1364cfd5e3118141884d7e44f2316d241f71ca98821158a51f4a05cff091e63c2d2bc6f9f1815e9b30ce101e1fc6850fdf860a2b0fce518b8743636

data/lib/log_parser_notifier/rails_request_notifier.rb

@@ -22,7 +22,10 @@ module LogParserNotifier
         tags = %W(controller:#{request[:controller]} action:#{request[:action]} con_act:#{request[:controller]}##{request[:action]})
 
         LogParserNotifier.logger.debug("processing request for #{request[:controller]}##{request[:action]} with status: #{request[:status]} it is complete: #{request.completed?}")
-        if request.completed? && request[:status] >= 200 && request[:status] < 400
+        if request.completed? &&
+           !request[:status].nil? &&
+           request[:status] >= 200 &&
+           request[:status] < 400
           statsd.increment 'rails.requests', tags: tags
           statsd.timing 'rails.load_time', request[:duration] * 1000, tags: tags
 

data/lib/log_parser_notifier/version.rb

@@ -1,3 +1,3 @@
 module LogParserNotifier
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/spec/rails_request_notifier_spec.rb

@@ -45,6 +45,20 @@ module LogParserNotifier
       end
     end
 
+    describe 'grape failed requests' do
+      before { @logs = RailsLogRequests.grape_error_request }
+      subject { rails_request_notifier.parse_and_trigger_notifications }
+
+      it 'should correctly parse the grape request' do
+        expect { subject }.to_not raise_error(NoMethodError)
+      end
+
+      it 'should record the number of failed requests' do
+        expect_any_instance_of(Statsd).to receive(:increment).with('rails.failed_requests', tags: %w(controller: action: con_act:#))
+        subject
+      end
+    end
+
     describe 'redirect request' do
       before { @logs = RailsLogRequests.redirect_request }
       after { rails_request_notifier.parse_and_trigger_notifications }

data/spec/support/rails_log_requests.rb

@@ -30,6 +30,14 @@ I, [2015-08-24T07:36:43.695000 #19020]  INFO -- : Completed 200 OK in 800ms (Vie
 )
     end
 
+    def self.grape_error_request
+StringIO.new %Q(Started GET "/api/v1/resumes/7297793" for 99.8.124.171 at 2015-11-19 08:04:34 +0000
+
+ActiveRecord::RecordNotFound (Couldn't find Resume with id=7297793 [WHERE `resumes`.`user_id` = 18217112]):
+  app/api/resumes_api.rb:75:in `block (2 levels) in <class:ResumesApi>'
+)
+    end
+
     def self.failed_request
 StringIO.new %Q(I, [2015-08-24T07:35:11.541000 #19020]  INFO -- : Started GET "/documents/9293/preview/?page=0" for 50.31.29.217 at 2015-08-24 07:35:11 +0000
 I, [2015-08-24T07:35:11.549000 #19020]  INFO -- : Processing by DocumentsController#preview as JSON

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: log_parser_notifier
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Josh Moore
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-17 00:00:00.000000000 Z
+date: 2015-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request-log-analyzer