lock_diff 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 710f6d73a8a6dc99a4548e1229558ec52858ec92
-  data.tar.gz: 810a68c2702dea60aca3b557c45803786ba63787
+  metadata.gz: 350868a953714a43814533531c9ffe6bcac986b6
+  data.tar.gz: 0b4e8f25a0cc2501a91b8be9964e8d7e1766d449
 SHA512:
-  metadata.gz: 570cc8fc9ce39fd75efa77b477d80dc9e21d40d8b84d7de252619f43cb1f6cb7096c16afadb3c6cbde66563bfc710c8f5e666a16c958bc4c6da4a4d6986ca1bc
-  data.tar.gz: 144411f78c8c4734fae9a581a7cf105f0fc1b0a4085ee7cf4050cd0da8aa5e5ff5946e2e9d95083e4b7a6aea615cf3f2459ba865423878c330a3681149ece311
+  metadata.gz: 6b10659add1b0534294ac1f64fb495d0368048fee0ab86346d7257d8043ccadc549722ff167c66887720f2fa91b5150dfea9dd5c602d7ab1f2623c9b38f483a0
+  data.tar.gz: cb0ad1c60fca7a06ceb238194189480c141bc72ae87b0186f973e241b3dc07c6b673f5627b65d0848b1b26f2e25e2dfd3df9aa575df50bb67f4871c0a2e37fe0

data/README.md

@@ -2,9 +2,9 @@
 
 [![CircleCI](https://circleci.com/gh/vividmuimui/lock_diff.svg?style=svg)](https://circleci.com/gh/vividmuimui/lock_diff)
 
-This Gem is generate `changelog url`, `github compare link` by lock file of Github pull request. And comment to pull request.
+This Gem is generates `changelog url`, `github compare link` by lock file of Github pull request. And comment to pull request.
 
-Like as this.
+Like this.
 
 > https://github.com/vividmuimui/rails_tutorial/pull/26#issuecomment-312491272
 > ![image](https://user-images.githubusercontent.com/1803598/27770516-f5774972-5f7a-11e7-87a6-7c3cbf1de745.png)
@@ -38,7 +38,7 @@ Require `GITHUB_ACCESS_TOKEN` environment.
 ```sh
 $ lock_diff
 Usage: lock_diff [options]
-    -r, --repository=REPOSITORY      required. Like as rails/rails
+    -r, --repository=REPOSITORY      required. Like as "user/repository"
     -n, --number=PULL_REQUEST_NUMBER required
         --post-comment=true or false dafault=false
 ```

data/exe/lock_diff

@@ -8,7 +8,7 @@ options = {
 }
 opt = OptionParser.new
 
-opt.on('-r', '--repository=REPOSITORY', 'required. Like as rails/rails') { |v| options[:repository] = v }
+opt.on('-r', '--repository=REPOSITORY', 'required. Like as "user/repository"') { |v| options[:repository] = v }
 opt.on('-n', '--number=PULL_REQUEST_NUMBER', 'required') { |v| options[:number] = v }
 opt.on('--post-comment=true or false', 'dafault=false') { |v| options[:post_comment] = v }
 opt.parse!

data/lib/lock_diff/gem/gem.rb

@@ -4,36 +4,28 @@ module LockDiff
       extend Forwardable
 
       attr_reader :name
-      def_delegator :ruby_gem, :github_url
+      def_delegator :@ruby_gem, :github_url
 
       def initialize(name)
         @name = name
+        @ruby_gem = RubyGem.new(name)
       end
 
       def url
-        ruby_gem.github_url || ruby_gem.homepage_url
+        @ruby_gem.github_url || @ruby_gem.homepage_url
       end
 
       def change_log_url
-        Github::ChangeLogUrlFinder.new(repository: repository, github_url: ruby_gem.github_url).call
+        @change_log_url ||= Github::ChangeLogUrlFinder.new(repository: repository, github_url: @ruby_gem.github_url).call
       end
-      memoize :change_log_url
 
       def repository
-        Github::RepositoryNameDetector.new(ruby_gem.github_url).call
+        Github::RepositoryNameDetector.new(@ruby_gem.github_url).call
       end
 
       def tag_names
-        LockDiff.client.tag_names(repository)
+        @tag_names ||= LockDiff.client.tag_names(repository)
       end
-      memoize :tag_names
-
-      private
-
-      def ruby_gem
-        RubyGem.new(name)
-      end
-      memoize :ruby_gem
 
     end
   end

data/lib/lock_diff/gem/pr_lockfile.rb

@@ -10,19 +10,16 @@ module LockDiff
       end
 
       def path
-        @pr.find_content_path("Gemfile.lock")
+        @path ||= @pr.find_content_path("Gemfile.lock")
       end
-      memoize :path
 
       def base_file
-        LockDiff.client.file(@pr.repository, path: path, ref: @pr.base_sha)
+        @base_file ||= LockDiff.client.file(@pr.repository, path: path, ref: @pr.base_sha)
       end
-      memoize :base_file
 
       def head_file
-        LockDiff.client.file(@pr.repository, path: path, ref: @pr.head_sha)
+        @head_file ||= LockDiff.client.file(@pr.repository, path: path, ref: @pr.head_sha)
       end
-      memoize :head_file
 
     end
   end

data/lib/lock_diff/gem/ruby_gem.rb

@@ -18,9 +18,8 @@ module LockDiff
       end
 
       def github_url
-        Github::GithubUrlDetector.new([source_code_url, homepage_url]).call
+        @github_url ||= Github::GithubUrlDetector.new([source_code_url, homepage_url]).call
       end
-      memoize :github_url
 
     end
   end

data/lib/lock_diff/github/client.rb

@@ -6,9 +6,8 @@ module LockDiff
 
     class << self
       def client
-        Github::Client.new(Github::AccessToken.new)
+        @client ||= Github::Client.new(Github::AccessToken.new)
       end
-      memoize :client
     end
 
     class Client

data/lib/lock_diff/version.rb

@@ -1,3 +1,3 @@
 module LockDiff
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/lock_diff.rb

@@ -1,7 +1,6 @@
 require "logger"
 require "forwardable"
 
-require "lock_diff/core_ext/memoize"
 require "lock_diff/formatter/github_markdown"
 require "lock_diff/gem"
 require "lock_diff/github"
@@ -10,7 +9,7 @@ require "lock_diff/version"
 
 module LockDiff
   class << self
-    attr_accessor :client_class, :formatter, :strategy, :memoize_response, :logger
+    attr_accessor :client_class, :formatter, :strategy, :logger
 
     def client
       client_class.client
@@ -32,6 +31,5 @@ module LockDiff
   self.client_class = Github
   self.formatter = Formatter::GithubMarkdown
   self.strategy = Gem
-  self.memoize_response = true
   self.logger = Logger.new(nil)
 end

data/lock_diff.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["vividmuimui"]
   spec.email         = ["vivid.muimui@gmail.com"]
 
-  spec.summary       = %q{Generate links for Gemfile.lock's diff and post to PullRequest}
-  spec.description   = %q{Generate links for Gemfile.lock's diff and post to PullRequest}
+  spec.summary       = %q{Generate links by Gemfile.lock of Github PR, and post comment to it.}
+  spec.description   = %q{Generate links by Gemfile.lock of Github PR, and post comment to it.}
   # spec.homepage      = "https://github.com/vividmuimui/lock_diff"
   spec.homepage      = ""
   spec.license       = "MIT"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lock_diff
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - vividmuimui
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-02 00:00:00.000000000 Z
+date: 2017-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -108,7 +108,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Generate links for Gemfile.lock's diff and post to PullRequest
+description: Generate links by Gemfile.lock of Github PR, and post comment to it.
 email:
 - vivid.muimui@gmail.com
 executables:
@@ -128,7 +128,6 @@ files:
 - bin/setup
 - exe/lock_diff
 - lib/lock_diff.rb
-- lib/lock_diff/core_ext/memoize.rb
 - lib/lock_diff/formatter/github_markdown.rb
 - lib/lock_diff/gem.rb
 - lib/lock_diff/gem/diff_info.rb
@@ -172,5 +171,5 @@ rubyforge_project:
 rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: Generate links for Gemfile.lock's diff and post to PullRequest
+summary: Generate links by Gemfile.lock of Github PR, and post comment to it.
 test_files: []

data/lib/lock_diff/core_ext/memoize.rb

@@ -1,58 +0,0 @@
-module LockDiff
-  module CorExt
-    module Memoize
-      def self.included(base)
-        base.extend(ClassMethods)
-      end
-
-      def has_memoized?(key)
-        memoized_table.key?(key)
-      end
-
-      def memoize(key, value)
-        memoized_table[key] = value
-      end
-
-      def memoized(key)
-        memoized_table[key]
-      end
-
-      def memoized_table
-        @memoized_table ||= {}
-      end
-
-      module ClassMethods
-        def memoize(method_name)
-          original_visibility =
-            case
-            when protected_instance_methods.include?(method_name)
-              :protected
-            when private_instance_methods.include?(method_name)
-              :private
-            else
-              :public
-            end
-
-          define_method("#{method_name}_with_memoize") do |*args, &block|
-            if LockDiff.memoize_response
-              if has_memoized?(method_name)
-                memoized(method_name)
-              else
-                memoize(method_name, send("#{method_name}_without_memoize", *args, &block))
-              end
-            else
-              send("#{method_name}_without_memoize", *args, &block)
-            end
-          end
-          send(original_visibility, "#{method_name}_with_memoize")
-
-          alias_method "#{method_name}_without_memoize", method_name
-          alias_method method_name, "#{method_name}_with_memoize"
-        end
-      end
-
-    end
-  end
-end
-
-Object.send(:include, LockDiff::CorExt::Memoize)