locasms 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3206ae592ae0a88e7f3622634cfc9eb3bfa1f61
-  data.tar.gz: c183953bd011a3b8515fee13e4d35e59219d3f43
+  metadata.gz: 364b1c84ab3b08af2dbcbc97454606fa196b0c0f
+  data.tar.gz: 91f8f1d10f22abce7d0e18a9b2b6437905d61ef3
 SHA512:
-  metadata.gz: 3aa9723d090e9549008084b59217db867dd5584ead9e2b6b54f137c4f0b17af73d010236bbe6ea480828c42b1e818280e410fdeaace6e0fe4be821f04004cd36
-  data.tar.gz: 4d46ad710feacdf3eae061b1c3a69cdf48754ea50c4c48150b66b75a67cf1ded264988d1f100a81d9a180b0b14b61653cae3752c5cfc27d866ca3b74db1503af
+  metadata.gz: 4469e3539da0f5f3b9ccbd1376a43b87884fc5c6e9d3024aed4e764452eabb83a5c76c0c8b1fd4cb329008ec7ac78a34e901b69b5d0855ee31938804d5bdb0fa
+  data.tar.gz: b03a24dca3edf92af9cb3bcae54acd2285f2beeaef3b2c9df15cc5ffb1f763e6ebbf5302f7e3a7b865187d8a88f96055473830e079913c09ca712b00c8060c0c

data/.travis.yml

@@ -1,6 +1,7 @@
 language: ruby
 rvm:
-  - 1.9
   - 2.0
+  - 2.1
+  - 2.2
 env:
   - TRAVIS=true

data/README.md

@@ -1,4 +1,4 @@
-# locasms [![Build Status](https://travis-ci.org/mcorp/locasms.png?branch=master)](https://travis-ci.org/mcorp/locasms) [![Dependency Status](https://gemnasium.com/mcorp/locasms.png)](https://gemnasium.com/mcorp/locasms)
+# locasms [![Build Status](https://travis-ci.org/mcorp/locasms.png?branch=master)](https://travis-ci.org/mcorp/locasms) [![Dependency Status](https://gemnasium.com/mcorp/locasms.png)](https://gemnasium.com/mcorp/locasms) [![Code Climate](https://codeclimate.com/github/mcorp/locasms.png)](https://codeclimate.com/github/mcorp/locasms)
 
 Client to consume [LocaSMS api's][0].
 

data/lib/locasms/version.rb

@@ -1,3 +1,3 @@
 module LocaSMS
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/lib/locasms.rb

@@ -6,9 +6,11 @@ autoload :RestClient, 'rest_client'
 autoload :Logger,     'logger'
 
 module LocaSMS
-  autoload :Client,     'locasms/client'
-  autoload :Exception,  'locasms/exception'
-  autoload :Numbers,    'locasms/numbers'
+  autoload :Client, 'locasms/client'
+  autoload :Exception, 'locasms/exception'
+  autoload :InvalidLogin, 'locasms/exception'
+  autoload :InvalidOperation, 'locasms/exception'
+  autoload :Numbers, 'locasms/numbers'
   autoload :RestClient, 'locasms/rest_client'
 
   module Helpers

data/locasms.gemspec

@@ -6,8 +6,8 @@ require 'locasms/version'
 Gem::Specification.new do |spec|
   spec.name          = "locasms"
   spec.version       = LocaSMS::VERSION
-  spec.authors       = ["Adilson Carvalho"]
-  spec.email         = ["lc.adilson@gmail.com"]
+  spec.authors       = ["Adilson Carvalho", "Leonardo Saraiva", "Marco Carvalho"]
+  spec.email         = ["lc.adilson@gmail.com", "vyper@maneh.org", "marco.carvalho.swasthya@gmail.com"]
   spec.description   = %q{Cliente para o serviço de disparo de SMS da LocaSMS}
   spec.summary       = %q{Cliente para o serviço de disparo de SMS da LocaSMS}
   spec.homepage      = "https://github.com/mcorp/locasms"
@@ -19,11 +19,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 0.9.2'
+  spec.add_development_dependency 'rake', '~> 10.4.2'
 
   # test stuff
-  spec.add_development_dependency 'rspec', '~> 2.5'
-  spec.add_development_dependency 'fuubar', '~> 1.1.0'
+  spec.add_development_dependency 'rspec', '~> 3.2'
+  spec.add_development_dependency 'fuubar', '~> 2.0.0'
 
   # run tests automatically
   spec.add_development_dependency 'guard'

data/spec/lib/locasms/client_spec.rb

@@ -5,18 +5,18 @@ describe LocaSMS::Client do
   subject { LocaSMS::Client.new :login, :password, rest_client: rest_client }
 
   describe '.initialize' do
-    it { subject.login.should be(:login) }
-    it { subject.password.should be(:password) }
+    it { expect(subject.login).to be(:login) }
+    it { expect(subject.password).to be(:password) }
   end
 
   describe '#deliver' do
     it 'Should send SMS' do
-      subject.should_receive(:numbers)
+      expect(subject).to receive(:numbers)
         .once
         .with([:a, :b, :c])
         .and_return('XXX')
 
-      rest_client.should_receive(:get)
+      expect(rest_client).to receive(:get)
         .once
         .with(:sendsms, msg: 'given message', numbers:'XXX')
         .and_return({})
@@ -25,30 +25,30 @@ describe LocaSMS::Client do
     end
 
     it 'Should not send SMS' do
-      subject.should_receive(:numbers)
+      expect(subject).to receive(:numbers)
         .once
         .with([:a, :b, :c])
         .and_raise(LocaSMS::Exception)
 
-      rest_client.should_receive(:get).never
+      expect(rest_client).to receive(:get).never
 
-      lambda{ subject.deliver('given message', :a, :b, :c) }.should raise_error(LocaSMS::Exception)
+      expect { subject.deliver('given message', :a, :b, :c) }.to raise_error(LocaSMS::Exception)
     end
   end
 
   describe '#deliver_at' do
     it 'Should send SMS' do
-      subject.should_receive(:numbers)
+      expect(subject).to receive(:numbers)
         .once
         .with([:a, :b, :c])
         .and_return('XXX')
 
-      LocaSMS::Helpers::DateTimeHelper.should_receive(:split)
+      expect(LocaSMS::Helpers::DateTimeHelper).to receive(:split)
         .once
         .with(:datetime)
         .and_return(%w[date time])
 
-      rest_client.should_receive(:get)
+      expect(rest_client).to receive(:get)
         .once
         .with(:sendsms, msg: 'given message', numbers:'XXX', jobdate: 'date', jobtime: 'time')
         .and_return({})
@@ -57,25 +57,25 @@ describe LocaSMS::Client do
     end
 
     it 'Should not send SMS' do
-      subject.should_receive(:numbers)
+      expect(subject).to receive(:numbers)
         .once
         .with([:a, :b, :c])
         .and_raise(LocaSMS::Exception)
 
-      LocaSMS::Helpers::DateTimeHelper.should_receive(:split)
+      expect(LocaSMS::Helpers::DateTimeHelper).to receive(:split)
         .once
         .with(:datetime)
         .and_return(%w[date time])
 
-      rest_client.should_receive(:get).never
+      expect(rest_client).to receive(:get).never
 
-      lambda{ subject.deliver_at('given message', :datetime, :a, :b, :c) }.should raise_error(LocaSMS::Exception)
+      expect { subject.deliver_at('given message', :datetime, :a, :b, :c) }.to raise_error(LocaSMS::Exception)
     end
   end
 
   describe '#balance' do
     it 'Should check param assignment' do
-      rest_client.should_receive(:get)
+      expect(rest_client).to receive(:get)
         .once
         .with(:getbalance)
         .and_return({})
@@ -92,7 +92,7 @@ describe LocaSMS::Client do
         campaign_release: :releasesms
       }[method]
 
-      rest_client.should_receive(:get)
+      expect(rest_client).to receive(:get)
         .once
         .with(rest_method, id: '12345')
         .and_return({})

data/spec/lib/locasms/helpers/date_time_helper_spec.rb

@@ -5,7 +5,7 @@ describe LocaSMS::Helpers::DateTimeHelper do
 
   describe '#parse' do
     it 'Should call the class method' do
-      subject.should_receive(:parse)
+      expect(subject).to receive(:parse)
         .once
         .with(:value)
 
@@ -15,7 +15,7 @@ describe LocaSMS::Helpers::DateTimeHelper do
 
   describe '#split' do
     it 'Should call the class method' do
-      subject.should_receive(:split)
+      expect(subject).to receive(:split)
         .once
         .with(:value)
 
@@ -38,12 +38,12 @@ describe LocaSMS::Helpers::DateTimeHelper do
 
   describe '.split' do
     it 'Should break a date into date and time' do
-      subject.should_receive(:parse)
+      expect(subject).to receive(:parse)
         .once
         .with(:datetime)
         .and_return(Time.parse('1977-03-14 14:12:00'))
 
-      subject.split(:datetime).should == %w(14/03/1977 14:12)
+      expect(subject.split(:datetime)).to eq(%w(14/03/1977 14:12))
     end
   end
 

data/spec/lib/locasms/numbers_spec.rb

@@ -5,74 +5,102 @@ describe LocaSMS::Numbers do
 
   describe '.initialize' do
     subject do
-      LocaSMS::Numbers.any_instance
-        .should_receive(:evaluate)
-        .once
-        .with([:numbers])
-        .and_return({ good: [1,3], bad: [2,4] })
+      expect_any_instance_of(LocaSMS::Numbers).
+        to receive(:evaluate).
+        once.
+        with([:numbers]).
+        and_return(good: [1, 3], bad: [2, 4])
       LocaSMS::Numbers.new :numbers
     end
 
-    it{ subject.good.should == [1,3] }
-    it{ subject.bad.should == [2,4]  }
+    it { expect(subject.good).to eq([1, 3]) }
+    it { expect(subject.bad).to eq([2, 4]) }
   end
 
   describe '#normalize' do
-    it{ subject.normalize('+55 (11) 8888-9999').should == %w(551188889999) }
-    it{ subject.normalize('55', ['11', '22']).should == %w(55 11 22) }
-    it{ subject.normalize(['55', 'ZZ', '22']).should == %w(55 ZZ 22) }
-    it{ subject.normalize('55,44,33', ['ZZ', '22,11']).should == %w(55 44 33 ZZ 22 11) }
-    it{ subject.normalize(55, [11, 22]).should == %w(55 11 22) }
-    it{ subject.normalize('Z').should == ['Z'] }
-    it{ subject.normalize(nil).should == [] }
+    it do 
+      expect(subject.normalize('+55 (11) 8888-9999')).to(
+        eq(%w(551188889999))
+      )
+    end
+    it do
+      expect(subject.normalize('55', ['11', '22'])).to(
+        eq(%w(55 11 22))
+      )
+    end
+    it do
+      expect(subject.normalize(['55', 'ZZ', '22'])).to(
+        eq(%w(55 ZZ 22))
+      )
+    end
+    it do
+      expect(subject.normalize('55,44,33', ['ZZ', '22,11'])).to(
+        eq(%w(55 44 33 ZZ 22 11))
+      )
+    end
+    it do 
+      expect(subject.normalize(55, [11, 22])).to(
+        eq(%w(55 11 22))
+      )
+    end
+    it { expect(subject.normalize('Z')).to eq(['Z']) }
+    it { expect(subject.normalize(nil)).to eq([]) }
   end
 
   describe '#valid_number?' do
-    it{ subject.valid_number?('+55 (11) 8888-9999').should be_false }
-    it{ subject.valid_number?('88889999').should be_false }
-    it{ subject.valid_number?('988889999').should be_false }
-    it{ subject.valid_number?('ABC').should be_false }
-    it{ subject.valid_number?('').should be_false }
-    it{ subject.valid_number?(nil).should be_false }
+    it { expect(subject.valid_number?('+55 (11) 8888-9999')).to be_falsey }
+    it { expect(subject.valid_number?('88889999')).to be_falsey }
+    it { expect(subject.valid_number?('988889999')).to be_falsey }
+    it { expect(subject.valid_number?('ABC')).to be_falsey }
+    it { expect(subject.valid_number?('')).to be_falsey }
+    it { expect(subject.valid_number?(nil)).to be_falsey }
 
-    it{ subject.valid_number?('1188889999').should be_true }
-    it{ subject.valid_number?('11988889999').should be_true }
+    it { expect(subject.valid_number?('1188889999')).to be_truthy }
+    it { expect(subject.valid_number?('11988889999')).to be_truthy }
   end
 
   describe '#evaluate' do
     it 'Should separate numbers in good and bad' do
-      subject.should_receive(:normalize)
-        .once
-        .with([:numbers])
-        .and_return([:good, :bad])
-      subject.should_receive(:valid_number?)
-        .once
-        .with(:good)
-        .and_return(true)
-      subject.should_receive(:valid_number?)
-        .once
-        .with(:bad)
-        .and_return(false)
-      subject.evaluate(:numbers).should == { good: [:good], bad: [:bad] }
+      expect(subject).to receive(:normalize).
+        once.
+        with([:numbers]).
+        and_return([:good, :bad])
+      expect(subject).to receive(:valid_number?).
+        once.
+        with(:good).
+        and_return(true)
+      expect(subject).to receive(:valid_number?).
+        once.
+        with(:bad).
+        and_return(false)
+      expect(subject.evaluate(:numbers)).to(
+        eq(good: [:good], bad: [:bad])
+      )
     end
   end
 
   describe '#bad?' do
-    it{ subject.should_receive(:bad).once.and_return([ ]); subject.bad?.should be_false }
-    it{ subject.should_receive(:bad).once.and_return([1]); subject.bad?.should be_true  }
+    it do
+      expect(subject).to receive(:bad).once.and_return([ ])
+      expect(subject.bad?).to be_falsey
+    end
+    it do
+      expect(subject).to receive(:bad).once.and_return([1])
+      expect(subject.bad?).to be_truthy
+    end
   end
 
   describe '#to_s' do
     it 'Should return and empty string' do
-      subject.to_s.should == ''
+      expect(subject.to_s).to eq('')
     end
 
     it 'Should return all good numbers in a string comma separated' do
-      subject.should_receive(:good)
-        .once
-        .and_return([1,2,3,4])
-      subject.to_s.should == '1,2,3,4'
+      expect(subject).to receive(:good).
+        once.
+        and_return([1, 2, 3, 4])
+      expect(subject.to_s).to eq('1,2,3,4')
     end
   end
 
-end
+end

data/spec/lib/locasms/rest_client_spec.rb

@@ -4,8 +4,8 @@ describe LocaSMS::RestClient do
   describe '.initialize' do
     context 'When giving proper initialization parameters' do
       subject { LocaSMS::RestClient.new :url, :params }
-      it { subject.base_url.should be(:url) }
-      it { subject.base_params.should be(:params) }
+      it { expect(subject.base_url).to be(:url) }
+      it { expect(subject.base_params).to be(:params) }
     end
   end
 
@@ -16,31 +16,31 @@ describe LocaSMS::RestClient do
   describe '#params_for' do
     subject { LocaSMS::RestClient.new :url, { b1: 'X' } }
 
-    it{ subject.params_for(:action).should == {action: :action, b1: 'X'} }
-    it{ subject.params_for(:action, p1: 10).should == {action: :action, b1: 'X', p1: 10} }
+    it { expect(subject.params_for(:action)).to eq({action: :action, b1: 'X'}) }
+    it { expect(subject.params_for(:action, p1: 10)).to eq({action: :action, b1: 'X', p1: 10}) }
   end
 
   describe '#parse_response' do
     subject { LocaSMS::RestClient.new :url, :params }
 
     it 'Should raise exception on invalid operation' do
-      lambda{ subject.parse_response(:action, '0:OPERACAO INVALIDA') }.should raise_error(LocaSMS::InvalidOperation)
+      expect { subject.parse_response(:action, '0:OPERACAO INVALIDA') }.to raise_error(LocaSMS::InvalidOperation)
     end
 
     it 'Should raise exception on a failed response' do
-      lambda{ subject.parse_response(:action, '{"status":0,"data":null,"msg":"FALHA EPICA"}') }.should raise_error(LocaSMS::Exception, 'FALHA EPICA')
+      expect { subject.parse_response(:action, '{"status":0,"data":null,"msg":"FALHA EPICA"}') }.to raise_error(LocaSMS::Exception, 'FALHA EPICA')
     end
 
     it 'Should raise exception on a failed login attempt' do
-      lambda{ subject.parse_response(:action, '{"status":0,"data":null,"msg":"FALHA AO REALIZAR LOGIN"}') }.should raise_error(LocaSMS::InvalidLogin)
+      expect { subject.parse_response(:action, '{"status":0,"data":null,"msg":"FALHA AO REALIZAR LOGIN"}') }.to raise_error(LocaSMS::InvalidLogin)
     end
 
     it 'Should return the non-json value as a json' do
-      subject.parse_response(:action, 'non-json return').should == {'status' => 1, 'data' => 'non-json return', "msg" => nil}
+      expect(subject.parse_response(:action, 'non-json return')).to eq({'status' => 1, 'data' => 'non-json return', "msg" => nil})
     end
 
     it 'Should return a parsed json return' do
-      subject.parse_response(:action, '{"status":1,"data":28,"msg":null}').should == {'status' => 1, 'data' => 28, "msg" => nil}
+      expect(subject.parse_response(:action, '{"status":1,"data":28,"msg":null}')).to eq({'status' => 1, 'data' => 28, "msg" => nil})
     end
   end
 

metadata

@@ -1,14 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: locasms
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Adilson Carvalho
+- Leonardo Saraiva
+- Marco Carvalho
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-17 00:00:00.000000000 Z
+date: 2015-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,42 +32,42 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 10.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 10.4.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: fuubar
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 2.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -167,6 +169,8 @@ dependencies:
 description: Cliente para o serviço de disparo de SMS da LocaSMS
 email:
 - lc.adilson@gmail.com
+- vyper@maneh.org
+- marco.carvalho.swasthya@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -213,7 +217,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Cliente para o serviço de disparo de SMS da LocaSMS