locales_panel 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98e51d12e2736c77504068954a72302ea42777ac
-  data.tar.gz: 1e68bb0516af17c81c62c4ba3d5abc2d6304a2b5
+  metadata.gz: afaa0acd3da6432f5873d66a771e287ffa411185
+  data.tar.gz: 0fed03c8e8d14057aa3d426ed3c0f3b4e35259ec
 SHA512:
-  metadata.gz: 54270f53bc1757822692c7b26c7ae9bd4561dc7b2c310a5875941d5c5c1a608d076b1213ac7c02fbaf95740af8d2c70139c454e11bcd9989eff474698caba0b4
-  data.tar.gz: 97c77093c56ab52eb74d2411815de1aee41263baffb4e7e7107b7f2207553f9eae57ee686f6979a936b6f17299a0fc4bd4a1db267905a627377eabe2a7500296
+  metadata.gz: 7626041cbf2d73a5ff23c44c0bf3656d26741b725e0d1a3346199bc8465bfbc02881795903a97e32386aca16a5d253db17da6a36f86ba59e0fe3843942132dca
+  data.tar.gz: 6585a358eeab09b86718f3001b40f5c940f25ee71e2499a8ea85559b29153f733863b4f7b26389c150a0102e4e284972acefe684347475afa635689574cbb53c

data/README.md

@@ -1,15 +1,8 @@
-**Major issues, too early for use**
-- shows readonly locales from application's gems
-- could be hacked to overwrite non locale files
-
----
 # Locales Panel
 
 Change translations directly in a published site.
 
-Use by visiting `http://.../locales/edit`. Saving  will overwrite YAML locales files. Tool is dedicated for UAT server configuration, where the user can see live changes without server restart.
-
-When ready for upload, push files from the server to your application's git repository.
+Use by visiting `http://.../locales/edit`. Saving will overwrite YAML locales files.
 
 # Installation
 
@@ -21,26 +14,18 @@ Run in console:
 
     $ bundle
 
-To enable live changes, be sure to run with Rails configuration option (typical for non-production):
-
-    config.cache_classes = false
-
 # Join
 
 Create pull request or contact on [skype chat](http://kapustka.net/chat?user=kapustka.maciek).
 
-**priority todo**
-- fix opening gem locales
-- fix security of file save
-
-**todos**
-- css
-- reload I18n after change
+**todo**
+- hook for authorization
+- configurable route
 - download link
 - add to git link
-- work with rails 3
+- check with rails 3
 - validation
 - highlight untranslated
-- hook for authorization
-- configurable route
-- translated views
+- translate editor itself
+- css
+- tests for indentation fix, security fix and I18n.reload

data/app/controllers/locales_controller.rb

@@ -1,15 +1,18 @@
 class LocalesController < ApplicationController
+  before_action { @paths = Rails.configuration.i18n.load_path.delete_if{|path|path['/gems/']}}
+
   def edit
     @files = []
-    Rails.configuration.i18n.load_path.each do |path|
-      @files << { path: path, name: File::basename(path)[0..-5], content: File.read(path) }
+    @paths.each do |path|
+      @files << { path: path, name: File::basename(path)[0..-5], content: File.read(path).gsub("\n",'&#x000A;').html_safe }
     end
   end
 
   def update
-    params[:files].each do |file|
+    params[:files].keep_if{|file| file[:path].in? @paths}.each do |file|
       File.write file[:path], file[:content].gsub("\r",'')
     end
+    I18n.reload!
     redirect_to edit_locales_path
   end
 end

data/app/views/locales/edit.html.erb

@@ -1,8 +1,9 @@
 <%= form_tag(locales_path, method: :put) do %>
     <% @files.each do |file| %>
         <h2><%= file[:name] %></h2>
-        <input type="hidden" name="files[][path]" value="<%= file[:path] %>" />
+        <input type="hidden" name="files[][path]" value="<%= file[:path] %>"/>
         <textarea name="files[][content]" cols="80" rows="20" wrap="off" style="width:100%"><%= file[:content] %></textarea>
     <% end %>
-    <input type="submit" value="submit" />
-<% end %>
+    <input type="submit" value="submit"/>
+<% end %>
+

data/lib/locales_panel/version.rb

@@ -1,3 +1,3 @@
 module LocalesPanel
-  VERSION = '0.1.3'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: locales_panel
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Maciej Kasprzyk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-13 00:00:00.000000000 Z
+date: 2015-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails