localeapp 0.5.1 → 0.5.2

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# Version 0.5.2
+
+* Fix bug with pulling translations changing file permissions
+
 # Version 0.5.1
 
 * Fix bug with encoding of response from http_client

data/README.md

@@ -144,20 +144,20 @@ can be disabled in a similar way to polling and sending:
 
     config.reloading_environments = []
 
-### Inviting other developers and translators
+## Inviting other developers and translators
 
 You can invite other developers and translators via localeapp.com.  Developers
 have access to all the content and all the locales. Translators are restricted
 to editing only the locales you give them access too.
 
-### Adding a locale
+## Adding a locale
 
 If we find an unknown locale during an import we'll add it to your project.
 You can also add a new locale to a project via localeapp.com. This will create
 missing translations for every translation key. You will need to restart any
 listeners completely to pick up the new locale.
 
-### Syck, Psych, and creating YAML
+## Syck, Psych, and creating YAML
 
 Since ruby 1.9.3-p0 Psych has been the default YAML engine in Ruby. Psych is
 based on libyaml and fixes a number of issues with the previous YAML library,
@@ -168,13 +168,13 @@ but it does write YAML differently to Psych so you will notice differences
 between exporting directly from localeapp.com and doing localeapp pull on the
 command line unless you're using 1.9.3+ or have installed Psych as a gem.
 
-### Proxies
+## Proxies
 
 If you need to go through a proxy server, you can configure it with:
 
     config.proxy = "http://my.proxy.com:8888"
 
-### SSL Certificate verification
+## SSL Certificate verification
 
 localeapp.com uses https everywhere but certificate validation is turned off by
 default. This is because ruby doesn't know how to read the certs from the OSX
@@ -188,7 +188,7 @@ See [this article on Ruby Inside][1] for some more details.
 
 [1]: http://www.rubyinside.com/how-to-cure-nethttps-risky-default-https-behavior-4010.html
 
-### Support and feedback
+## Support and feedback
 
 You can contact us via the support link at the bottom of the page or emailing
 support@localeapp.com

data/lib/localeapp/updater.rb

@@ -71,6 +71,8 @@ module Localeapp
         raise "Could not write locale file, please make sure that #{target_dir} exists and is writeable"
       end
 
+      permissions = File.stat(file_name).mode if File.exist?(file_name)
+
       temp_file = Tempfile.new(File.basename(file_name), temp_dir)
       yield temp_file
       temp_file.close
@@ -79,6 +81,10 @@ module Localeapp
       # so rename will work
       FileUtils.mv(temp_file.path, "#{file_name}.tmp")
       File.rename("#{file_name}.tmp", file_name)
+
+      # chmod the file to its previous permissions
+      # or set default permissions to 644
+      File.chmod(permissions ? permissions : 0644 , file_name)
     end
   end
 end

data/lib/localeapp/version.rb

@@ -1,3 +1,3 @@
 module Localeapp
-  VERSION = "0.5.1"
+  VERSION = "0.5.2"
 end

data/spec/localeapp/updater_spec.rb

@@ -156,4 +156,29 @@ JA
       File.read(File.join(@yml_dir, 'en.yml')).should match(/foo: ! 'bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar '/m)
     end
   end
+
+  it "doesn't change a yml file's permissions" do
+    filepath = File.join(@yml_dir, 'en.yml')
+    File.chmod(0777, filepath)
+    permissions = lambda { File.stat(filepath).mode.to_s(8) }
+    expect {
+      do_update(
+        'translations' => {
+          'en' => { 'foo' => 'bar'}
+        },
+        'locales' => ['en']
+      )
+    }.to_not change(permissions, :call)
+  end
+
+  it "creates new yml files chmodded with 644" do
+    do_update({
+      'translations' => {
+        'ja' => { 'foo' => 'bar'}
+      },
+      'locales' => ['ja']
+    })
+    mode = File.stat(File.join(@yml_dir, 'ja.yml')).mode # octal
+    mode.to_s(8)[3, 3].should == "644"
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: localeapp
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 15
   prerelease: 
   segments: 
   - 0
   - 5
-  - 1
-  version: 0.5.1
+  - 2
+  version: 0.5.2
 platform: ruby
 authors: 
 - Christopher Dell
@@ -16,12 +16,13 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-08-15 00:00:00 Z
+date: 2012-09-12 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: i18n
+  type: :runtime
   prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -30,12 +31,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id001
+  requirement: *id001
 - !ruby/object:Gem::Dependency 
   name: json
+  type: :runtime
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -44,12 +45,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id002
+  requirement: *id002
 - !ruby/object:Gem::Dependency 
   name: rest-client
+  type: :runtime
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -58,12 +59,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id003
+  requirement: *id003
 - !ruby/object:Gem::Dependency 
   name: ya2yaml
+  type: :runtime
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -72,12 +73,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id004
+  requirement: *id004
 - !ruby/object:Gem::Dependency 
   name: gli
+  type: :runtime
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -86,12 +87,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id005
+  requirement: *id005
 - !ruby/object:Gem::Dependency 
   name: rake
+  type: :development
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -100,12 +101,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :development
-  version_requirements: *id006
+  requirement: *id006
 - !ruby/object:Gem::Dependency 
   name: rspec
+  type: :development
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  version_requirements: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -116,12 +117,12 @@ dependencies:
         - 11
         - 0
         version: 2.11.0
-  type: :development
-  version_requirements: *id007
+  requirement: *id007
 - !ruby/object:Gem::Dependency 
   name: yard
+  type: :development
   prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  version_requirements: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -132,12 +133,12 @@ dependencies:
         - 6
         - 7
         version: 0.6.7
-  type: :development
-  version_requirements: *id008
+  requirement: *id008
 - !ruby/object:Gem::Dependency 
   name: RedCloth
+  type: :development
   prerelease: false
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  version_requirements: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -148,12 +149,12 @@ dependencies:
         - 2
         - 9
         version: 4.2.9
-  type: :development
-  version_requirements: *id009
+  requirement: *id009
 - !ruby/object:Gem::Dependency 
   name: aruba
+  type: :development
   prerelease: false
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  version_requirements: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -164,12 +165,12 @@ dependencies:
         - 4
         - 11
         version: 0.4.11
-  type: :development
-  version_requirements: *id010
+  requirement: *id010
 - !ruby/object:Gem::Dependency 
   name: fakeweb
+  type: :development
   prerelease: false
-  requirement: &id011 !ruby/object:Gem::Requirement 
+  version_requirements: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -180,8 +181,7 @@ dependencies:
         - 3
         - 0
         version: 1.3.0
-  type: :development
-  version_requirements: *id011
+  requirement: *id011
 description: Synchronizes i18n translation keys and content with localeapp.com so you don't have to manage translations by hand.
 email: 
 - chris@tigrish.com
@@ -291,7 +291,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: localeapp
-rubygems_version: 1.8.24
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: Easy i18n translation management with localeapp.com