loan_creator 0.12.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a85f9d61c45df0f972e329a33a1beedbedc1e0090d481613e93ad90d66dea98
-  data.tar.gz: 7dab891b9a5d3acefb8d6cd43eef0bdb5cfe511631f5674ae655046cda11ca25
+  metadata.gz: 2e7d8a7b39adf42e2c93e977c82ecf6c53f5695716cc5ef291a6b5a0963e0dd5
+  data.tar.gz: a4ed3fcf50360222a3795846d0d1ec3367126b851e6381a8ffbfc98ba972a709
 SHA512:
-  metadata.gz: f92cd167e57a06b93169011fe8c178e7e3f434dc4c99c4a9458fb29501dd643d6011da2b8af7adfd94dd7412e7e0cd9566f281c5ff3331815daa2aa39bc27d58
-  data.tar.gz: c21997ee861f81b7ad4a28b334f2f1d4258e2df54eb01865de79e0b30dae5abba1d4a6771055564a6e349d16ad07ea82e6aac57a3f35ef70fee07c9ba8f94f6a
+  metadata.gz: e6e6465cc26a14667894139cc4f57e1bab128ebd77a01559d2b04d1ba77b3aecc9c5ec457fe5ba7a1c1cea4ac9f7021fa6f26d16646f6241167ade85b9251d98
+  data.tar.gz: 144466496ce6a6b8895fca5657cf07db090e0ca8834b04ac84631a0dbfe71e89d8dfce2d8697358f905486edae636b1014cc049597c267fa0ec829088966d406

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+v0.12.1
+-------------------------
+#### Bugfix
+- `Bullet` and `Uncapitalized Bullet` now manage roundings as other loan types
+
 v0.12.0
 -------------------------
 - improve argument error management and allow amount equal to zero.

data/lib/loan_creator/bullet.rb

@@ -33,16 +33,19 @@ module LoanCreator
     end
 
     def compute_capitalized_interests(timetable)
-      if multi_part_interests_calculation && term_dates? && (timetable_term_dates[timetable.current_index] + 1.year) < @due_on
-        multi_part_interests(
-          timetable_term_dates[timetable.current_index],
-          @due_on,
-          annual_interests_rate,
-          amount_to_capitalize
-        )
-      else
-        compute_period_generated_interests(periodic_interests_rate(timetable_term_dates[timetable.current_index], @due_on))
-      end
+      periodic_theoric_interests =
+        if multi_part_interests_calculation && term_dates? && (timetable_term_dates[timetable.current_index] + 1.year) < @due_on
+          multi_part_interests(
+            timetable_term_dates[timetable.current_index],
+            @due_on,
+            annual_interests_rate,
+            amount_to_capitalize
+          )
+        else
+          compute_period_generated_interests(periodic_interests_rate(timetable_term_dates[timetable.current_index], @due_on))
+        end
+
+      apply_interests_roundings(periodic_theoric_interests)
     end
 
     def compute_term(timetable)

data/lib/loan_creator/common.rb

@@ -295,5 +295,22 @@ module LoanCreator
     def amount_to_capitalize
       @crd_beginning_of_period + @due_interests_beginning_of_period
     end
+
+    def apply_interests_roundings(periodic_theoric_interests)
+      @period_theoric_interests = periodic_theoric_interests
+      @delta_interests = @period_theoric_interests - @period_theoric_interests.round(2)
+      @accrued_delta_interests += @delta_interests
+      @amount_to_add = bigd(
+        if @accrued_delta_interests >= bigd('0.01')
+          '0.01'
+        elsif @accrued_delta_interests <= bigd('-0.01')
+          '-0.01'
+        else
+          '0'
+        end
+      )
+      @accrued_delta_interests -= @amount_to_add
+      @period_theoric_interests.round(2) + @amount_to_add
+    end
   end
 end

data/lib/loan_creator/linear.rb

@@ -28,7 +28,7 @@ module LoanCreator
       @crd_beginning_of_period = @crd_end_of_period
       @due_interests_beginning_of_period = @due_interests_end_of_period
 
-      @period_theoric_interests = (
+      period_theoric_interests =
         # if period is more than a year
         if multi_part_interests_calculation && term_dates? && (timetable_term_dates[timetable.current_index] + 1.year) < @due_on
           multi_part_interests(
@@ -40,21 +40,8 @@ module LoanCreator
         else
           period_theoric_interests(periodic_interests_rate(timetable_term_dates[timetable.current_index], @due_on))
         end
-      )
 
-      @delta_interests = @period_theoric_interests - @period_theoric_interests.round(2)
-      @accrued_delta_interests += @delta_interests
-      @amount_to_add = bigd(
-        if @accrued_delta_interests >= bigd('0.01')
-          '0.01'
-        elsif @accrued_delta_interests <= bigd('-0.01')
-          '-0.01'
-        else
-          '0'
-        end
-      )
-      @accrued_delta_interests -= @amount_to_add
-      @period_interests = @period_theoric_interests.round(2) + @amount_to_add
+      @period_interests = apply_interests_roundings(period_theoric_interests)
       @period_capital = period_capital
       @total_paid_capital_end_of_period += @period_capital
       @total_paid_interests_end_of_period += @period_interests

data/lib/loan_creator/standard.rb

@@ -27,20 +27,8 @@ module LoanCreator
       computed_periodic_interests_rate = periodic_interests_rate(timetable_term_dates[timetable.current_index], @due_on)
 
       @crd_beginning_of_period = @crd_end_of_period
-      @period_theoric_interests = period_theoric_interests(@index, computed_periodic_interests_rate)
-      @delta_interests = @period_theoric_interests - @period_theoric_interests.round(2)
-      @accrued_delta_interests += @delta_interests
-      @amount_to_add = bigd(
-        if @accrued_delta_interests >= bigd('0.01')
-          '0.01'
-        elsif @accrued_delta_interests <= bigd('-0.01')
-          '-0.01'
-        else
-          '0'
-        end
-      )
-      @accrued_delta_interests -= @amount_to_add
-      @period_interests = @period_theoric_interests.round(2) + @amount_to_add
+
+      @period_interests = apply_interests_roundings(period_theoric_interests(@index, computed_periodic_interests_rate))
       @period_capital = period_capital(@index, computed_periodic_interests_rate)
       @total_paid_capital_end_of_period += @period_capital
       @total_paid_interests_end_of_period += @period_interests

data/lib/loan_creator/uncapitalized_bullet.rb

@@ -34,7 +34,8 @@ module LoanCreator
 
     def compute_interests(due_date, timetable)
       computed_periodic_interests_rate = periodic_interests_rate(timetable_term_dates[timetable.current_index], due_date)
-      amount.mult(bigd(computed_periodic_interests_rate), BIG_DECIMAL_DIGITS)
+
+      apply_interests_roundings(amount.mult(bigd(computed_periodic_interests_rate), BIG_DECIMAL_DIGITS))
     end
 
     def compute_term(timetable)

data/lib/loan_creator/version.rb

@@ -1,3 +1,3 @@
 module LoanCreator
-  VERSION = '0.12.0'.freeze
+  VERSION = '0.12.1'.freeze
 end

data/loan_creator.gemspec

@@ -27,6 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'pry', '~> 0.13.1'
   spec.add_development_dependency 'table_print', '~> 1.5'
 
+
   spec.add_runtime_dependency 'bigdecimal'
   spec.add_runtime_dependency 'activesupport'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: loan_creator
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.1
 platform: ruby
 authors:
 - thibaulth
@@ -9,10 +9,10 @@ authors:
 - younes.serraj
 - Antoine Becquet
 - Jerome Drevet
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-12 00:00:00.000000000 Z
+date: 2022-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -140,7 +140,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
+description: 
 email:
 - thibault@capsens.eu
 - nicolas.besnard@capsens.eu
@@ -188,7 +188,7 @@ homepage: https://github.com/CapSens/loan-creator
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -204,7 +204,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Create and update timetables from input data
 test_files: []