loan_creator 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f7d2dcd74aa8a01bb25577eaf1c6ea05daba9eef071d76119d7ad00773fe0f7
-  data.tar.gz: ed40fe1ff5610cbef9bc5c5c92f31095a0eaa6ad745a8f194861e65d5b8e316b
+  metadata.gz: 9a85f9d61c45df0f972e329a33a1beedbedc1e0090d481613e93ad90d66dea98
+  data.tar.gz: 7dab891b9a5d3acefb8d6cd43eef0bdb5cfe511631f5674ae655046cda11ca25
 SHA512:
-  metadata.gz: 16256ac04047a1b505e37dddec9299d5409d1940dfe2d7271ebc0cc5207bfb5301f3375fbf3f793cb5a70dbacab3e5a7c3c6bd87d07c6449faeba2dd73368f71
-  data.tar.gz: 4fe77879f1dfa61adecaf5d30dcf2dd5d6c501c1d82b75232cd106ffa827c440d52326a37c25bc939f445010ab7c4d256527e92edef2124d3c6ed8369337c0eb
+  metadata.gz: f92cd167e57a06b93169011fe8c178e7e3f434dc4c99c4a9458fb29501dd643d6011da2b8af7adfd94dd7412e7e0cd9566f281c5ff3331815daa2aa39bc27d58
+  data.tar.gz: c21997ee861f81b7ad4a28b334f2f1d4258e2df54eb01865de79e0b30dae5abba1d4a6771055564a6e349d16ad07ea82e6aac57a3f35ef70fee07c9ba8f94f6a

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+v0.12.0
+-------------------------
+- improve argument error management and allow amount equal to zero.
+
+v0.11.0
+-------------------------
+- add `multi_part_interests_calculation` option.
+
+v0.10.0
+-------------------------
+- fix `term_dates` options, notably with `starts_on`.
+
 v0.9.1
 -------------------------
 - add spec importer `scripts/convert_export_to_spec.rb {csv_url}`

data/lib/loan_creator/common.rb

@@ -107,20 +107,34 @@ module LoanCreator
       OPTIONAL_ATTRIBUTES.each { |k, v| instance_variable_set(:"@#{k}", @options.fetch(k, v)) }
     end
 
-    def validate(key, &block)
-      raise unless block.call(instance_variable_get(:"@#{key}"))
-    rescue => e
-      raise ArgumentError.new([key, e.message].join(': '))
+    def validate(message, &block)
+      raise ArgumentError.new(message) unless block.call
     end
 
     def validate_attributes
-      validate(:period) { |v| PERIODS_IN_MONTHS.keys.include?(v) } unless term_dates?
-      validate(:amount) { |v| v.is_a?(BigDecimal) && v > 0 }
-      validate(:annual_interests_rate) { |v| v.is_a?(BigDecimal) && v >= 0 }
-      validate(:starts_on) { |v| v.is_a?(Date) }
-      validate(:duration_in_periods) { |v| v.is_a?(Integer) && v > 0 }
-      validate(:deferred_in_periods) { |v| v.is_a?(Integer) && v >= 0 && v < duration_in_periods }
-      validate_term_dates if term_dates?
+      validate("amount #{@amount} must be positive") do
+        @amount.is_a?(BigDecimal) && @amount >= 0
+      end
+      validate("annual_interests_rate #{@annual_interests_rate} must be positive") do
+        @annual_interests_rate.is_a?(BigDecimal) && @annual_interests_rate >= 0
+      end
+      validate("starts_on #{@starts_on} must be a date but is a #{@starts_on.class}") do
+        @starts_on.is_a?(Date)
+      end
+      validate("duration_in_periods #{@duration_in_periods} must be positive") do
+        @duration_in_periods.is_a?(Integer) && @duration_in_periods > 0
+      end
+      validate("deferred_in_periods #{@deferred_in_periods} must be positive and less than duration_in_periods #{@duration_in_periods}") do
+        @deferred_in_periods.is_a?(Integer) && @deferred_in_periods >= 0 && @deferred_in_periods < duration_in_periods
+      end
+      if term_dates?
+        validate_term_dates
+      else
+        validate("period #{@period} must be in #{PERIODS_IN_MONTHS}") do
+          PERIODS_IN_MONTHS.keys.include?(@period)
+        end
+      end
+
     end
 
     def validate_term_dates
@@ -135,10 +149,18 @@ module LoanCreator
     def validate_initial_values
       return if initial_values.blank?
 
-      validate(:total_paid_capital_end_of_period) { |v| v.is_a?(BigDecimal) && v >= 0 }
-      validate(:total_paid_interests_end_of_period) { |v| v.is_a?(BigDecimal) && v >= 0 }
-      validate(:accrued_delta_interests) { |v| v.is_a?(BigDecimal) }
-      validate(:starting_index) { |v| v.is_a?(Integer) && v >= 0 }
+      validate("total_paid_capital_end_of_period #{@total_paid_capital_end_of_period} must be positive") do
+        @total_paid_capital_end_of_period.is_a?(BigDecimal) && @total_paid_capital_end_of_period >= 0
+      end
+      validate("total_paid_interests_end_of_period #{@total_paid_interests_end_of_period} must be positive") do
+        @total_paid_interests_end_of_period.is_a?(BigDecimal) && @total_paid_interests_end_of_period >= 0
+      end
+      validate("accrued_delta_interests must be a BigDecimal but is a #{@accrued_delta_interests.class}") do
+        @accrued_delta_interests.is_a?(BigDecimal)
+      end
+      validate("starting_index #{@starting_index} must be positive") do
+        @starting_index.is_a?(Integer) && @starting_index >= 0
+      end
     end
 
     def set_initial_values

data/lib/loan_creator/version.rb

@@ -1,3 +1,3 @@
 module LoanCreator
-  VERSION = '0.11.0'.freeze
+  VERSION = '0.12.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: loan_creator
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - thibaulth
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-03 00:00:00.000000000 Z
+date: 2022-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler