loady 0.9.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9542f9292a6cf6f2d12a033170e70a181235d49f
-  data.tar.gz: 4615571fbee275ea5cf7527236d97e440c4fda53
+  metadata.gz: 6a1cc4ddea13a61ba00af056e95092eb9c6befe2
+  data.tar.gz: 78796d7745d5bf82e71eac66c830829f6247a3e1
 SHA512:
-  metadata.gz: c0d25286af535b360d361355ce5fc1dce248a760fd4c06d2515d6acf9df1165540ea7ee8656658daae7402032e58c73fe2ade6c92664f5c7f20338b19ddd2023
-  data.tar.gz: 19c248583518f999a7eafe890d5ae36c1a23bf69948b65584461e2724190738e3d0af815576971afe93e30d1998e957ae141f77a328f8ccdcdf12819f56d1cb3
+  metadata.gz: 4c5b0b8cc7c1e70939459624723780d60dd36510d9bab1e77028e63c065d2e3770bff5395ad843a5dd898e2dc756d6a930165730cde89e16e83cecdc8d17fb5e
+  data.tar.gz: 1fbd395af9f7cd47dce80860c4ec84002f55bf67254f130adafd83d4796f42e0fe2f821d94051133c047f9bd99c456d8d9601b5137ab7ce2842dfb17e70ae270

data/README.md

@@ -79,8 +79,17 @@ end
 
 memory_logger.messages
 => [
-    'Line 123: Something bad happened.', 
+    'Line 123: Something bad happened.',
     'Line 456: Exception of some sort.',
     'Finished. Loaded 9998 rows. 2 unprocessed rows.'
    ]
 ```
+
+## Major Change in 1.0
+
+Up to version 1.0, `loady` worked fundamentally differently than ruby's CSV
+parser in that it did not support newlines. The benefit was that lines
+with errant newlines could easily be ignored.
+
+In version 1.0+, `loady` works like the stdlib ruby CSV parser, and you
+must have properly formed CSV rows.

data/lib/loady/csv_loader.rb

@@ -16,16 +16,15 @@ module Loady
     #     see http://www.ruby-doc.org/stdlib/libdoc/csv/rdoc/classes/CSV.html#M000190
     def read(filename, options = {}, &block)
       @logger = options.delete(:logger) || default_logger
+      options[:headers] ||= options.delete(:skip_first_row)
 
-      File.open(filename, "r") do |file|
-        file.gets if options.delete(:skip_first_row)
-
-        file.each do |line|
-          readline line, options, &block
-        end
+      CSV.foreach(filename, options) do |line|
+        readline line, options, &block
       end
-
-      @logger.info "Finished. Loaded #{ @success } rows. #{ @warning } unprocessed rows."
+      @logger.info "Finished. Loaded #{ @success } rows. #{ @warning } skipped rows."
+    rescue CSV::MalformedCSVError => ex
+      @logger.error ex.message
+      @logger.error "Stopped Loading after #{ @success } rows. #{ @warning } skipped rows."
     end
 
     class << self
@@ -38,7 +37,11 @@ module Loady
 
     def readline(line, options)
       @line_number += 1
-      row = AttributeArray.new(CSV.parse(line, options)[0])
+      row = if line.respond_to?(:to_hash)
+              AttributeArray.new(line.to_hash.values)
+            else
+              AttributeArray.new(line)
+            end
 
       if row.any?
         yield row

data/lib/loady/version.rb

@@ -1,3 +1,3 @@
 module Loady
-  VERSION = "0.9.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: loady
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Tee Parham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-20 00:00:00.000000000 Z
+date: 2016-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mocha
@@ -86,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: File loader with simple logging