llt-review 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91ff18f1e72915936a2069917fa843b701ee7df8
-  data.tar.gz: f4398109dc7d16bdfed7980a6dba2359c7350c0a
+  metadata.gz: 9b91983dc42ac4d0aece4d4d745e2576442f91fc
+  data.tar.gz: faa768dab56010e1bc570506e7ae718ca503a11b
 SHA512:
-  metadata.gz: 3e5087b17bef29c42939a587f667636f848773a6a5e0902936753413fafdeb51901327e222fd31eda844f9233555a69762adf236c82bf68c5e4658541569ccfa
-  data.tar.gz: 7eef4e5e71816b0fd7ef3d10e436c84f649c85e1d6ac23baedf9414c99b2b9f74640deac6807dca701e68bf246d65283f84cd25e72f5be4475de832ea98ae693
+  metadata.gz: e2f9e3f7d61e8ac1493035d8789eb414190cbbe3f218a3c229ab66af09d55f0f7df1d7ba2ae0c761e195caa6a103a9bd77081a8938adb88e0626bcf849a65ff3
+  data.tar.gz: 65f0e95aa16565761a0025f2832e91b2e8e22b4277ad35d625bc8ab63ad2072cad9d0c1acb8b321edddd7d0bb4b89e19d224129a243b7d329dbd4113b5e0d520

data/lib/llt/review/api.rb

@@ -44,7 +44,7 @@ class Api < Sinatra::Base
     if backend = params[:backend]
       p = case backend
           when 'perseids'     then 'sosol.perseids.org/sosol'
-          when 'perseids-dev' then 'dev.alpheios.net:3000'
+          when 'perseids-dev' then 'sosol-rep.perseids.org'
           end
 
       expand_perseids_urls(params, :gold, p)

data/lib/llt/review/common/sentence.rb

@@ -13,7 +13,11 @@ module LLT
 
       def compare(other, comparables = nil)
         diff = new_sentence_diff
-        words.each { |id, word| word.compare(other[id], diff, comparables) }
+        words.each do |id, word|
+          other_word = other[id] || dummy_word(id)
+
+          word.compare(other_word, diff, comparables)
+        end
         diff
       end
 
@@ -25,6 +29,10 @@ module LLT
 
       private
 
+      def dummy_word(id)
+        # implemented by subclasses
+      end
+
       def new_sentence_diff
         diff_namespace.const_get(:Sentence).new(self)
       end

data/lib/llt/review/treebank/postag.rb

@@ -5,7 +5,7 @@ module LLT
 
       def initialize(postag)
         @id = :postag
-        @postag = postag
+        @postag = new_postag(postag)
       end
 
       def to_s
@@ -58,6 +58,14 @@ module LLT
           data.add(Report::Generic.new(pl, 0, sg))
         end
       end
+
+      def new_postag(postag)
+        if !postag || postag.empty? || postag == '-'
+          '-' * POSTAG_SCHEMA.length
+        else
+          postag
+        end
+      end
     end
   end
 end

data/lib/llt/review/treebank/sentence.rb

@@ -16,6 +16,13 @@ module LLT
         end.merge(postags: Report::Postags.new(size))
       end
 
+      def dummy_word(id)
+        w = Word.new(id)
+        w.form = "-"
+        w.inexistant = true
+        w
+      end
+
       def diff_namespace
         Review::Treebank::Difference
       end

data/lib/llt/review/treebank/word.rb

@@ -3,7 +3,7 @@ module LLT
     class Word
       include Core::Structures::HashContainable
 
-      attr_accessor :form, :lemma, :head, :relation
+      attr_accessor :form, :lemma, :head, :relation, :inexistant
       attr_reader :postag
 
       Attr = Struct.new(:id, :attribute) do
@@ -20,6 +20,10 @@ module LLT
         define_method("#{type}=") { |val| add(Attr.new(type, val)) }
       end
 
+      def [](key)
+        super(key) || send("#{key}=", '-')
+      end
+
       def postag=(tag)
         add(Postag.new(tag))
       end

data/lib/llt/review/version.rb

@@ -1,5 +1,5 @@
 module LLT
   class Review
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/spec/lib/llt/review/treebank_spec.rb

@@ -141,6 +141,117 @@ describe LLT::Review::Treebank do
       diff[3].should be_nil # has only lemma and postag differences
       diff[4].should be_true
     end
+
+    context "with slightly out of sync documents" do
+      let(:ge1) do
+        <<-EOF
+          <treebank>
+            <sentence id="21" document_id="Perseus:text:1999.02.0002" subdoc="Book=2:chapter=5" span="In3:erat0">
+              <word id="1" form="In" lemma="in1" postag="r--------" head="5" relation="AuxP"/>
+              <word id="2" form="eo" lemma="is1" postag="p-s---nb-" head="3" relation="ATR"/>
+              <word id="3" form="flumine" lemma="flumen1" postag="n-s---nb-" head="1" relation="ADV"/>
+              <word id="4" form="pons" lemma="pons1" postag="n-s---mn-" head="5" relation="SBJ"/>
+              <word id="5" form="erat" lemma="sum1" postag="v3siia---" head="0" relation="PRED"/>
+              <word id="6" form="erat" lemma="sum1" postag="v3siia---" head="0" relation="PRED" elliptic="true"/>
+            </sentence>
+          </treebank>
+        EOF
+      end
+
+      let(:re1) do
+        <<-EOF
+          <treebank>
+            <sentence id="21" document_id="Perseus:text:1999.02.0002" subdoc="Book=2:chapter=5" span="In3:erat0">
+              <word id="1" form="In" lemma="in1" postag="r--------" head="4" relation="AuxP"/>
+              <word id="2" form="eo" lemma="is1" postag="p-s---nd-" head="3" relation="ATR"/>
+              <word id="3" form="flumine" lemma="flumen2" postag="n-s---nd-" head="1" relation="ADV"/>
+              <word id="4" form="pons" lemma="pons1" postag="n-s---mn-" head="5" relation="OBJ"/>
+              <word id="5" form="erat" lemma="sum1" postag="v3siia---" head="0" relation="PRED"/>
+            </sentence>
+          </treebank>
+        EOF
+      end
+
+      it "does not fall for additional (such as elliptic) nodes in the gold file" do
+        allow(differ).to receive(:get_from_uri).with(:uri_for_ge1) { ge1 }
+        allow(differ).to receive(:get_from_uri).with(:uri_for_re1) { re1 }
+
+        expect { differ.diff([:uri_for_ge1], [:uri_for_re1]) }.to_not raise_error
+      end
+
+      it "does not fall for additional (such as elliptic) nodes in the review file" do
+        allow(differ).to receive(:get_from_uri).with(:uri_for_re1) { re1 }
+        allow(differ).to receive(:get_from_uri).with(:uri_for_ge1) { ge1 }
+
+        expect { differ.diff([:uri_for_re1], [:uri_for_ge1]) }.to_not raise_error
+      end
+    end
+
+    context "with partially unannotated files" do
+      let(:gi1) do
+        <<-EOF
+          <treebank>
+            <sentence id="21" document_id="Perseus:text:1999.02.0002" subdoc="Book=2:chapter=5" span="In3:erat0">
+              <word id="1" form="In" lemma="in1" postag="r--------" head="5" relation="AuxP"/>
+              <word id="2" form="eo" lemma="is1" postag="p-s---nb-" head="3" relation="ATR"/>
+              <word id="3" form="flumine" lemma="flumen1" postag="n-s---nb-" head="1" relation="ADV"/>
+              <word id="4" form="pons" lemma="pons1" postag="n-s---mn-" head="5" relation="SBJ"/>
+              <word id="5" form="erat" lemma="sum1" postag="v3siia---" head="0" relation="PRED"/>
+            </sentence>
+          </treebank>
+        EOF
+      end
+
+      let(:ri1) do
+        <<-EOF
+          <treebank>
+            <sentence id="21" document_id="Perseus:text:1999.02.0002" subdoc="Book=2:chapter=5" span="In3:erat0">
+              <word id="1" form="In" postag="r--------" head="4" relation="AuxP"/>
+              <word id="2" form="eo" postag="p-s---nd-" head="3" relation="ATR"/>
+              <word id="3" form="flumine" lemma="flumen2" postag="n-s---nd-" relation="ADV"/>
+              <word id="4" form="pons" lemma="pons1" postag="n-s---mn-" head="5"/>
+              <word id="5" form="erat" lemma="sum1" postag="v3siia---" head="0" relation="PRED"/>
+            </sentence>
+          </treebank>
+        EOF
+      end
+
+      let(:ri2) do
+        <<-EOF
+          <treebank>
+            <sentence id="21" document_id="Perseus:text:1999.02.0002" subdoc="Book=2:chapter=5" span="In3:erat0">
+              <word id="1" form="In" postag="" head="4" relation="AuxP"/>
+              <word id="2" form="eo" head="3" relation="ATR"/>
+              <word id="3" form="flumine" lemma="flumen2" postag="n-s---nd-" relation="ADV"/>
+              <word id="4" form="pons" lemma="pons1" postag="n-s---mn-" head="5"/>
+              <word id="5" form="erat" lemma="sum1" postag="v3siia---" head="0" relation="PRED"/>
+            </sentence>
+          </treebank>
+        EOF
+      end
+
+      it "does not fall with less content in the review file" do
+        allow(differ).to receive(:get_from_uri).with(:uri_for_gi1) { gi1 }
+        allow(differ).to receive(:get_from_uri).with(:uri_for_ri1) { ri1 }
+
+        expect { differ.diff([:uri_for_gi1], [:uri_for_ri1]) }.to_not raise_error
+      end
+
+      it "does not fall with less content in the gold file" do
+        allow(differ).to receive(:get_from_uri).with(:uri_for_gi1) { gi1 }
+        allow(differ).to receive(:get_from_uri).with(:uri_for_ri1) { ri1 }
+
+        expect { differ.diff([:uri_for_ri1], [:uri_for_gi1]) }.to_not raise_error
+      end
+
+      it "does not fall with missing postags" do
+        allow(differ).to receive(:get_from_uri).with(:uri_for_gi1) { gi1 }
+        allow(differ).to receive(:get_from_uri).with(:uri_for_ri2) { ri2 }
+
+        expect { differ.diff([:uri_for_ri2], [:uri_for_gi1]) }.to_not raise_error
+        expect { differ.diff([:uri_for_gi1], [:uri_for_ri2]) }.to_not raise_error
+      end
+    end
   end
 
   describe "#report" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: llt-review
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - LFDM
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-11 00:00:00.000000000 Z
+date: 2014-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Reviews annotations