lite-form 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 222e3689b037e5b8f7ab55241b45510f871b7b6045c5a2f479e1369c1e684bfd
-  data.tar.gz: adfe85542a0edca34677ef5cfcc9ca3078e40e3f29f88f921886d71c9ffd5540
+  metadata.gz: 9f6348e50f8c224acb7db926a6e68cdaee3e317fae28c4976d775de547679c0c
+  data.tar.gz: de5fb7c924d72a17a3e7d75c09ec45a0c68b3d7ac3f0491398b62ae5df1ed416
 SHA512:
-  metadata.gz: 3b4182e69c63b4f2cfe0cc27bfaa6c808997e3c07da2eee378c33ea1b2aefb27dec91188a7b11fc637edafddc66e6f1adfb4ba788aee77874b8a58e1eb41431e
-  data.tar.gz: 2e50a501dee8928d9e93b3953ce534c11727a1ccb96a92e0a0323e92360301badbb15712316bc4568682a5923d90fe14972d4f65b14600ef603187b2602e663b
+  metadata.gz: '058745e0775a9d844551ae3df8913046cdb402bccfec011c089798c16ed5cee54c5bba3fa5368f8949d0ec1e13622365b9cc0945ced0301122b51f406c169b16'
+  data.tar.gz: e1538f82e2fdc246b9ff679bf304e7d5f5718c3127941381b3b7fd417405e5bdef3bd4d8f19583c404cf0bf8be5aa081f87be31420a15b2b07d5a7b14fbeeda9

data/.rubocop.yml

@@ -5,6 +5,8 @@ AllCops:
   TargetRubyVersion: 2.6
   DisplayCopNames: true
   DisplayStyleGuide: true
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
 Layout/EmptyLinesAroundBlockBody:
   Exclude:
     - 'spec/**/**/*'
@@ -14,6 +16,12 @@ Layout/EmptyLinesAroundModuleBody:
   EnforcedStyle: empty_lines_except_namespace
 Layout/LineLength:
   Max: 100
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/**/*'
@@ -28,3 +36,13 @@ Style/Documentation:
   Enabled: false
 Style/ExpandPathArguments:
   Enabled: false
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: false

data/CHANGELOG.md

@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.5] - 2020-05-20
+### Added
+- Added save args
+- Added more callback support
+### Removed
+- Removed archive and destroy propagation
+
 ## [1.0.4] - 2019-12-21
 ### Removed
 - Removed generator empty directory check

data/Gemfile.lock

@@ -1,65 +1,64 @@
 PATH
   remote: .
   specs:
-    lite-form (1.0.4)
+    lite-form (1.0.5)
       activemodel
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (6.0.2.1)
-      actionview (= 6.0.2.1)
-      activesupport (= 6.0.2.1)
+    actionpack (6.0.3.1)
+      actionview (= 6.0.3.1)
+      activesupport (= 6.0.3.1)
       rack (~> 2.0, >= 2.0.8)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actionview (6.0.2.1)
-      activesupport (= 6.0.2.1)
+    actionview (6.0.3.1)
+      activesupport (= 6.0.3.1)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activemodel (6.0.2.1)
-      activesupport (= 6.0.2.1)
-    activerecord (6.0.2.1)
-      activemodel (= 6.0.2.1)
-      activesupport (= 6.0.2.1)
-    activesupport (6.0.2.1)
+    activemodel (6.0.3.1)
+      activesupport (= 6.0.3.1)
+    activerecord (6.0.3.1)
+      activemodel (= 6.0.3.1)
+      activesupport (= 6.0.3.1)
+    activesupport (6.0.3.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-      zeitwerk (~> 2.2)
+      zeitwerk (~> 2.2, >= 2.2.2)
     ast (2.4.0)
     builder (3.2.4)
     colorize (0.8.1)
-    concurrent-ruby (1.1.5)
-    crass (1.0.5)
-    database_cleaner (1.7.0)
+    concurrent-ruby (1.1.6)
+    crass (1.0.6)
+    database_cleaner (1.8.5)
     diff-lcs (1.3)
     erubi (1.9.0)
-    fasterer (0.8.1)
+    fasterer (0.8.3)
       colorize (~> 0.7)
       ruby_parser (>= 3.14.1)
     generator_spec (0.9.4)
       activesupport (>= 3.0.0)
       railties (>= 3.0.0)
-    i18n (1.7.0)
+    i18n (1.8.2)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.4)
-    loofah (2.4.0)
+    loofah (2.5.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    method_source (0.9.2)
+    method_source (1.0.0)
     mini_portile2 (2.4.0)
-    minitest (5.13.0)
-    nokogiri (1.10.7)
+    minitest (5.14.1)
+    nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
     parallel (1.19.1)
-    parser (2.6.5.0)
+    parser (2.7.1.2)
       ast (~> 2.4.0)
-    rack (2.0.8)
+    rack (2.2.2)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rails-dom-testing (2.0.3)
@@ -67,49 +66,50 @@ GEM
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.3.0)
       loofah (~> 2.3)
-    railties (6.0.2.1)
-      actionpack (= 6.0.2.1)
-      activesupport (= 6.0.2.1)
+    railties (6.0.3.1)
+      actionpack (= 6.0.3.1)
+      activesupport (= 6.0.3.1)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.20.3, < 2.0)
     rainbow (3.0.0)
     rake (13.0.1)
+    rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
-    rspec-expectations (3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
-    rubocop (0.78.0)
-      jaro_winkler (~> 1.5.1)
+    rspec-support (3.9.3)
+    rubocop (0.83.0)
       parallel (~> 1.10)
-      parser (>= 2.6)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-performance (1.5.1)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-performance (1.5.2)
       rubocop (>= 0.71.0)
-    rubocop-rspec (1.37.1)
+    rubocop-rspec (1.39.0)
       rubocop (>= 0.68.1)
     ruby-progressbar (1.10.1)
-    ruby_parser (3.14.1)
+    ruby_parser (3.14.2)
       sexp_processor (~> 4.9)
-    sexp_processor (4.13.0)
+    sexp_processor (4.14.1)
     sqlite3 (1.4.2)
     thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.5)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
-    unicode-display_width (1.6.0)
-    zeitwerk (2.2.2)
+    unicode-display_width (1.7.0)
+    zeitwerk (2.3.0)
 
 PLATFORMS
   ruby
@@ -129,4 +129,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/README.md

@@ -59,9 +59,9 @@ class UserForm < ApplicationForm
   # Setup your form validations like you would on model objects
   validates :name, presence: true
 
-  # Access 4 predefined callbacks to trigger before, after, and
+  # Access 6 predefined callbacks to trigger before, after, and
   # around your actions. Available callbacks are `initialize`
-  # `create`, `save`, and `update`
+  # `commit`, `create`, `rollback`, `save`, and `update`.
   before_create :prepend_signature!
   after_update :append_signature!
 
@@ -74,17 +74,26 @@ class UserForm < ApplicationForm
     # Propagation methods help you perform an action on an object.
     # If successful is returns the result else it adds the object
     # errors to the form object. Available propagation methods are:
-    # `create_and_return!(object, params)`, `update_and_return!(object, params)`,
-    # `save_and_return!(object)`, and `destroy_and_return!(object)`
+    # `create_and_return!(object, params)`,
+    # `update_and_return!(object, params)`,
+    # `save_and_return!(object)`
     create_and_return!(User, attributes)
   end
 
   def update_action
-    ActiveRecord::Base.transaction do
-      user = User.find(attributes[:id])
-      update_and_return!(user, attributes.slice(:id))
-      update_and_return!(user.settings, tour: false)
+    run_callbacks(:commit) do
+      ActiveRecord::Base.transaction do
+        user = User.find(attributes[:id])
+        update_and_return!(user, attributes.slice(:id))
+
+        # The `save_and_return!` supports on/off validation
+        user.settings.web_notification = true
+        save_and_return!(user.settings, validate: false)
+      end
     end
+  rescue StandardError => e
+    # This will run the `rollback` callback and re-raise the error.
+    raise_transaction_rollback(e)
   end
 
   def prepend_signature!
@@ -101,7 +110,6 @@ end
 ## Usage
 
 To access the form you need to pass the object to the form class and thats it.
-You can even decorate a collection of objects by passing the collection to `decorate`.
 
 ```ruby
 form = UserForm.new(params)
@@ -139,7 +147,9 @@ include ActiveModel::Serialization
 
 # Default callbacks that are defined
 define_model_callbacks :initialize
+define_model_callbacks :commit
 define_model_callbacks :create
+define_model_callbacks :rollback
 define_model_callbacks :save
 define_model_callbacks :update
 ```

data/lib/lite/form/base.rb

@@ -17,10 +17,18 @@ module Lite
       include Lite::Form::Helpers::Propagation
 
       define_model_callbacks :initialize
+      define_model_callbacks :commit
       define_model_callbacks :create
+      define_model_callbacks :rollback
       define_model_callbacks :save
       define_model_callbacks :update
 
+      attr_reader :result
+
+      def initialize(params = {})
+        run_callbacks(:initialize) { super(params) }
+      end
+
       class << self
 
         def model_name
@@ -33,12 +41,6 @@ module Lite
 
       end
 
-      attr_reader :result
-
-      def initialize(params = {})
-        run_callbacks(:initialize) { super(params) }
-      end
-
     end
   end
 end

data/lib/lite/form/helpers/errors.rb

@@ -50,6 +50,11 @@ module Lite
           errors.empty?
         end
 
+        def raise_transaction_rollback(exception)
+          run_callbacks(:rollback)
+          raise exception
+        end
+
       end
     end
   end

data/lib/lite/form/helpers/propagation.rb

@@ -7,19 +7,17 @@ module Lite
 
         private
 
-        %i[archive destroy save].each do |action|
-          define_method("#{action}_and_return!") do |klass|
-            merge_errors!(klass) unless klass.send(action)
-            klass
-          end
-        end
-
         def create_and_return!(klass, params)
           klass = klass.create(params)
           merge_errors!(klass) unless klass.errors.empty?
           klass
         end
 
+        def save_and_return!(klass, *args)
+          merge_errors!(klass) unless klass.save(*args)
+          klass
+        end
+
         def update_and_return!(klass, params)
           merge_errors!(klass) unless klass.update(params)
           klass

data/lib/lite/form/version.rb

@@ -3,7 +3,7 @@
 module Lite
   module Form
 
-    VERSION ||= '1.0.4'
+    VERSION ||= '1.0.5'
 
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lite-form
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Juan Gomez
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-21 00:00:00.000000000 Z
+date: 2020-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -231,7 +231,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.1
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Ruby Form based framework (aka form objects)