lita-trello 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3f8bad963279d61d23aa48e3f6c62525ea6f79c
-  data.tar.gz: e0a855500187077ac747581774a7636381bda6ba
+  metadata.gz: 0d32024858f2d30359789fef493b73a6ae0ca3f4
+  data.tar.gz: 31c611c68f82b5642f725767ef981363e52811b4
 SHA512:
-  metadata.gz: 58938dcae9f8133382562e1a9c3b26a976979c6613f528ecb19857574bf72f88a3f7ebb9159a5e1e33e19f881acf83b05d9d1b1d9540a7ae0fb2854fc694f033
-  data.tar.gz: 2468835ed31df28910bf49ae0146944c1aaf54cc8e4c68d0dc06a1ad9d3628e3f43ec2bd7ad644acf82e8806548abccbe86fa9e82e462dd502fb4b81f6bb56c3
+  metadata.gz: b5d42862e8507662c722e923de7279472fc035dc34b9e5130a64ea4e9e6b8761e2bedffa90826c426f5fa4feec209b041a7a26b77b544c7e3b26f1a8d413fb89
+  data.tar.gz: b7db10dc4818cebe752404729a89749ef1d11455ec6c2ded92ca0b2c3c4834f62a016c546d617f3264773f2287ca05a172bf72d70921c061c9c4a70ab6cf01db

data/.rubocop.yml

@@ -0,0 +1,19 @@
+Documentation:
+  Exclude:
+    - lib/lita/handlers/trello.rb
+
+FileName:
+  Exclude:
+    - lib/lita-trello.rb
+
+Metrics/AbcSize:
+  Max: 23
+
+Metrics/ClassLength:
+  Max: 115
+
+Metrics/LineLength:
+  Max: 115
+
+Metrics/MethodLength:
+  Max: 18

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.1
+  - 2.2
+services:
+  - redis-server
+sudo: false

data/CONTRIBUTING.md

@@ -0,0 +1,9 @@
+Pull requests are awesome!  Pull requests with tests are even more awesome!
+
+## Quick steps
+
+1. Fork the repo.
+2. Run the tests: `bundle && rake`
+3. Add a test for your change. Only refactoring and documentation changes require no new tests. If you are adding functionality or fixing a bug, it needs a test!
+4. Make the test pass.
+5. Push to your fork and submit a pull request.

data/Gemfile

@@ -1,3 +1,3 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 gemspec

data/README.md

@@ -1,5 +1,12 @@
 # lita-trello
 
+[![Build Status](https://img.shields.io/travis/RWJMurphy/lita-trello/master.svg)](https://travis-ci.org/RWJMurphy/lita-trello)
+[![MIT License](https://img.shields.io/badge/license-MIT-brightgreen.svg)](https://tldrlegal.com/license/mit-license)
+[![RubyGems](http://img.shields.io/gem/v/lita-trello.svg)](https://rubygems.org/gems/lita-trello)
+[![Coveralls Coverage](https://img.shields.io/coveralls/RWJMurphy/lita-trello/master.svg)](https://coveralls.io/r/RWJMurphy/lita-trello)
+[![Code Climate](https://img.shields.io/codeclimate/github/RWJMurphy/lita-trello.svg)](https://codeclimate.com/github/RWJMurphy/lita-trello)
+[![Gemnasium](https://img.shields.io/gemnasium/RWJMurphy/lita-trello.svg)](https://gemnasium.com/RWJMurphy/lita-trello)
+
 Manage your Trello board from Lita.
 
 Inspired by [hubot-trello](https://github.com/hubot-scripts/hubot-trello).

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:rubocop)
 
-task default: :spec
+task default: [:spec, :rubocop]

data/lib/lita-trello.rb

@@ -1,12 +1,14 @@
-require "lita"
+require 'lita'
 
 Lita.load_locales Dir[File.expand_path(
-  File.join("..", "..", "locales", "*.yml"), __FILE__
+  File.join('..', '..', 'locales', '*.yml'), __FILE__
 )]
 
-require "lita/handlers/trello"
+require 'trello'
+
+require 'lita/handlers/trello'
 
 Lita::Handlers::Trello.template_root File.expand_path(
-  File.join("..", "..", "templates"),
- __FILE__
+  File.join('..', '..', 'templates'),
+  __FILE__
 )

data/lib/lita/handlers/trello.rb

@@ -1,5 +1,3 @@
-require 'trello'
-
 module Lita
   module Handlers
     class Trello < Handler
@@ -7,90 +5,110 @@ module Lita
       config :token
       config :board
 
-      route(/^trello\s+new\s+[^\s]+\s+[^\s]+/i, :handle_create_card, command: true, help: {
-        "trello new LIST Do the thing" => "Create a new card in LIST called 'Do the thing'"
-      })
-      def handle_create_card(r)
-        list_name = r.args[1]
-        name = r.args[2..-1].join(" ")
+      route(
+        /^trello\s+new\s+(?<list_name>(\w+|"[^"]+"))\s+(?<name>.*)/i,
+        :new,
+        command: true,
+        help: {
+          t('help.new.syntax') => t('help.new.desc')
+        }
+      )
+
+      route(
+        %r{^trello\s+move\s+https://trello.com/c/(?<card_id>\w+)\s+(?<list_name>(\w+|"[^"]+"))},
+        :move,
+        command: true,
+        help: {
+          t('help.move.syntax') => t('help.move.desc')
+        }
+      )
+
+      route(
+        /^trello\s+list\s+(?<list_name>(\w+|"[^"]+"))/i,
+        :list,
+        command: true,
+        help: {
+          t('help.list.syntax') => t('help.list.desc')
+        }
+      )
+
+      route(
+        /^trello\s+lists$/i,
+        :show_lists,
+        command: true,
+        help: {
+          t('help.lists.syntax') => t('help.lists.desc')
+        }
+      )
+
+      def new(r)
+        list_name = r.match_data['list_name']
+        name = r.match_data['name']
 
         list_id = lists[list_name.downcase].id
         if list_id.nil?
-          r.reply "I couldn't find a list named #{list_name}."
+          r.reply t('error.no_list', list_name: list_name)
           return
         end
 
-        r.reply "Ok #{r.user.name}, I'm creating a new card in #{list_name}."
+        r.reply t('card.creating', user_name: r.user.name, list_name: list_name)
         begin
           card = new_card(name, list_id)
-          r.reply "Here you go: #{card.short_url}"
+          r.reply t('card.created', url: card.short_url)
         rescue
-          r.reply "Something failed."
+          r.reply t('error.generic')
         end
       end
 
-      route(/^trello\s+move\s+[^\s]+\s+[^\s]+/i, :handle_move_card, command: true, help: {
-        "trello move https://trello.com/c/CARD_ID LIST" => "Move a card to LIST"
-      })
-      def handle_move_card(r)
-        card_id = r.args[1]
-        list_name = r.args[2]
+      def move(r)
+        card_id = r.match_data['card_id']
+        list_name = r.match_data['list_name']
 
         list = lists[list_name.downcase]
         if list.nil?
-          r.reply "I couldn't find a list named #{list_name}."
+          r.reply t('error.no_list', list_name: list_name)
           return
         end
 
-        card_id = card_id.gsub(/(^<|>$)/, '')
-        if %r{^https?://trello.com/c/([^/]+)/?$} =~ card_id
-          card_id = $1
-        end
-
         card = trello.find(:card, card_id)
         if card.nil?
-          r.reply "I couldn't find that card."
+          r.reply t('error.no_card')
           return
         end
 
         begin
           card.move_to_list(list)
-          r.reply "Ok #{r.user.name}, I moved that card to #{list_name}."
+          r.reply t('card.moved', user_name: r.user.name, list_name: list_name)
         rescue
-          r.reply "Something failed."
+          r.reply t('error.generic')
         end
       end
 
-      route(/^trello\s+list\s+[^\s]+/i, :handle_list_cards, command: true, help: {
-        "trello list LIST" => "Show all cards in LIST"
-      })
-      def handle_list_cards(r)
-        list_name = r.args[1]
+      def list(r)
+        list_name = r.match_data['list_name']
         list = lists[list_name.downcase]
         if list.nil?
-          r.reply "I couldn't find a list named #{list_name}."
+          r.reply t('error.no_list', list_name: list_name)
           return
         end
 
-        r.reply("Here are the cards in #{list.name}:\n\n" +
-          list.cards.map { |card| "* #{card.name} - #{card.short_url}" }.join("\n")
-        )
+        r.reply(t('card.list', list_name: list_name) +
+                list.cards.map { |card| "* #{card.name} - #{card.short_url}" }.join("\n")
+               )
       end
 
-      route(/^trello\s+lists$/i, :handle_lists, command: true, help: {
-        "trello lists" => "Show all lists on your board"
-      })
-      def handle_lists(r)
-        r.reply("Here are all the lists on your board:\n\n" +
-          lists.keys.map { |list_name| "* #{list_name}" }.join("\n")
-        )
+      def show_lists(r)
+        r.reply(t('list.list') +
+                lists.keys.map { |list_name| "* #{list_name}" }.join("\n")
+               )
       end
 
       private
+
       def trello
         @trello ||= ::Trello::Client.new(
           developer_public_key: config.public_key,
-          member_token: config.token,
+          member_token: config.token
         )
       end
 
@@ -108,13 +126,12 @@ module Lita
         @default_list_id ||= redis.get('default_list_id')
       end
 
-      def new_card(name, list_id=nil)
+      def new_card(name, list_id = nil)
         trello.create(:card,
-          'name' => name,
-          'idList' => list_id || default_list_id,
-        )
+                      'name' => name,
+                      'idList' => list_id || default_list_id
+                     )
       end
-
     end
 
     Lita.register_handler(Trello)

data/lita-trello.gemspec

@@ -1,27 +1,30 @@
 Gem::Specification.new do |spec|
-  spec.name          = "lita-trello"
-  spec.version       = "0.0.5"
-  spec.authors       = ["Reed Kraft-Murphy"]
-  spec.email         = ["reed@reedmurphy.net"]
-  spec.description   = "Manage your Trello board from Lita"
-  spec.summary       = "Manage your Trello board from Lita"
-  spec.homepage      = "https://github.com/RWJMurphy/lita-trello"
-  spec.license       = "MIT"
-  spec.metadata      = { "lita_plugin_type" => "handler" }
+  spec.name          = 'lita-trello'
+  spec.version       = '0.0.6'
+  spec.authors       = ['Reed Kraft-Murphy']
+  spec.email         = ['reed@reedmurphy.net']
+  spec.description   = 'Manage your Trello board from Lita'
+  spec.summary       = 'Manage your Trello board from Lita'
+  spec.homepage      = 'https://github.com/RWJMurphy/lita-trello'
+  spec.license       = 'MIT'
+  spec.metadata      = { 'lita_plugin_type' => 'handler' }
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.required_ruby_version = ">= 2.1.0"
+  spec.required_ruby_version = '>= 2.1.0'
 
-  spec.add_runtime_dependency "lita", ">= 4.3"
-  spec.add_runtime_dependency "ruby-trello", "~> 1.1"
+  spec.add_runtime_dependency 'lita', '>= 4.3'
+  spec.add_runtime_dependency 'ruby-trello', '~> 1.1'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rack-test"
-  spec.add_development_dependency "rspec", ">= 3.0.0"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rack-test'
+  spec.add_development_dependency 'rspec', '>= 3.0.0'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'simplecov'
 end

data/locales/en.yml

@@ -2,3 +2,27 @@ en:
   lita:
     handlers:
       trello:
+        error:
+          generic: Something failed.
+          no_list: "I couldn't find a list named %{list_name}."
+          no_card: "I couldn't find that card."
+        help:
+          new:
+            syntax: trello new LIST Do the thing
+            desc: Create a new card in LIST called 'Do the thing'
+          move:
+            syntax: trello move https://trello.com/c/CARD_ID LIST
+            desc: Move a card to LIST
+          list:
+            syntax: trello list LIST
+            desc: Show all cards in LIST
+          lists:
+            syntax: trello lists
+            desc: Show all lists on your board
+        card:
+          creating: "Ok %{user_name}, I'm creating a new card in %{list_name}."
+          created: "Here you go: %{url}"
+          moved: "Ok %{user_name}, I moved that card to %{list_name}."
+          list: "Here are the cards in %{list_name}:\n\n"
+        list:
+          list: "Here are all the lists on your board:\n\n"

data/spec/lita/handlers/trello_spec.rb

@@ -1,4 +1,85 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Lita::Handlers::Trello, lita_handler: true do
+  it { is_expected.to route_command('trello new LIST Do the thing').to(:new) }
+  it { is_expected.to route_command('trello new "A LIST" Do the thing').to(:new) }
+  it { is_expected.to route_command('trello move https://trello.com/c/CARD_ID LIST').to(:move) }
+  it { is_expected.to route_command('trello move https://trello.com/c/CARD_ID "A LIST"').to(:move) }
+  it { is_expected.to route_command('trello list LIST').to(:list) }
+  it { is_expected.to route_command('trello list "A LIST"').to(:list) }
+  it { is_expected.to route_command('trello lists').to(:show_lists) }
+
+  before do
+    registry.config.handlers.trello.public_key = 'foo'
+    registry.config.handlers.trello.token = 'bar'
+    registry.config.handlers.trello.board = 'baz'
+  end
+
+  let(:card) do
+    card = double
+    allow(card).to receive(:name) { 'cardname' }
+    allow(card).to receive(:short_url) { 'http://example.com/cardshorturl' }
+    allow(card).to receive(:move_to_list).with(anything) { true }
+    card
+  end
+
+  let(:list) do
+    list = double
+    allow(list).to receive(:name) { 'listname' }
+    allow(list).to receive(:cards) { [card] }
+    allow(list).to receive(:id) { 1 }
+    list
+  end
+
+  let(:board) do
+    board = double
+    allow(board).to receive(:lists) { [list] }
+    board
+  end
+
+  let(:client) do
+    client = double
+    allow(client).to receive(:find).with(:board, kind_of(String)) { board }
+    allow(client).to receive(:find).with(:card, kind_of(String)) { card }
+    allow(client).to receive(:create) { card }
+    client
+  end
+
+  describe '#new' do
+    it 'creates a card' do
+      expect(::Trello::Client).to receive(:new) { client }
+      send_command('trello new listname Do the thing')
+      expect(replies.last).to eq('Here you go: http://example.com/cardshorturl')
+    end
+  end
+
+  describe '#move' do
+    it 'moves a card' do
+      expect(::Trello::Client).to receive(:new) { client }
+      send_command('trello move https://trello.com/c/CARD_ID listname')
+      expect(replies.last).to eq('Ok Test User, I moved that card to listname.')
+    end
+  end
+
+  describe '#list' do
+    it 'shows cards for a list' do
+      expect(::Trello::Client).to receive(:new) { client }
+      send_command('trello list listname')
+      expect(replies.last).to eq("Here are the cards in listname:\n\n* cardname - http://example.com/cardshorturl")
+    end
+
+    it 'shows an error if there is no list' do
+      expect(::Trello::Client).to receive(:new) { client }
+      send_command('trello list badname')
+      expect(replies.last).to eq("I couldn't find a list named badname.")
+    end
+  end
+
+  describe '#show_lists' do
+    it 'shows lists' do
+      expect(::Trello::Client).to receive(:new) { client }
+      send_command('trello lists')
+      expect(replies.last).to eq("Here are all the lists on your board:\n\n* listname")
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,31 @@
-require "lita-trello"
-require "lita/rspec"
+require 'simplecov'
+require 'coveralls'
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start { add_filter '/spec/' }
+
+require 'lita-trello'
+require 'lita/rspec'
 
 # A compatibility mode is provided for older plugins upgrading from Lita 3. Since this plugin
 # was generated with Lita 4, the compatibility mode should be left disabled.
 Lita.version_3_compatibility_mode = false
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+  config.default_formatter = 'doc' if config.files_to_run.one?
+  config.order = :random
+
+  Kernel.srand config.seed
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-trello
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Reed Kraft-Murphy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-24 00:00:00.000000000 Z
+date: 2015-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +122,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Manage your Trello board from Lita
 email:
 - reed@reedmurphy.net
@@ -116,6 +158,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md