lita-travis-announcer 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f7791db49ad0004ef4a23e9297afd0b163f34ea
-  data.tar.gz: 32f2326e4e94e837d03be5df53b1f516918f3d0d
+  metadata.gz: 77e99afa00451234dde29ea2ba935c10e06d26f0
+  data.tar.gz: 16bb4ef73a5d71c7331d0a3f8c2258cd41198f23
 SHA512:
-  metadata.gz: 190d7489f9d58f94e25660fb6e49e3c21cca241c81f9153c68f804860ff9557f344d1ab5b5eea56ed0142aa6250c363e29bd9ecf8277d306daef6c9268eb35f5
-  data.tar.gz: 5fb1c98e19cd41b75da80925a968cf8e59fb9a262fb9a77521f3fa856436b040079efb6d529f7d1370f364aed22e34634a49ad1a4540069d6df8f798ec67cc6e
+  metadata.gz: 488f162643a7549e1ac46486e1d190cd907e47e07e92a2a7c18ed045f3454f98f6f0cf8a87721d4386ef8a9c1d33ed5ce761648970dbb83abd04c48ecb52ed10
+  data.tar.gz: 65f174d020b601d30f674b7bedc48f96545f0948501fc34c8adf714a3ac917f5b5a9027e9e9a4294003bd902c20e0028081d5199b0c707034c32326ec65e8a31

data/lib/lita/handlers/travis_announcer.rb

@@ -6,19 +6,18 @@ module Lita
 
       config :travis_room, default: 'shell'
 
-      http.post '/travis-announcer/travis', :travis_webhook
+      http.post '/travis-announcer/travis', :parse_travis_webhook
 
-      route /talk_travis/, :talk_travis
-
-      def travis_webhook(request, response)
+      def parse_travis_webhook(request, response)
         raw_json = request.params.fetch('payload')
-        travis_hook = Lita::TravisWebhook.new(raw_json)
-        handle_travis_build(travis_hook)
+        travis_hook = Lita::TravisWebhook.from_string(raw_json)
+        response.write handle_travis_build(travis_hook)
       end
 
       def handle_travis_build(hook)
         announce '*Broken build!*' if hook.broken?
         announce hook.notification_string
+        hook.notification_string
       end
 
       def announce(message)

data/lib/lita/travis_webhook.rb

@@ -3,14 +3,18 @@ require 'pry'
 require 'ostruct'
 
 module Lita
-  class TravisWebhook
-    def initialize(plaintext)
-      @raw_json = plaintext
-      @parsed = JSON.load plaintext
-      @ostruct = OpenStruct.new parsed
+  class TravisWebhook < OpenStruct
+    def initialize(parsed_json)
+      @parsed_json = parsed_json
+      @ostruct = super
     end
 
-    attr_reader :raw_json, :parsed, :ostruct
+    attr_reader :parsed_json, :ostruct
+
+    def self.from_string(raw_json)
+      parsed = JSON.parse(raw_json)
+      new parsed
+    end
 
     def description
       status_message
@@ -33,19 +37,7 @@ module Lita
     end
 
     def keys
-      parsed.keys
-    end
-
-    def method_missing(m, *args, &block)
-      if ostruct.respond_to? m
-        ostruct.send m, *args, &block
-      else
-        super
-      end
-    end
-
-    def respond_to_missing?(*_args)
-      true
+      parsed_json.keys
     end
   end
 end

data/lita-travis-announcer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-travis-announcer'
-  spec.version       = '1.0.0'
+  spec.version       = '1.1.0'
   spec.authors       = ['Daniel J. Pritchett']
   spec.email         = ['dpritchett@gmail.com']
   spec.description   = 'Chatops tools for announcing and deploying successful software builds'

data/spec/fixtures/travis_malformed.json

@@ -0,0 +1,49 @@
+{
+  "id": 375009707,
+  "number": "55",
+  "config": {
+    "os": "linux",
+    "rvm": [
+      "2.3.3"
+    ],
+    "dist": "trusty",
+    "group": "stable",
+    ".result": "configured",
+    "language": "ruby",
+    "services": [
+      "redis-server"
+    ],
+    "notifications": {
+      "webhooks": [
+        "http:\/\/bookbot.pritchettbots.com\/travis-announcer\/travis",
+        "http:\/\/7c7e83e9.ngrok.io\/travis-announcer\/travis"
+      ]
+    }
+  },
+  "type": "push",
+  "state": "passed",
+  "status": 0,
+  "result": 0,
+  "status_message": "Passed",
+  "result_message": "Passed",
+  "started_at": "2018-05-04T18:12:31Z",
+  "finished_at": "2018-05-04T18:14:52Z",
+  "duration": 141,
+  "build_url": "https:\/\/travis-ci.org\/dpritchett\/ruby-bookbot\/builds\/375009707",
+  "commit_id": 112084793,
+  "commit": "7379b6e92f7dc9328953d03d207732852c6e9401",
+  "base_commit": "7379b6e92f7dc9328953d03d207732852c6e9401",
+  "head_commit": null,
+  "branch": "master",
+  "message": "Trying out some travis magic",
+  "compare_url": "https:\/\/github.com\/dpritchett\/ruby-bookbot\/compare\/632250aff63e...7379b6e92f7d",
+  "committed_at": "2018-05-04T18:12:21Z",
+  "author_name": "Daniel J. Pritchett",
+  "author_email": "dpritchett@gmail.com",
+  "committer_name": "Daniel J. Pritchett",
+  "committer_email": "dpritchett@gmail.com",
+  "pull_request": false,
+  "pull_request_number": null,
+  "pull_request_title": null,
+  "tag": null,
+  "repository": {

data/spec/lita/handlers/travis_announcer_spec.rb

@@ -5,34 +5,46 @@ require 'json'
 describe Lita::Handlers::TravisAnnouncer, lita_handler: true do
   let(:robot) { Lita::Robot.new(registry) }
 
-  def load_fixture(name)
-    path = File.join('spec', 'fixtures', "#{name}.json")
-    as_text = open(path).readlines.join("\n")
-
-    result = Lita::TravisWebhook.new(as_text)
-  end
-
-  describe 'routes' do
+  describe 'http routes' do
     it {
       is_expected.to route_http(:post, '/travis-announcer/travis')
-        .to(:travis_webhook)
+        .to(:parse_travis_webhook)
     }
-
-    #it {
-      #is_expected.to(route('Lita play url http://zombo.com')
-        #.to(:handle_sonos_play_url))
-    #}
   end
 
-  describe 'travis webhooks' do
-    it 'should deal with the incoming json payload' do
-      result = load_fixture('travis_success')
+  context 'dummy post request' do
+    let(:request) { double 'post request' }
+    let(:response) { double 'post response' }
+    let(:payload) { load_fixture 'travis_success' }
+
+    before do
+      request.stub_chain(:params, :fetch) { payload }
+      response.stub :write
     end
-  end
 
-  describe 'announcing build results' do
-    it 'should work idk' do
-      subject.announce 'hi there'
+    it 'replies to the POSTer with the parsed notification text' do
+      expect(response).to receive(:write).with(/ruby-bookbot/)
+      subject.parse_travis_webhook(request, response)
+    end
+
+    it 'calls :handle_travis_build' do
+      expect(subject).to receive(:handle_travis_build)
+      subject.parse_travis_webhook(request, response)
+    end
+
+    it 'lets shares the build info in chat' do
+      expect(subject).to receive(:announce)
+        .with(/ruby-bookbot.+some Travis magic/i)
+      subject.parse_travis_webhook(request, response)
+    end
+
+    context 'the dummy post is a failed build' do
+      let(:payload) { load_fixture 'travis_failure' }
+
+      it 'lets folks know about the failure in chat before pasting the link' do
+        expect(subject).to receive(:announce).exactly(2).times
+        subject.parse_travis_webhook(request, response)
+      end
     end
   end
 end

data/spec/lita/travis_webhook_spec.rb

@@ -1,9 +1,11 @@
 require 'spec_helper'
-require 'pry'
+require 'json'
 
 describe Lita::TravisWebhook do
   let(:input_path) { 'travis_success' }
-  let(:json_input) { load_fixture input_path }
+  let(:raw_input) { load_fixture input_path }
+  let(:json_input) { JSON.parse raw_input }
+
   subject { Lita::TravisWebhook.new json_input }
 
   it 'should parse a known good response' do
@@ -15,7 +17,7 @@ describe Lita::TravisWebhook do
     expect(subject.working?).to be_truthy
     expect(subject.broken?).to be_falsey
   end
- 
+
   context 'a failed build' do
     let(:input_path) { 'travis_failure' }
 
@@ -24,4 +26,37 @@ describe Lita::TravisWebhook do
       expect(subject.broken?).to be_truthy
     end
   end
+
+  describe ':notification_string' do
+    let(:result) { subject.notification_string }
+
+    it 'should include the build status' do
+      subject.stub(:description) { 'hi mom' }
+      expect(result).to include 'hi mom'
+    end
+
+    it 'should include the repo name' do
+      expect(result).to include 'ruby-bookbot'
+    end
+
+    it 'should include the compare URL for the commit' do
+      expect(result).to include 'https://github.com/dpritchett/ruby-bookbot/compare/632250aff63e...7379b6e92f7d'
+    end
+
+    context 'a bad build' do
+      let(:input_path) { 'travis_failure' }
+
+      it 'should include the compare URL for the commit' do
+        expect(result).to include 'https://github.com/dpritchett/ruby-bookbot/commit/64794d01af72'
+      end
+    end
+
+    context 'malformed input' do
+      let(:input_path) { 'travis_malformed' }
+
+      it 'throws an error when parsing' do
+        expect { subject.description }.to raise_error JSON::ParserError
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -8,5 +8,5 @@ Lita.version_3_compatibility_mode = false
 # load a webhook fixture from a JSON file
 def load_fixture(name)
   path = File.join('spec', 'fixtures', "#{name}.json")
-   open(path).readlines.join("\n")
+  open(path).readlines.join("\n")
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-travis-announcer
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Daniel J. Pritchett
@@ -113,6 +113,7 @@ files:
 - lita-travis-announcer.gemspec
 - locales/en.yml
 - spec/fixtures/travis_failure.json
+- spec/fixtures/travis_malformed.json
 - spec/fixtures/travis_success.json
 - spec/lita/handlers/travis_announcer_spec.rb
 - spec/lita/travis_webhook_spec.rb
@@ -146,6 +147,7 @@ specification_version: 4
 summary: Chatops tools for announcing and deploying successful software builds
 test_files:
 - spec/fixtures/travis_failure.json
+- spec/fixtures/travis_malformed.json
 - spec/fixtures/travis_success.json
 - spec/lita/handlers/travis_announcer_spec.rb
 - spec/lita/travis_webhook_spec.rb