lita-ticket_notifier 0.0.16 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 07ea5e3f9e0d1f5ded04baf1b61b9c5e95758dd6
-  data.tar.gz: 7d286988170deac84b84b5bf28f44c0efc8b0e0d
+  metadata.gz: 8b80a502e26bde3b64f26ec101abc9197d8a99db
+  data.tar.gz: 99a0e39ef697bc37e50245501ebc4b6f191df388
 SHA512:
-  metadata.gz: 8866bb90007f009360654c90ac4b4355956428ff41dcacff5934e24ff9ee8b42199dde6d308e6208749f3a7369cabec8a4f7d01e4d32243fee28a7d7f90f4c24
-  data.tar.gz: 2f22fbe3bba62260695bcd7cd0711e50981e6f11b29acefd3ba154632ad2ca526058b3e18858409335e9cfbdf63fee54d6bac230ce458a6ede0ac829c34222c0
+  metadata.gz: b5f2d71bd678b6de2263a153ed6adf9749b48a6d25b441cb1df3b40ab29ed425290f584ea93552f373b6a78bfdf7f7a4c020703c3ca37a3dc23fee83c29687f9
+  data.tar.gz: daa99f4220a17de77a0ca03742c54a4367786ee02dd7bc72b926242830afb19559f696bb7abc4fda90c4afcfb3baad42b65e571e4d868b102723d6eb1e26143f

data/lib/lita/handlers/ticket_notifier.rb

@@ -2,6 +2,11 @@ module Lita
   module Handlers
     class TicketNotifier < Handler
       attr_accessor :ticket_json, :ticket_object
+
+      def self.default_config(config)
+        config.tags_watching = ''
+      end
+
       http.post "/ticket_notification", :ticket_notification
 
       route(/ticket notify start/i, :add_ticket_notification, command: true,
@@ -15,7 +20,7 @@ module Lita
       def ticket_notification(request, response)
         self.ticket_json ||= JSON.parse(request.body.read)
         user_names.each do |user_name|
-          send_message_to_user(user_name, ticket_message)
+          send_message_to_user(user_name, ticket_message) if notify?
         end
       end
 
@@ -35,6 +40,22 @@ module Lita
 
     private
 
+      def tags_watching
+        Lita.config.handlers.ticket_notifier.tags_watching
+      end
+
+      def watching_all_tags?
+        tags_watching.empty?
+      end
+
+      def watching_tag?
+        (ticket.tag.split & tags_watching.split).any?
+      end
+
+      def notify?
+        watching_all_tags? || watching_tag?
+      end
+
       def send_message_to_user(user_name, message)
         robot.send_message(source_from_name(user_name), message)
       end

data/lita-ticket_notifier.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-ticket_notifier"
-  spec.version       = "0.0.16"
+  spec.version       = "0.0.17"
   spec.authors       = ["Michael van den Beuken", "Ruben Estevez", "Jordan Babe", "Mathieu Gilbert", "Ryan Jones", "Darko Dosenovic"]
   spec.email         = ["michael.beuken@gmail.com", "ruben.a.estevez@gmail.com", "jorbabe@gmail.com", "mathieu.gilbert@ama.ab.ca", "ryan.michael.jones@gmail.com", "darko.dosenovic@ama.ab.ca"]
   spec.description   = %q{Notify users about new tickets coming in.}

data/spec/fixtures/ticket.json

@@ -21,7 +21,7 @@
         "project_id": 66073,
         "spam": false,
         "state": "review",
-        "tag": "dev",
+        "tag": "dev pies",
         "title": "test ticket",
         "updated_at": "2014-08-06T22:55:32Z",
         "url": "http://waffles.lighthouseapp.com/projects/1/tickets/200",

data/spec/fixtures/unwatched_ticket.json

@@ -0,0 +1,36 @@
+{
+    "version": {
+        "assigned_user_id": null,
+        "attachments_count": 0,
+        "body": "",
+        "body_html": "",
+        "closed": true,
+        "created_at": "2014-08-06T22:55:30Z",
+        "creator_id": 240273,
+        "creator_name": "Mathieu Gilbert",
+        "diffable_attributes": {
+            "state": "resolved"
+        },
+        "importance": 3,
+        "importance_name": "Low",
+        "milestone_id": null,
+        "milestone_order": 9999,
+        "number": 4146,
+        "permalink": "test-ticket",
+        "priority": 3,
+        "project_id": 66073,
+        "spam": false,
+        "state": "review",
+        "tag": "doomsday",
+        "title": "test ticket",
+        "updated_at": "2014-08-06T22:55:32Z",
+        "url": "http://waffles.lighthouseapp.com/projects/1/tickets/200",
+        "user_id": 240273,
+        "user_name": "Mathieu Gilbert",
+        "version": 3,
+        "watchers_ids": [
+            240273,
+            216682
+        ]
+    }
+}

data/spec/lita/handlers/ticket_notifier_spec.rb

@@ -4,9 +4,16 @@ require "json"
 describe Lita::Handlers::TicketNotifier, lita_handler: true do
   let(:payload) { File.read(File.join('spec', 'fixtures', 'ticket.json')) }
   let(:request) { OpenStruct.new({ body: OpenStruct.new({ read: payload }) }) }
+  let(:unwatched_payload) { File.read(File.join('spec', 'fixtures', 'unwatched_ticket.json')) }
+  let(:unwatched_request) { OpenStruct.new({ body: OpenStruct.new({ read: unwatched_payload }) }) }
+
   let(:teddy) { Lita::User.create(123, name: "Teddy Ruxbin") }
   let(:batman) { Lita::User.create(567, name: "The Batman") }
-  let(:ticket_messsage) { "Ticket: test ticket\nState:review\nImportance:Low\nTags:dev\nhttp://waffles.lighthouseapp.com/projects/1/tickets/200" }
+  let(:ticket_messsage) { "Ticket: test ticket\nState:review\nImportance:Low\nTags:dev pies\nhttp://waffles.lighthouseapp.com/projects/1/tickets/200" }
+
+  before(:each) do
+    Lita.config.handlers.ticket_notifier.tags_watching = 'pies cakes'
+  end
 
   it { routes_command("ticket notify start").to(:add_ticket_notification) }
   it { routes_command("ticket notify stop").to(:remove_ticket_notification) }
@@ -25,6 +32,31 @@ describe Lita::Handlers::TicketNotifier, lita_handler: true do
     subject.ticket_notification(request, nil)
   end
 
+  it "sends notifications for chosen tags" do
+    expect(subject).to receive(:send_message_to_user).once
+
+    send_command("ticket notify start")
+
+    subject.ticket_notification(request, nil)
+  end
+
+  it "defaults to watching all tags" do
+    Lita.config.handlers.ticket_notifier.tags_watching = ''
+    expect(subject).to receive(:send_message_to_user).once
+
+    send_command("ticket notify start")
+
+    subject.ticket_notification(request, nil)
+  end
+
+  it "doesn't send notifications for unwatched tags" do
+    expect(subject).to_not receive(:send_message_to_user)
+
+    send_command("ticket notify start")
+
+    subject.ticket_notification(unwatched_request, nil)
+  end
+
   it "doesn't add you twice" do
     send_command("ticket notify start")
     send_command("ticket notify start")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-ticket_notifier
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.17
 platform: ruby
 authors:
 - Michael van den Beuken
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2014-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -107,6 +107,7 @@ files:
 - lita-ticket_notifier.gemspec
 - locales/en.yml
 - spec/fixtures/ticket.json
+- spec/fixtures/unwatched_ticket.json
 - spec/lita/handlers/ticket_notifier_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/amaabca/lita-ticket_notifier
@@ -136,5 +137,6 @@ specification_version: 4
 summary: Users can opt-in/out from Lighthouse new ticket notifications.
 test_files:
 - spec/fixtures/ticket.json
+- spec/fixtures/unwatched_ticket.json
 - spec/lita/handlers/ticket_notifier_spec.rb
 - spec/spec_helper.rb