lita-ticket_notifier 0.0.15 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36e52f4c9a8723044f660371ed54dc1440f0b54e
-  data.tar.gz: 6c3e6757f9610ddf09fea04bff0fb7ab7a432bab
+  metadata.gz: 07ea5e3f9e0d1f5ded04baf1b61b9c5e95758dd6
+  data.tar.gz: 7d286988170deac84b84b5bf28f44c0efc8b0e0d
 SHA512:
-  metadata.gz: 0496fc3b78aeca3868522e1d9d298009a32893ec7747d590c2ee2ed2b66eb1719b8711a802d497e7aab93bd3f43789898d6fb5b2c9bcb8337f44532356fa783a
-  data.tar.gz: 75715e06f09895afb54187185c3efed1a3e9ee248b2c89ffe8c162a0c08d2745aff8f65da8174ca93c10f1910d077e95f6108a7c1990e80aedcf97766c170488
+  metadata.gz: 8866bb90007f009360654c90ac4b4355956428ff41dcacff5934e24ff9ee8b42199dde6d308e6208749f3a7369cabec8a4f7d01e4d32243fee28a7d7f90f4c24
+  data.tar.gz: 2f22fbe3bba62260695bcd7cd0711e50981e6f11b29acefd3ba154632ad2ca526058b3e18858409335e9cfbdf63fee54d6bac230ce458a6ede0ac829c34222c0

data/lib/lita/handlers/ticket_notifier.rb

@@ -20,11 +20,15 @@ module Lita
       end
 
       def add_ticket_notification(response)
+        response.reply_privately "You're already on the list." and return if user_names.include? response.user.name
+
         redis.lpush("ticket_users", response.user.name)
         response.reply_privately "You will now get notified of ticket updates."
       end
 
       def remove_ticket_notification(response)
+        response.reply_privately "You weren't on the list." and return unless user_names.include? response.user.name
+
         redis.lrem("ticket_users", 0, response.user.name)
         response.reply_privately "You will no longer receive ticket update notifications."
       end

data/lita-ticket_notifier.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-ticket_notifier"
-  spec.version       = "0.0.15"
+  spec.version       = "0.0.16"
   spec.authors       = ["Michael van den Beuken", "Ruben Estevez", "Jordan Babe", "Mathieu Gilbert", "Ryan Jones", "Darko Dosenovic"]
   spec.email         = ["michael.beuken@gmail.com", "ruben.a.estevez@gmail.com", "jorbabe@gmail.com", "mathieu.gilbert@ama.ab.ca", "ryan.michael.jones@gmail.com", "darko.dosenovic@ama.ab.ca"]
   spec.description   = %q{Notify users about new tickets coming in.}

data/spec/lita/handlers/ticket_notifier_spec.rb

@@ -25,6 +25,26 @@ describe Lita::Handlers::TicketNotifier, lita_handler: true do
     subject.ticket_notification(request, nil)
   end
 
+  it "doesn't add you twice" do
+    send_command("ticket notify start")
+    send_command("ticket notify start")
+
+    expect(replies.count).to eq(2)
+    expect(replies.first).to eq("You will now get notified of ticket updates.")
+    expect(replies.last).to eq("You're already on the list.")
+
+    expect(subject).to receive(:send_message_to_user).once
+
+    subject.ticket_notification(request, nil)
+  end
+
+  it "lets you know you're already not getting notifications" do
+    send_command("ticket notify stop")
+
+    expect(replies.count).to eq(1)
+    expect(replies.first).to eq("You weren't on the list.")
+  end
+
   it "doesn't send notifications to nobody" do
     expect(subject).to_not receive(:send_message_to_user)
     subject.ticket_notification(request, nil)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-ticket_notifier
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors:
 - Michael van den Beuken