lita-stocks 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3a7fd275422bfebddc45317dc7f3da4437aa9207
-  data.tar.gz: 9b9bb0fbfe4e7c750a50f5a2f638bb26f39f7211
+  metadata.gz: 8a03cc9ae4756d10416e873a065fe60faa46479f
+  data.tar.gz: cc1c5b78c7fd3d8631f94353e02e7ad286e8a6a8
 SHA512:
-  metadata.gz: b912a31430ca6e7a319b9286f67a1441f613fa661f7c5fc94129247a059052cc6be20845af76c27a1c63a0f36883a4ce60ee9b9221006ff41a73e7beba49a0eb
-  data.tar.gz: ec831fd016a420db0fa18547439245fc13fa70afa9ea6d39fa62a5110cc4f47e177efc69e107457289e87b3930f25b480ad3ec913c5ca8b51125cd4efcbca6a9
+  metadata.gz: 2e26a75e9725c6cf26676202f941d1b0877dd2c5c5c2ac6dd580049daa5d9da156c415d79f35c5c72a9af3e85018335e0707f68bceb7b1dff9a2596a8d0f9571
+  data.tar.gz: 870481ebfb5cbc8a4af97f6d8e0fb92e2190464d3160bde6355af5f59dbb4b93aebd07e800d323d740b9064999bea9d08354afaa526199979fb455d434fa81f3

data/lib/lita/handlers/stocks.rb

@@ -30,7 +30,16 @@ module Lita
       end
 
       def format_response(data)
-        "#{data['name']} (#{data['e']}:#{data['t']}) - #{data['l']} (#{data['c']}, #{data['cp']}%) - 52week high/low: (#{data['hi52']}/#{data['lo52']}) - MktCap: #{data['mc']} - P/E: #{data['pe']}"
+        line = []
+        line << "#{data['name']} (#{data['e']}:#{data['t']})"
+        line << "#{data['l']} (#{data['c']}, #{data['cp']}%)"
+        line << "52week high/low: (#{data['hi52']}/#{data['lo52']})"
+
+        # don't include these sections if they don't exist
+        line << "MktCap: #{data['mc']}" unless data['mc'].empty?
+        line << "P/E: #{data['pe']}" unless data['pe'].empty?
+
+        line.join ' - '
       end
 
 

data/lita-stocks.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-stocks"
-  spec.version       = "0.0.3"
+  spec.version       = "0.0.4"
   spec.authors       = ["Mitch Dempsey"]
   spec.email         = ["mrdempsey@gmail.com"]
   spec.description   = %q{A Lita handler that displays stock prices}

data/spec/lita/handlers/stocks_spec.rb

@@ -9,10 +9,18 @@ describe Lita::Handlers::Stocks, lita_handler: true do
     expect(replies.last).to include("Google Inc")
     expect(replies.last).to include("GOOG")
     expect(replies.last).to include("NASDAQ")
+    expect(replies.last).to include("MktCap")
   end
 
   it "checks an invalid stock" do
     send_command "stock GOOGFAKE"
     expect(replies.last).to eq("Sorry, but there was a problem retrieving stock information.")
   end
+
+  it "checks a stock without mktcap" do
+    send_command "stock .DJI"
+    expect(replies.last).to include("Dow Jones Industrial")
+    expect(replies.last).to_not include("MktCap")
+    expect(replies.last).to_not include("P/E")
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-stocks
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Mitch Dempsey